Skip to content

Migrate Discord module to JDA 5 - #4786

Merged
JRoy merged 6 commits into
2.xfrom
dependencies/jda-5
Jul 1, 2023
Merged

Migrate Discord module to JDA 5#4786
JRoy merged 6 commits into
2.xfrom
dependencies/jda-5

Conversation

@JRoy

@JRoyJRoy commented Jan 29, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Updates EssentialsXDiscord to use the v5 release of JDA

No change in API and link module will require zero updates, as both don't touch JDA at all.

merge EssentialsX/Website#92 with this

REBASE AND MERGE

@JRoyJRoy added type: enhancement Features and feature requests. module: discord Issues or PRs for the EssentialsDiscord module labels Jan 29, 2022
@JRoyJRoy added this to the 2.20.0 milestone Jan 29, 2022
pop4959
pop4959 reviewed Feb 13, 2022
View reviewed changes

@pop4959pop4959 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far

@JRoy
JRoyforce-pushed the dependencies/jda-5 branch from 687f56c to 85b906fCompareFebruary 20, 2022 22:21
@JRoy
JRoy marked this pull request as ready for review July 5, 2022 17:40
@JRoy
JRoy marked this pull request as draft July 5, 2022 17:41
@JRoy

JRoy commented Aug 17, 2022

Copy link
Copy Markdown
MemberAuthor

TODO: use jda's SplitUtil in next JDA bump

@JRoy

JRoy commented Aug 21, 2022

Copy link
Copy Markdown
MemberAuthor

TODO: use jda's SplitUtil in next JDA bump

nvm my code is better

@JRoyJRoy mentioned this pull request Aug 22, 2022
Closed
@JRoyJRoy modified the milestones: 2.20.0, 2.21.0Apr 28, 2023
@JRoyJRoy modified the milestones: 2.21.0, 2.20.1Jun 20, 2023
@JRoy
JRoy marked this pull request as ready for review June 20, 2023 14:56
@JRoy
JRoyforce-pushed the dependencies/jda-5 branch 2 times, most recently from 53736b4 to d554eabCompareJune 20, 2023 18:02
@JRoyJRoy mentioned this pull request Jun 26, 2023
Closed
@JRoy
JRoyforce-pushed the dependencies/jda-5 branch from ae180dc to 5487688CompareJuly 1, 2023 19:44
@JRoy
JRoyforce-pushed the dependencies/jda-5 branch from 5487688 to fe613b9CompareJuly 1, 2023 21:41
@JRoy
JRoy merged commit d57094c into 2.xJul 1, 2023
@JRoy
JRoy deleted the dependencies/jda-5 branch July 1, 2023 21:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pop4959pop4959pop4959 left review comments
@mdcfemdcfemdcfe approved these changes
+1 more reviewer
@Andre601Andre601Andre601 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

module: discordIssues or PRs for the EssentialsDiscord moduletype: enhancementFeatures and feature requests.

Projects

None yet

Milestone

2.20.1

Development

Successfully merging this pull request may close these issues.

4 participants

@JRoy@mdcfe@Andre601@pop4959