Skip to content

Fix preemptive setting of owner metadata on to trade signs - #4835

Merged
mdcfe merged 1 commit into
EssentialsX:2.xfrom
JRoy:fix/jroy-code
Mar 8, 2022
Merged

Fix preemptive setting of owner metadata on to trade signs#4835
mdcfe merged 1 commit into
EssentialsX:2.xfrom
JRoy:fix/jroy-code

Conversation

@JRoy

@JRoyJRoy commented Mar 8, 2022

Copy link
Copy Markdown
Member

Fixes#4836.

JRoy code

image

@JRoyJRoy added bug: confirmed Confirmed bugs in EssentialsX. module: main Issues or PRs for the main Essentials module labels Mar 8, 2022
@JRoyJRoy added this to the 2.19.4 milestone Mar 8, 2022
@mdcfe
mdcfe self-requested a review March 8, 2022 12:38

@mdcfemdcfe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still some consistency issues UUIDs aren't always set when a sign is placed nor are they always converted on first use after an upgrade. This does, however, fix the conversion problems in #4836.

@mdcfe
mdcfe merged commit 997fb18 into EssentialsX:2.xMar 8, 2022
@mdcfe
mdcfe deleted the fix/jroy-code branch March 8, 2022 15:08
ressidell pushed a commit to ressidell/Essentials that referenced this pull request Apr 27, 2025
rewsdjad1 pushed a commit to rewsdjad1/EssentialsXPlus that referenced this pull request Aug 13, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: confirmedConfirmed bugs in EssentialsX.module: mainIssues or PRs for the main Essentials module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trade signs change owner if used by another player for the first time after upgrading EssentialsX

2 participants

@JRoy@mdcfe