Skip to content

Implement chat message signing for 1.19.1+ - #5030

Merged
mdcfe merged 8 commits into
2.xfrom
feature/chat-signing
Aug 6, 2022
Merged

Implement chat message signing for 1.19.1+#5030
mdcfe merged 8 commits into
2.xfrom
feature/chat-signing

Conversation

@mdcfe

@mdcfemdcfe commented Aug 2, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Information

This PR refactors EssentialsX Chat in order to support chat previews and signed chat messages in 1.19.1.

Details

Environments tested:

  • Most recent Paper version (1.19.1, git-Paper-102)
  • Paper 1.18.2 (git-Paper-387)

Demonstration:

Regular formatted chat is signed
Local chat, /toggleshout and shout/question prefix messages all signed

@mdcfemdcfe added the type: enhancement Features and feature requests. label Aug 2, 2022
@mdcfemdcfe added this to the 2.19.5 milestone Aug 2, 2022
@mdcfe
mdcfe requested a review from JRoyAugust 2, 2022 19:55
JRoy
JRoy requested changes Aug 2, 2022
View reviewed changes

@JRoyJRoy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first skim

Comment threadEssentialsChat/src/main/java/com/earth2me/essentials/chat/processing/AbstractChatHandler.java Outdated
Comment threadEssentialsChat/src/main/java/com/earth2me/essentials/chat/processing/AbstractChatHandler.java Outdated
Comment threadEssentialsChat/src/main/java/com/earth2me/essentials/chat/processing/AbstractChatHandler.java Outdated
Comment threadEssentialsChat/src/main/java/com/earth2me/essentials/chat/processing/AbstractChatHandler.java
Comment threadEssentialsChat/src/main/java/com/earth2me/essentials/chat/processing/SignedChatHandler.java
@mdcfemdcfe mentioned this pull request Aug 3, 2022
Closed
mdcfe
mdcfe commented Aug 6, 2022
View reviewed changes
Comment threadEssentialsChat/src/main/java/com/earth2me/essentials/chat/processing/AbstractChatHandler.java Outdated
@mdcfe
mdcfe marked this pull request as ready for review August 6, 2022 15:49
@mdcfe
mdcfe requested a review from JRoyAugust 6, 2022 15:50
JRoy
JRoy approved these changes Aug 6, 2022
View reviewed changes
@mdcfe

mdcfe commented Aug 6, 2022

Copy link
Copy Markdown
MemberAuthor

Known issue: this inadvertently reformats /minecraft:tell. There's not much we can do about this in 2.19.x.

@mdcfe
mdcfe merged commit 6dfa18c into 2.xAug 6, 2022
@mdcfe
mdcfe deleted the feature/chat-signing branch August 6, 2022 21:28
@Pantera07

Pantera07 commented Aug 7, 2022

Copy link
Copy Markdown
Contributor

2022-08-07_17 46 54

[17:46:50] [Async Chat Thread - #0/INFO]: Mad_Daniel: test
[17:46:57] [Server thread/INFO]: [Essentials] CONSOLE issued server command: /ess version
[17:46:57] [Server thread/INFO]: Server version: 1.19.2-R0.1-SNAPSHOT git-Paper-113 (MC: 1.19.2)
[17:46:57] [Server thread/INFO]: Brand version: Paper
[17:46:57] [Server thread/INFO]: EssentialsX version: 2.19.5-dev+38-6dfa18c
[17:46:57] [Server thread/INFO]: Vault version: 1.7.3-b131
[17:46:57] [Server thread/INFO]: EssentialsXChat version: 2.19.5-dev+38-6dfa18c
[17:46:57] [Server thread/INFO]: Economy Layer: None
[17:46:57] [Server thread/INFO]: Fetching version information...
[17:46:57] [Craft Scheduler Thread - 2 - Essentials/INFO]: You're running the latest EssentialsX dev build!
[17:50:03] [Server thread/INFO]: Plugins (3): Essentials, EssentialsChat, Vault

How can I solve this?

@mdcfe

mdcfe commented Aug 7, 2022

Copy link
Copy Markdown
MemberAuthor

[...]

How can I solve this?

@Pantera07 Did you enable previews in your server.properties?

@Pantera07

Pantera07 commented Aug 7, 2022

Copy link
Copy Markdown
Contributor

[...]
How can I solve this?

@Pantera07 Did you enable previews in your server.properties?

thank! I enable previews and this issue is resolved.

@osfanbuff63osfanbuff63 mentioned this pull request Aug 7, 2022
Closed
ressidell pushed a commit to ressidell/Essentials that referenced this pull request Apr 27, 2025
@mdcfe
Implement chat message signing for 1.19.1+ (EssentialsX#5030)
107e69f
**Known issue: this inadvertently reformats `/minecraft:tell`. There's not much we can do about this in 2.19.x.**
This commit refactors EssentialsX Chat in order to support chat previews and signed chat messages in 1.19.1+.
rewsdjad1 pushed a commit to rewsdjad1/EssentialsXPlus that referenced this pull request Aug 13, 2026
@mdcfe
Implement chat message signing for 1.19.1+ (EssentialsX#5030)
e702374
**Known issue: this inadvertently reformats `/minecraft:tell`. There's not much we can do about this in 2.19.x.**
This commit refactors EssentialsX Chat in order to support chat previews and signed chat messages in 1.19.1+.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JRoyJRoyJRoy approved these changes

Assignees

No one assigned

Labels

type: enhancementFeatures and feature requests.

Projects

None yet

Milestone

2.19.5

Development

Successfully merging this pull request may close these issues.

3 participants

@mdcfe@Pantera07@JRoy