Skip to content

Fix issues with chat preview refactor - #5062

Merged
JRoy merged 3 commits into
2.xfrom
fix/local-chat
Aug 14, 2022
Merged

Fix issues with chat preview refactor#5062
JRoy merged 3 commits into
2.xfrom
fix/local-chat

Conversation

@mdcfe

@mdcfemdcfe commented Aug 14, 2022

Copy link
Copy Markdown
Member

Information

  1. This PR fixesSudo c: makes the player send their previewed message #5055.
  2. It also fixes a separate issue in which all local chat messages are sent globally.

Details

Proposed fix:

  1. AsyncPlayerChatEvents fired by a Player#chat call are expected to be on the main thread. Check for this before applying the format from the player's preview.
  2. Pass the radius from the IntermediateChat to the ProcessedChat when moving from one state to the other.

Environments tested:

OS: Windows 11 22H2

Java version: Eclipse Temurin 17.0.2

  • Most recent Paper version (1.19.2, git-Paper-129)
  • CraftBukkit/Spigot/Paper 1.12.2
  • CraftBukkit 1.8.8

@mdcfemdcfe added this to the 2.20.0 milestone Aug 14, 2022
@mdcfemdcfe added bug: confirmed Confirmed bugs in EssentialsX. module: chat Issues or PRs for the EssentialsChat module type: bugfix PRs that fix bugs in EssentialsX. labels Aug 14, 2022
@JRoy
JRoy merged commit 2f4f555 into 2.xAug 14, 2022
@JRoy
JRoy deleted the fix/local-chat branch August 14, 2022 22:50
@mdcfemdcfe modified the milestones: 2.20.0, 2.19.7Aug 15, 2022
@SrBedrockSrBedrock mentioned this pull request Aug 15, 2022
Merged
ressidell pushed a commit to ressidell/Essentials that referenced this pull request Apr 27, 2025
@mdcfe@JRoy
Fix issues with chat preview refactor (EssentialsX#5062)
87d657c
Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
rewsdjad1 pushed a commit to rewsdjad1/EssentialsXPlus that referenced this pull request Aug 13, 2026
@mdcfe@JRoy
Fix issues with chat preview refactor (EssentialsX#5062)
1013ee5
Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JRoyJRoyJRoy approved these changes

Assignees

No one assigned

Labels

bug: confirmedConfirmed bugs in EssentialsX.module: chatIssues or PRs for the EssentialsChat moduletype: bugfixPRs that fix bugs in EssentialsX.

Projects

None yet

Milestone

2.19.7

Development

Successfully merging this pull request may close these issues.

Sudo c: makes the player send their previewed message

2 participants

@mdcfe@JRoy