Uh oh!
There was an error while loading. Please reload this page.
Fix rgb color codes getting stripped in some cases - #5076
Merged
Conversation
pop4959
approved these changes
Aug 18, 2022
mdcfe
approved these changes
Aug 18, 2022
JRoy
enabled auto-merge (squash)
August 18, 2022 17:27
ressidell pushed a commit
to ressidell/Essentials
that referenced
this pull request
Apr 27, 2025
rewsdjad1 pushed a commit
to rewsdjad1/EssentialsXPlus
that referenced
this pull request
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#5058
In cases where a user has
essentials.color.rgbbut not all color codes (essentials.color.color), the strip functionality inFormatUtil#formatStringwill sometimes strip rgb codes in the md_5 format. Moving the strip before the format maintains strip behavior as well as prevents this from happening.