Skip to content

Backup and Logger Fixes - #5077

Merged
JRoy merged 2 commits into
EssentialsX:2.xfrom
JRoy:fix/4999
Aug 18, 2022
Merged

Backup and Logger Fixes#5077
JRoy merged 2 commits into
EssentialsX:2.xfrom
JRoy:fix/4999

Conversation

@JRoy

@JRoyJRoy commented Aug 18, 2022

Copy link
Copy Markdown
Member

rebase and merge

Fixes#4999

@JRoyJRoy added type: bugfix PRs that fix bugs in EssentialsX. module: main Issues or PRs for the main Essentials module labels Aug 18, 2022
@JRoyJRoy added this to the 2.19.7 milestone Aug 18, 2022
@JRoy
JRoy enabled auto-merge (rebase) August 18, 2022 17:41
@JRoy
JRoy merged commit 0be056b into EssentialsX:2.xAug 18, 2022
@JRoy
JRoy deleted the fix/4999 branch August 18, 2022 23:51
@DuckDuckWhale

Copy link
Copy Markdown

Hmm, I wonder why return immediately when when the message is null? Wouldn't it be better to issue a warning in the log to help discover bugs like #4999?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: mainIssues or PRs for the main Essentials moduletype: bugfixPRs that fix bugs in EssentialsX.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NPE when backup script is not executable

3 participants

@JRoy@DuckDuckWhale@mdcfe