Skip to content

Add discord roles blacklist and aliases for chat format - #5157

Merged
JRoy merged 8 commits into
EssentialsX:2.xfrom
x86-39:discord-add-roles-opts
Aug 9, 2023
Merged

Add discord roles blacklist and aliases for chat format#5157
JRoy merged 8 commits into
EssentialsX:2.xfrom
x86-39:discord-add-roles-opts

Conversation

@x86-39

Copy link
Copy Markdown
Contributor

Information

This PR partially closes #5155

Details

Proposed feature:
Add options to only select certain Discord roles and to add aliases for roles.

This is parallel to the DiscordChatChannelRoleAliases and DiscordChatChannelRolesSelection options in DiscordSRV.

This can be used to ignore certain roles, by only selecting roles relating to Minecraft to be processed by the plugin.

The aliases allow for mapping names in Discord to in Minecraft. For example "Admins" can be mapped to "Admin". This can also be used to hardcode which colour a role should be in Minecraft by setting the alias to include a colour code for example: "§9Admin"

Environments tested:

OS: Fedora 36

Java version: 17.0.5

  • Most recent Paper version (1.XX.Y, git-Paper-BUILD)
  • CraftBukkit/Spigot/Paper 1.12.2
  • CraftBukkit 1.8.8
    Don't see how this could differ on other server versions.

Demonstration:

# List of roles which are used for the top role placeholders. If this is empty, all roles will be allowed.discord-roles-selection:
- "Admins"
- "Members"# Aliases for Discord roles before they are sent to Minecraft.discord-roles-aliases:
Admins: "§9Admin"Members: "Member"

The Founder role gets ignored and the Admins role gets translated to §9Admin
image
image

@x86-39x86-39 changed the title Add roles selection optionAdd roles selection option for DiscordNov 16, 2022

@JRoyJRoy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both these features are fine, just a few things;

  • discord-roles-selection should be made into a blacklist rather than a whitelist, be renamed to discord-role-blacklist, and the config should have the examples commented out (like how world-aliases are in the main essentials config).

  • discord-roles-aliases should support both discord role names and ids and have their examples commented out as well.

@x86-39

Copy link
Copy Markdown
ContributorAuthor

I feel like it being a whitelist is still desired in many cases, perhaps an option to turn the whitelist into a blacklist? This is how DiscordSRV does it too.

Will add it to support IDs and comment it out in the config tomorrow

@JRoy

JRoy commented Nov 19, 2022

Copy link
Copy Markdown
Member

I feel like it being a whitelist is still desired in many cases, perhaps an option to turn the whitelist into a blacklist? This is how DiscordSRV does it too.

I think a majority of users will only have a couple of roles they don't want used as top role, such as a default role, rather than a bunch of unwanted top roles

@x86-39

Copy link
Copy Markdown
ContributorAuthor

Maybe a blacklist by default (renaming it to blacklist too) with an option for it to be a whitelist?

@JRoy

JRoy commented Nov 19, 2022

Copy link
Copy Markdown
Member

Maybe a blacklist by default (renaming it to blacklist too) with an option for it to be a whitelist?

I think that would become confusing, do you have an example of a common use case for a whitelist would be better over a blacklist?

@x86-39

Copy link
Copy Markdown
ContributorAuthor

We have staff ranks inside Minecraft which are roles present in Discord, but the Discord has more roles than that. When messages go to the Minecraft server, we only care about those staff roles going to Minecraft. Having a whitelist of just the few staff ranks is a lot easier then.

@x86-39

Copy link
Copy Markdown
ContributorAuthor

@JRoy Any input on this? If you agree with the whitelist suggestion I can implement it and finalise this PR

@JRoy

JRoy commented Dec 11, 2022

Copy link
Copy Markdown
Member

@JRoy Any input on this? If you agree with the whitelist suggestion I can implement it and finalise this PR

Sorry, though I had replied, still convinced that a blacklist would be more useful by default. You can add a boolean config option invert-discord-role-blacklist which is not in the config by default (and has false as its default value) in order to satisfy your usecase.

@x86-39

Copy link
Copy Markdown
ContributorAuthor

Yeah a blacklist by default is fine, I'll add a boolean thank you. Will modify the PR when I have the chance

@x86-39

Copy link
Copy Markdown
ContributorAuthor

Hey @JRoy, apologies I completely forgot about this pull request.

I just made the requested changes and updated the branch.

I also updated the other pull requests I have open:
#5159
#5158

@pop4959pop4959 added type: enhancement Features and feature requests. module: discord Issues or PRs for the EssentialsDiscord module labels May 5, 2023
JRoy
JRoy previously approved these changes Aug 9, 2023
@JRoyJRoy changed the title Add roles selection option for DiscordAdd discord roles blacklist and aliases for chat formatAug 9, 2023
@JRoy
JRoy enabled auto-merge (squash) August 9, 2023 01:34
JRoy
JRoy approved these changes Aug 9, 2023
@JRoy
JRoy merged commit e3e52db into EssentialsX:2.xAug 9, 2023
Starmism pushed a commit to valence-smp/Essentials that referenced this pull request Jan 8, 2025
…5157)
Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
rewsdjad1 pushed a commit to rewsdjad1/EssentialsXPlus that referenced this pull request Aug 13, 2026
…5157)
Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: discordIssues or PRs for the EssentialsDiscord moduletype: enhancementFeatures and feature requests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@x86-39@JRoy@pop4959
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Add discord roles blacklist and aliases for chat format by x86-39 · Pull Request #5157 · EssentialsX/Essentials · GitHub
Skip to content

Add discord roles blacklist and aliases for chat format - #5157

Merged
JRoy merged 8 commits into
EssentialsX:2.xfrom
x86-39:discord-add-roles-opts
Aug 9, 2023
Merged

Add discord roles blacklist and aliases for chat format#5157
JRoy merged 8 commits into
EssentialsX:2.xfrom
x86-39:discord-add-roles-opts

Conversation

@x86-39

Copy link
Copy Markdown
Contributor

Information

This PR partially closes #5155

Details

Proposed feature:
Add options to only select certain Discord roles and to add aliases for roles.

This is parallel to the DiscordChatChannelRoleAliases and DiscordChatChannelRolesSelection options in DiscordSRV.

This can be used to ignore certain roles, by only selecting roles relating to Minecraft to be processed by the plugin.

The aliases allow for mapping names in Discord to in Minecraft. For example "Admins" can be mapped to "Admin". This can also be used to hardcode which colour a role should be in Minecraft by setting the alias to include a colour code for example: "§9Admin"

Environments tested:

OS: Fedora 36

Java version: 17.0.5

  • Most recent Paper version (1.XX.Y, git-Paper-BUILD)
  • CraftBukkit/Spigot/Paper 1.12.2
  • CraftBukkit 1.8.8
    Don't see how this could differ on other server versions.

Demonstration:

# List of roles which are used for the top role placeholders. If this is empty, all roles will be allowed.discord-roles-selection:
- "Admins"
- "Members"# Aliases for Discord roles before they are sent to Minecraft.discord-roles-aliases:
Admins: "§9Admin"Members: "Member"

The Founder role gets ignored and the Admins role gets translated to §9Admin
image
image

@x86-39x86-39 changed the title Add roles selection optionAdd roles selection option for DiscordNov 16, 2022

@JRoyJRoy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both these features are fine, just a few things;

  • discord-roles-selection should be made into a blacklist rather than a whitelist, be renamed to discord-role-blacklist, and the config should have the examples commented out (like how world-aliases are in the main essentials config).

  • discord-roles-aliases should support both discord role names and ids and have their examples commented out as well.

@x86-39

Copy link
Copy Markdown
ContributorAuthor

I feel like it being a whitelist is still desired in many cases, perhaps an option to turn the whitelist into a blacklist? This is how DiscordSRV does it too.

Will add it to support IDs and comment it out in the config tomorrow

@JRoy

JRoy commented Nov 19, 2022

Copy link
Copy Markdown
Member

I feel like it being a whitelist is still desired in many cases, perhaps an option to turn the whitelist into a blacklist? This is how DiscordSRV does it too.

I think a majority of users will only have a couple of roles they don't want used as top role, such as a default role, rather than a bunch of unwanted top roles

@x86-39

Copy link
Copy Markdown
ContributorAuthor

Maybe a blacklist by default (renaming it to blacklist too) with an option for it to be a whitelist?

@JRoy

JRoy commented Nov 19, 2022

Copy link
Copy Markdown
Member

Maybe a blacklist by default (renaming it to blacklist too) with an option for it to be a whitelist?

I think that would become confusing, do you have an example of a common use case for a whitelist would be better over a blacklist?

@x86-39

Copy link
Copy Markdown
ContributorAuthor

We have staff ranks inside Minecraft which are roles present in Discord, but the Discord has more roles than that. When messages go to the Minecraft server, we only care about those staff roles going to Minecraft. Having a whitelist of just the few staff ranks is a lot easier then.

@x86-39

Copy link
Copy Markdown
ContributorAuthor

@JRoy Any input on this? If you agree with the whitelist suggestion I can implement it and finalise this PR

@JRoy

JRoy commented Dec 11, 2022

Copy link
Copy Markdown
Member

@JRoy Any input on this? If you agree with the whitelist suggestion I can implement it and finalise this PR

Sorry, though I had replied, still convinced that a blacklist would be more useful by default. You can add a boolean config option invert-discord-role-blacklist which is not in the config by default (and has false as its default value) in order to satisfy your usecase.

@x86-39

Copy link
Copy Markdown
ContributorAuthor

Yeah a blacklist by default is fine, I'll add a boolean thank you. Will modify the PR when I have the chance

@x86-39

Copy link
Copy Markdown
ContributorAuthor

Hey @JRoy, apologies I completely forgot about this pull request.

I just made the requested changes and updated the branch.

I also updated the other pull requests I have open:
#5159
#5158

@pop4959pop4959 added type: enhancement Features and feature requests. module: discord Issues or PRs for the EssentialsDiscord module labels May 5, 2023
JRoy
JRoy previously approved these changes Aug 9, 2023
@JRoyJRoy changed the title Add roles selection option for DiscordAdd discord roles blacklist and aliases for chat formatAug 9, 2023
@JRoy
JRoy enabled auto-merge (squash) August 9, 2023 01:34
JRoy
JRoy approved these changes Aug 9, 2023
@JRoy
JRoy merged commit e3e52db into EssentialsX:2.xAug 9, 2023
Starmism pushed a commit to valence-smp/Essentials that referenced this pull request Jan 8, 2025
…5157)
Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
rewsdjad1 pushed a commit to rewsdjad1/EssentialsXPlus that referenced this pull request Aug 13, 2026
…5157)
Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: discordIssues or PRs for the EssentialsDiscord moduletype: enhancementFeatures and feature requests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@x86-39@JRoy@pop4959
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Add discord roles blacklist and aliases for chat format by x86-39 · Pull Request #5157 · EssentialsX/Essentials · GitHub
Skip to content

Add discord roles blacklist and aliases for chat format - #5157

Merged
JRoy merged 8 commits into
EssentialsX:2.xfrom
x86-39:discord-add-roles-opts
Aug 9, 2023
Merged

Add discord roles blacklist and aliases for chat format#5157
JRoy merged 8 commits into
EssentialsX:2.xfrom
x86-39:discord-add-roles-opts

Conversation

@x86-39

Copy link
Copy Markdown
Contributor

Information

This PR partially closes #5155

Details

Proposed feature:
Add options to only select certain Discord roles and to add aliases for roles.

This is parallel to the DiscordChatChannelRoleAliases and DiscordChatChannelRolesSelection options in DiscordSRV.

This can be used to ignore certain roles, by only selecting roles relating to Minecraft to be processed by the plugin.

The aliases allow for mapping names in Discord to in Minecraft. For example "Admins" can be mapped to "Admin". This can also be used to hardcode which colour a role should be in Minecraft by setting the alias to include a colour code for example: "§9Admin"

Environments tested:

OS: Fedora 36

Java version: 17.0.5

  • Most recent Paper version (1.XX.Y, git-Paper-BUILD)
  • CraftBukkit/Spigot/Paper 1.12.2
  • CraftBukkit 1.8.8
    Don't see how this could differ on other server versions.

Demonstration:

# List of roles which are used for the top role placeholders. If this is empty, all roles will be allowed.discord-roles-selection:
- "Admins"
- "Members"# Aliases for Discord roles before they are sent to Minecraft.discord-roles-aliases:
Admins: "§9Admin"Members: "Member"

The Founder role gets ignored and the Admins role gets translated to §9Admin
image
image

@x86-39x86-39 changed the title Add roles selection optionAdd roles selection option for DiscordNov 16, 2022

@JRoyJRoy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both these features are fine, just a few things;

  • discord-roles-selection should be made into a blacklist rather than a whitelist, be renamed to discord-role-blacklist, and the config should have the examples commented out (like how world-aliases are in the main essentials config).

  • discord-roles-aliases should support both discord role names and ids and have their examples commented out as well.

@x86-39

Copy link
Copy Markdown
ContributorAuthor

I feel like it being a whitelist is still desired in many cases, perhaps an option to turn the whitelist into a blacklist? This is how DiscordSRV does it too.

Will add it to support IDs and comment it out in the config tomorrow

@JRoy

JRoy commented Nov 19, 2022

Copy link
Copy Markdown
Member

I feel like it being a whitelist is still desired in many cases, perhaps an option to turn the whitelist into a blacklist? This is how DiscordSRV does it too.

I think a majority of users will only have a couple of roles they don't want used as top role, such as a default role, rather than a bunch of unwanted top roles

@x86-39

Copy link
Copy Markdown
ContributorAuthor

Maybe a blacklist by default (renaming it to blacklist too) with an option for it to be a whitelist?

@JRoy

JRoy commented Nov 19, 2022

Copy link
Copy Markdown
Member

Maybe a blacklist by default (renaming it to blacklist too) with an option for it to be a whitelist?

I think that would become confusing, do you have an example of a common use case for a whitelist would be better over a blacklist?

@x86-39

Copy link
Copy Markdown
ContributorAuthor

We have staff ranks inside Minecraft which are roles present in Discord, but the Discord has more roles than that. When messages go to the Minecraft server, we only care about those staff roles going to Minecraft. Having a whitelist of just the few staff ranks is a lot easier then.

@x86-39

Copy link
Copy Markdown
ContributorAuthor

@JRoy Any input on this? If you agree with the whitelist suggestion I can implement it and finalise this PR

@JRoy

JRoy commented Dec 11, 2022

Copy link
Copy Markdown
Member

@JRoy Any input on this? If you agree with the whitelist suggestion I can implement it and finalise this PR

Sorry, though I had replied, still convinced that a blacklist would be more useful by default. You can add a boolean config option invert-discord-role-blacklist which is not in the config by default (and has false as its default value) in order to satisfy your usecase.

@x86-39

Copy link
Copy Markdown
ContributorAuthor

Yeah a blacklist by default is fine, I'll add a boolean thank you. Will modify the PR when I have the chance

@x86-39

Copy link
Copy Markdown
ContributorAuthor

Hey @JRoy, apologies I completely forgot about this pull request.

I just made the requested changes and updated the branch.

I also updated the other pull requests I have open:
#5159
#5158

@pop4959pop4959 added type: enhancement Features and feature requests. module: discord Issues or PRs for the EssentialsDiscord module labels May 5, 2023
JRoy
JRoy previously approved these changes Aug 9, 2023
@JRoyJRoy changed the title Add roles selection option for DiscordAdd discord roles blacklist and aliases for chat formatAug 9, 2023
@JRoy
JRoy enabled auto-merge (squash) August 9, 2023 01:34
JRoy
JRoy approved these changes Aug 9, 2023
@JRoy
JRoy merged commit e3e52db into EssentialsX:2.xAug 9, 2023
Starmism pushed a commit to valence-smp/Essentials that referenced this pull request Jan 8, 2025
…5157)
Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
rewsdjad1 pushed a commit to rewsdjad1/EssentialsXPlus that referenced this pull request Aug 13, 2026
…5157)
Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: discordIssues or PRs for the EssentialsDiscord moduletype: enhancementFeatures and feature requests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@x86-39@JRoy@pop4959
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Add discord roles blacklist and aliases for chat format by x86-39 · Pull Request #5157 · EssentialsX/Essentials · GitHub
Skip to content

Add discord roles blacklist and aliases for chat format - #5157

Merged
JRoy merged 8 commits into
EssentialsX:2.xfrom
x86-39:discord-add-roles-opts
Aug 9, 2023
Merged

Add discord roles blacklist and aliases for chat format#5157
JRoy merged 8 commits into
EssentialsX:2.xfrom
x86-39:discord-add-roles-opts

Conversation

@x86-39

Copy link
Copy Markdown
Contributor

Information

This PR partially closes #5155

Details

Proposed feature:
Add options to only select certain Discord roles and to add aliases for roles.

This is parallel to the DiscordChatChannelRoleAliases and DiscordChatChannelRolesSelection options in DiscordSRV.

This can be used to ignore certain roles, by only selecting roles relating to Minecraft to be processed by the plugin.

The aliases allow for mapping names in Discord to in Minecraft. For example "Admins" can be mapped to "Admin". This can also be used to hardcode which colour a role should be in Minecraft by setting the alias to include a colour code for example: "§9Admin"

Environments tested:

OS: Fedora 36

Java version: 17.0.5

  • Most recent Paper version (1.XX.Y, git-Paper-BUILD)
  • CraftBukkit/Spigot/Paper 1.12.2
  • CraftBukkit 1.8.8
    Don't see how this could differ on other server versions.

Demonstration:

# List of roles which are used for the top role placeholders. If this is empty, all roles will be allowed.discord-roles-selection:
- "Admins"
- "Members"# Aliases for Discord roles before they are sent to Minecraft.discord-roles-aliases:
Admins: "§9Admin"Members: "Member"

The Founder role gets ignored and the Admins role gets translated to §9Admin
image
image

@x86-39x86-39 changed the title Add roles selection optionAdd roles selection option for DiscordNov 16, 2022

@JRoyJRoy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both these features are fine, just a few things;

  • discord-roles-selection should be made into a blacklist rather than a whitelist, be renamed to discord-role-blacklist, and the config should have the examples commented out (like how world-aliases are in the main essentials config).

  • discord-roles-aliases should support both discord role names and ids and have their examples commented out as well.

@x86-39

Copy link
Copy Markdown
ContributorAuthor

I feel like it being a whitelist is still desired in many cases, perhaps an option to turn the whitelist into a blacklist? This is how DiscordSRV does it too.

Will add it to support IDs and comment it out in the config tomorrow

@JRoy

JRoy commented Nov 19, 2022

Copy link
Copy Markdown
Member

I feel like it being a whitelist is still desired in many cases, perhaps an option to turn the whitelist into a blacklist? This is how DiscordSRV does it too.

I think a majority of users will only have a couple of roles they don't want used as top role, such as a default role, rather than a bunch of unwanted top roles

@x86-39

Copy link
Copy Markdown
ContributorAuthor

Maybe a blacklist by default (renaming it to blacklist too) with an option for it to be a whitelist?

@JRoy

JRoy commented Nov 19, 2022

Copy link
Copy Markdown
Member

Maybe a blacklist by default (renaming it to blacklist too) with an option for it to be a whitelist?

I think that would become confusing, do you have an example of a common use case for a whitelist would be better over a blacklist?

@x86-39

Copy link
Copy Markdown
ContributorAuthor

We have staff ranks inside Minecraft which are roles present in Discord, but the Discord has more roles than that. When messages go to the Minecraft server, we only care about those staff roles going to Minecraft. Having a whitelist of just the few staff ranks is a lot easier then.

@x86-39

Copy link
Copy Markdown
ContributorAuthor

@JRoy Any input on this? If you agree with the whitelist suggestion I can implement it and finalise this PR

@JRoy

JRoy commented Dec 11, 2022

Copy link
Copy Markdown
Member

@JRoy Any input on this? If you agree with the whitelist suggestion I can implement it and finalise this PR

Sorry, though I had replied, still convinced that a blacklist would be more useful by default. You can add a boolean config option invert-discord-role-blacklist which is not in the config by default (and has false as its default value) in order to satisfy your usecase.

@x86-39

Copy link
Copy Markdown
ContributorAuthor

Yeah a blacklist by default is fine, I'll add a boolean thank you. Will modify the PR when I have the chance

@x86-39

Copy link
Copy Markdown
ContributorAuthor

Hey @JRoy, apologies I completely forgot about this pull request.

I just made the requested changes and updated the branch.

I also updated the other pull requests I have open:
#5159
#5158

@pop4959pop4959 added type: enhancement Features and feature requests. module: discord Issues or PRs for the EssentialsDiscord module labels May 5, 2023
JRoy
JRoy previously approved these changes Aug 9, 2023
@JRoyJRoy changed the title Add roles selection option for DiscordAdd discord roles blacklist and aliases for chat formatAug 9, 2023
@JRoy
JRoy enabled auto-merge (squash) August 9, 2023 01:34
JRoy
JRoy approved these changes Aug 9, 2023
@JRoy
JRoy merged commit e3e52db into EssentialsX:2.xAug 9, 2023
Starmism pushed a commit to valence-smp/Essentials that referenced this pull request Jan 8, 2025
…5157)
Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
rewsdjad1 pushed a commit to rewsdjad1/EssentialsXPlus that referenced this pull request Aug 13, 2026
…5157)
Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: discordIssues or PRs for the EssentialsDiscord moduletype: enhancementFeatures and feature requests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@x86-39@JRoy@pop4959
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' Add discord roles blacklist and aliases for chat format by x86-39 · Pull Request #5157 · EssentialsX/Essentials · GitHub
Skip to content

Add discord roles blacklist and aliases for chat format - #5157

Merged
JRoy merged 8 commits into
EssentialsX:2.xfrom
x86-39:discord-add-roles-opts
Aug 9, 2023
Merged

Add discord roles blacklist and aliases for chat format#5157
JRoy merged 8 commits into
EssentialsX:2.xfrom
x86-39:discord-add-roles-opts

Conversation

@x86-39

Copy link
Copy Markdown
Contributor

Information

This PR partially closes #5155

Details

Proposed feature:
Add options to only select certain Discord roles and to add aliases for roles.

This is parallel to the DiscordChatChannelRoleAliases and DiscordChatChannelRolesSelection options in DiscordSRV.

This can be used to ignore certain roles, by only selecting roles relating to Minecraft to be processed by the plugin.

The aliases allow for mapping names in Discord to in Minecraft. For example "Admins" can be mapped to "Admin". This can also be used to hardcode which colour a role should be in Minecraft by setting the alias to include a colour code for example: "§9Admin"

Environments tested:

OS: Fedora 36

Java version: 17.0.5

  • Most recent Paper version (1.XX.Y, git-Paper-BUILD)
  • CraftBukkit/Spigot/Paper 1.12.2
  • CraftBukkit 1.8.8
    Don't see how this could differ on other server versions.

Demonstration:

# List of roles which are used for the top role placeholders. If this is empty, all roles will be allowed.discord-roles-selection:
- "Admins"
- "Members"# Aliases for Discord roles before they are sent to Minecraft.discord-roles-aliases:
Admins: "§9Admin"Members: "Member"

The Founder role gets ignored and the Admins role gets translated to §9Admin
image
image

@x86-39x86-39 changed the title Add roles selection optionAdd roles selection option for DiscordNov 16, 2022

@JRoyJRoy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both these features are fine, just a few things;

  • discord-roles-selection should be made into a blacklist rather than a whitelist, be renamed to discord-role-blacklist, and the config should have the examples commented out (like how world-aliases are in the main essentials config).

  • discord-roles-aliases should support both discord role names and ids and have their examples commented out as well.

@x86-39

Copy link
Copy Markdown
ContributorAuthor

I feel like it being a whitelist is still desired in many cases, perhaps an option to turn the whitelist into a blacklist? This is how DiscordSRV does it too.

Will add it to support IDs and comment it out in the config tomorrow

@JRoy

JRoy commented Nov 19, 2022

Copy link
Copy Markdown
Member

I feel like it being a whitelist is still desired in many cases, perhaps an option to turn the whitelist into a blacklist? This is how DiscordSRV does it too.

I think a majority of users will only have a couple of roles they don't want used as top role, such as a default role, rather than a bunch of unwanted top roles

@x86-39

Copy link
Copy Markdown
ContributorAuthor

Maybe a blacklist by default (renaming it to blacklist too) with an option for it to be a whitelist?

@JRoy

JRoy commented Nov 19, 2022

Copy link
Copy Markdown
Member

Maybe a blacklist by default (renaming it to blacklist too) with an option for it to be a whitelist?

I think that would become confusing, do you have an example of a common use case for a whitelist would be better over a blacklist?

@x86-39

Copy link
Copy Markdown
ContributorAuthor

We have staff ranks inside Minecraft which are roles present in Discord, but the Discord has more roles than that. When messages go to the Minecraft server, we only care about those staff roles going to Minecraft. Having a whitelist of just the few staff ranks is a lot easier then.

@x86-39

Copy link
Copy Markdown
ContributorAuthor

@JRoy Any input on this? If you agree with the whitelist suggestion I can implement it and finalise this PR

@JRoy

JRoy commented Dec 11, 2022

Copy link
Copy Markdown
Member

@JRoy Any input on this? If you agree with the whitelist suggestion I can implement it and finalise this PR

Sorry, though I had replied, still convinced that a blacklist would be more useful by default. You can add a boolean config option invert-discord-role-blacklist which is not in the config by default (and has false as its default value) in order to satisfy your usecase.

@x86-39

Copy link
Copy Markdown
ContributorAuthor

Yeah a blacklist by default is fine, I'll add a boolean thank you. Will modify the PR when I have the chance

@x86-39

Copy link
Copy Markdown
ContributorAuthor

Hey @JRoy, apologies I completely forgot about this pull request.

I just made the requested changes and updated the branch.

I also updated the other pull requests I have open:
#5159
#5158

@pop4959pop4959 added type: enhancement Features and feature requests. module: discord Issues or PRs for the EssentialsDiscord module labels May 5, 2023
JRoy
JRoy previously approved these changes Aug 9, 2023
@JRoyJRoy changed the title Add roles selection option for DiscordAdd discord roles blacklist and aliases for chat formatAug 9, 2023
@JRoy
JRoy enabled auto-merge (squash) August 9, 2023 01:34
JRoy
JRoy approved these changes Aug 9, 2023
@JRoy
JRoy merged commit e3e52db into EssentialsX:2.xAug 9, 2023
Starmism pushed a commit to valence-smp/Essentials that referenced this pull request Jan 8, 2025
…5157)
Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
rewsdjad1 pushed a commit to rewsdjad1/EssentialsXPlus that referenced this pull request Aug 13, 2026
…5157)
Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: discordIssues or PRs for the EssentialsDiscord moduletype: enhancementFeatures and feature requests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@x86-39@JRoy@pop4959
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Add discord roles blacklist and aliases for chat format by x86-39 · Pull Request #5157 · EssentialsX/Essentials · GitHub
Skip to content

Add discord roles blacklist and aliases for chat format - #5157

Merged
JRoy merged 8 commits into
EssentialsX:2.xfrom
x86-39:discord-add-roles-opts
Aug 9, 2023
Merged

Add discord roles blacklist and aliases for chat format#5157
JRoy merged 8 commits into
EssentialsX:2.xfrom
x86-39:discord-add-roles-opts

Conversation

@x86-39

Copy link
Copy Markdown
Contributor

Information

This PR partially closes #5155

Details

Proposed feature:
Add options to only select certain Discord roles and to add aliases for roles.

This is parallel to the DiscordChatChannelRoleAliases and DiscordChatChannelRolesSelection options in DiscordSRV.

This can be used to ignore certain roles, by only selecting roles relating to Minecraft to be processed by the plugin.

The aliases allow for mapping names in Discord to in Minecraft. For example "Admins" can be mapped to "Admin". This can also be used to hardcode which colour a role should be in Minecraft by setting the alias to include a colour code for example: "§9Admin"

Environments tested:

OS: Fedora 36

Java version: 17.0.5

  • Most recent Paper version (1.XX.Y, git-Paper-BUILD)
  • CraftBukkit/Spigot/Paper 1.12.2
  • CraftBukkit 1.8.8
    Don't see how this could differ on other server versions.

Demonstration:

# List of roles which are used for the top role placeholders. If this is empty, all roles will be allowed.discord-roles-selection:
- "Admins"
- "Members"# Aliases for Discord roles before they are sent to Minecraft.discord-roles-aliases:
Admins: "§9Admin"Members: "Member"

The Founder role gets ignored and the Admins role gets translated to §9Admin
image
image

@x86-39x86-39 changed the title Add roles selection optionAdd roles selection option for DiscordNov 16, 2022

@JRoyJRoy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both these features are fine, just a few things;

  • discord-roles-selection should be made into a blacklist rather than a whitelist, be renamed to discord-role-blacklist, and the config should have the examples commented out (like how world-aliases are in the main essentials config).

  • discord-roles-aliases should support both discord role names and ids and have their examples commented out as well.

@x86-39

Copy link
Copy Markdown
ContributorAuthor

I feel like it being a whitelist is still desired in many cases, perhaps an option to turn the whitelist into a blacklist? This is how DiscordSRV does it too.

Will add it to support IDs and comment it out in the config tomorrow

@JRoy

JRoy commented Nov 19, 2022

Copy link
Copy Markdown
Member

I feel like it being a whitelist is still desired in many cases, perhaps an option to turn the whitelist into a blacklist? This is how DiscordSRV does it too.

I think a majority of users will only have a couple of roles they don't want used as top role, such as a default role, rather than a bunch of unwanted top roles

@x86-39

Copy link
Copy Markdown
ContributorAuthor

Maybe a blacklist by default (renaming it to blacklist too) with an option for it to be a whitelist?

@JRoy

JRoy commented Nov 19, 2022

Copy link
Copy Markdown
Member

Maybe a blacklist by default (renaming it to blacklist too) with an option for it to be a whitelist?

I think that would become confusing, do you have an example of a common use case for a whitelist would be better over a blacklist?

@x86-39

Copy link
Copy Markdown
ContributorAuthor

We have staff ranks inside Minecraft which are roles present in Discord, but the Discord has more roles than that. When messages go to the Minecraft server, we only care about those staff roles going to Minecraft. Having a whitelist of just the few staff ranks is a lot easier then.

@x86-39

Copy link
Copy Markdown
ContributorAuthor

@JRoy Any input on this? If you agree with the whitelist suggestion I can implement it and finalise this PR

@JRoy

JRoy commented Dec 11, 2022

Copy link
Copy Markdown
Member

@JRoy Any input on this? If you agree with the whitelist suggestion I can implement it and finalise this PR

Sorry, though I had replied, still convinced that a blacklist would be more useful by default. You can add a boolean config option invert-discord-role-blacklist which is not in the config by default (and has false as its default value) in order to satisfy your usecase.

@x86-39

Copy link
Copy Markdown
ContributorAuthor

Yeah a blacklist by default is fine, I'll add a boolean thank you. Will modify the PR when I have the chance

@x86-39

Copy link
Copy Markdown
ContributorAuthor

Hey @JRoy, apologies I completely forgot about this pull request.

I just made the requested changes and updated the branch.

I also updated the other pull requests I have open:
#5159
#5158

@pop4959pop4959 added type: enhancement Features and feature requests. module: discord Issues or PRs for the EssentialsDiscord module labels May 5, 2023
JRoy
JRoy previously approved these changes Aug 9, 2023
@JRoyJRoy changed the title Add roles selection option for DiscordAdd discord roles blacklist and aliases for chat formatAug 9, 2023
@JRoy
JRoy enabled auto-merge (squash) August 9, 2023 01:34
JRoy
JRoy approved these changes Aug 9, 2023
@JRoy
JRoy merged commit e3e52db into EssentialsX:2.xAug 9, 2023
Starmism pushed a commit to valence-smp/Essentials that referenced this pull request Jan 8, 2025
…5157)
Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
rewsdjad1 pushed a commit to rewsdjad1/EssentialsXPlus that referenced this pull request Aug 13, 2026
…5157)
Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: discordIssues or PRs for the EssentialsDiscord moduletype: enhancementFeatures and feature requests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@x86-39@JRoy@pop4959
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Add discord roles blacklist and aliases for chat format by x86-39 · Pull Request #5157 · EssentialsX/Essentials · GitHub
Skip to content

Add discord roles blacklist and aliases for chat format - #5157

Merged
JRoy merged 8 commits into
EssentialsX:2.xfrom
x86-39:discord-add-roles-opts
Aug 9, 2023
Merged

Add discord roles blacklist and aliases for chat format#5157
JRoy merged 8 commits into
EssentialsX:2.xfrom
x86-39:discord-add-roles-opts

Conversation

@x86-39

Copy link
Copy Markdown
Contributor

Information

This PR partially closes #5155

Details

Proposed feature:
Add options to only select certain Discord roles and to add aliases for roles.

This is parallel to the DiscordChatChannelRoleAliases and DiscordChatChannelRolesSelection options in DiscordSRV.

This can be used to ignore certain roles, by only selecting roles relating to Minecraft to be processed by the plugin.

The aliases allow for mapping names in Discord to in Minecraft. For example "Admins" can be mapped to "Admin". This can also be used to hardcode which colour a role should be in Minecraft by setting the alias to include a colour code for example: "§9Admin"

Environments tested:

OS: Fedora 36

Java version: 17.0.5

  • Most recent Paper version (1.XX.Y, git-Paper-BUILD)
  • CraftBukkit/Spigot/Paper 1.12.2
  • CraftBukkit 1.8.8
    Don't see how this could differ on other server versions.

Demonstration:

# List of roles which are used for the top role placeholders. If this is empty, all roles will be allowed.discord-roles-selection:
- "Admins"
- "Members"# Aliases for Discord roles before they are sent to Minecraft.discord-roles-aliases:
Admins: "§9Admin"Members: "Member"

The Founder role gets ignored and the Admins role gets translated to §9Admin
image
image

@x86-39x86-39 changed the title Add roles selection optionAdd roles selection option for DiscordNov 16, 2022

@JRoyJRoy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both these features are fine, just a few things;

  • discord-roles-selection should be made into a blacklist rather than a whitelist, be renamed to discord-role-blacklist, and the config should have the examples commented out (like how world-aliases are in the main essentials config).

  • discord-roles-aliases should support both discord role names and ids and have their examples commented out as well.

@x86-39

Copy link
Copy Markdown
ContributorAuthor

I feel like it being a whitelist is still desired in many cases, perhaps an option to turn the whitelist into a blacklist? This is how DiscordSRV does it too.

Will add it to support IDs and comment it out in the config tomorrow

@JRoy

JRoy commented Nov 19, 2022

Copy link
Copy Markdown
Member

I feel like it being a whitelist is still desired in many cases, perhaps an option to turn the whitelist into a blacklist? This is how DiscordSRV does it too.

I think a majority of users will only have a couple of roles they don't want used as top role, such as a default role, rather than a bunch of unwanted top roles

@x86-39

Copy link
Copy Markdown
ContributorAuthor

Maybe a blacklist by default (renaming it to blacklist too) with an option for it to be a whitelist?

@JRoy

JRoy commented Nov 19, 2022

Copy link
Copy Markdown
Member

Maybe a blacklist by default (renaming it to blacklist too) with an option for it to be a whitelist?

I think that would become confusing, do you have an example of a common use case for a whitelist would be better over a blacklist?

@x86-39

Copy link
Copy Markdown
ContributorAuthor

We have staff ranks inside Minecraft which are roles present in Discord, but the Discord has more roles than that. When messages go to the Minecraft server, we only care about those staff roles going to Minecraft. Having a whitelist of just the few staff ranks is a lot easier then.

@x86-39

Copy link
Copy Markdown
ContributorAuthor

@JRoy Any input on this? If you agree with the whitelist suggestion I can implement it and finalise this PR

@JRoy

JRoy commented Dec 11, 2022

Copy link
Copy Markdown
Member

@JRoy Any input on this? If you agree with the whitelist suggestion I can implement it and finalise this PR

Sorry, though I had replied, still convinced that a blacklist would be more useful by default. You can add a boolean config option invert-discord-role-blacklist which is not in the config by default (and has false as its default value) in order to satisfy your usecase.

@x86-39

Copy link
Copy Markdown
ContributorAuthor

Yeah a blacklist by default is fine, I'll add a boolean thank you. Will modify the PR when I have the chance

@x86-39

Copy link
Copy Markdown
ContributorAuthor

Hey @JRoy, apologies I completely forgot about this pull request.

I just made the requested changes and updated the branch.

I also updated the other pull requests I have open:
#5159
#5158

@pop4959pop4959 added type: enhancement Features and feature requests. module: discord Issues or PRs for the EssentialsDiscord module labels May 5, 2023
JRoy
JRoy previously approved these changes Aug 9, 2023
@JRoyJRoy changed the title Add roles selection option for DiscordAdd discord roles blacklist and aliases for chat formatAug 9, 2023
@JRoy
JRoy enabled auto-merge (squash) August 9, 2023 01:34
JRoy
JRoy approved these changes Aug 9, 2023
@JRoy
JRoy merged commit e3e52db into EssentialsX:2.xAug 9, 2023
Starmism pushed a commit to valence-smp/Essentials that referenced this pull request Jan 8, 2025
…5157)
Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
rewsdjad1 pushed a commit to rewsdjad1/EssentialsXPlus that referenced this pull request Aug 13, 2026
…5157)
Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: discordIssues or PRs for the EssentialsDiscord moduletype: enhancementFeatures and feature requests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@x86-39@JRoy@pop4959
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); Add discord roles blacklist and aliases for chat format by x86-39 · Pull Request #5157 · EssentialsX/Essentials · GitHub
Skip to content

Add discord roles blacklist and aliases for chat format - #5157

Merged
JRoy merged 8 commits into
EssentialsX:2.xfrom
x86-39:discord-add-roles-opts
Aug 9, 2023
Merged

Add discord roles blacklist and aliases for chat format#5157
JRoy merged 8 commits into
EssentialsX:2.xfrom
x86-39:discord-add-roles-opts

Conversation

@x86-39

Copy link
Copy Markdown
Contributor

Information

This PR partially closes #5155

Details

Proposed feature:
Add options to only select certain Discord roles and to add aliases for roles.

This is parallel to the DiscordChatChannelRoleAliases and DiscordChatChannelRolesSelection options in DiscordSRV.

This can be used to ignore certain roles, by only selecting roles relating to Minecraft to be processed by the plugin.

The aliases allow for mapping names in Discord to in Minecraft. For example "Admins" can be mapped to "Admin". This can also be used to hardcode which colour a role should be in Minecraft by setting the alias to include a colour code for example: "§9Admin"

Environments tested:

OS: Fedora 36

Java version: 17.0.5

  • Most recent Paper version (1.XX.Y, git-Paper-BUILD)
  • CraftBukkit/Spigot/Paper 1.12.2
  • CraftBukkit 1.8.8
    Don't see how this could differ on other server versions.

Demonstration:

# List of roles which are used for the top role placeholders. If this is empty, all roles will be allowed.discord-roles-selection:
- "Admins"
- "Members"# Aliases for Discord roles before they are sent to Minecraft.discord-roles-aliases:
Admins: "§9Admin"Members: "Member"

The Founder role gets ignored and the Admins role gets translated to §9Admin
image
image

@x86-39x86-39 changed the title Add roles selection optionAdd roles selection option for DiscordNov 16, 2022

@JRoyJRoy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both these features are fine, just a few things;

  • discord-roles-selection should be made into a blacklist rather than a whitelist, be renamed to discord-role-blacklist, and the config should have the examples commented out (like how world-aliases are in the main essentials config).

  • discord-roles-aliases should support both discord role names and ids and have their examples commented out as well.

@x86-39

Copy link
Copy Markdown
ContributorAuthor

I feel like it being a whitelist is still desired in many cases, perhaps an option to turn the whitelist into a blacklist? This is how DiscordSRV does it too.

Will add it to support IDs and comment it out in the config tomorrow

@JRoy

JRoy commented Nov 19, 2022

Copy link
Copy Markdown
Member

I feel like it being a whitelist is still desired in many cases, perhaps an option to turn the whitelist into a blacklist? This is how DiscordSRV does it too.

I think a majority of users will only have a couple of roles they don't want used as top role, such as a default role, rather than a bunch of unwanted top roles

@x86-39

Copy link
Copy Markdown
ContributorAuthor

Maybe a blacklist by default (renaming it to blacklist too) with an option for it to be a whitelist?

@JRoy

JRoy commented Nov 19, 2022

Copy link
Copy Markdown
Member

Maybe a blacklist by default (renaming it to blacklist too) with an option for it to be a whitelist?

I think that would become confusing, do you have an example of a common use case for a whitelist would be better over a blacklist?

@x86-39

Copy link
Copy Markdown
ContributorAuthor

We have staff ranks inside Minecraft which are roles present in Discord, but the Discord has more roles than that. When messages go to the Minecraft server, we only care about those staff roles going to Minecraft. Having a whitelist of just the few staff ranks is a lot easier then.

@x86-39

Copy link
Copy Markdown
ContributorAuthor

@JRoy Any input on this? If you agree with the whitelist suggestion I can implement it and finalise this PR

@JRoy

JRoy commented Dec 11, 2022

Copy link
Copy Markdown
Member

@JRoy Any input on this? If you agree with the whitelist suggestion I can implement it and finalise this PR

Sorry, though I had replied, still convinced that a blacklist would be more useful by default. You can add a boolean config option invert-discord-role-blacklist which is not in the config by default (and has false as its default value) in order to satisfy your usecase.

@x86-39

Copy link
Copy Markdown
ContributorAuthor

Yeah a blacklist by default is fine, I'll add a boolean thank you. Will modify the PR when I have the chance

@x86-39

Copy link
Copy Markdown
ContributorAuthor

Hey @JRoy, apologies I completely forgot about this pull request.

I just made the requested changes and updated the branch.

I also updated the other pull requests I have open:
#5159
#5158

@pop4959pop4959 added type: enhancement Features and feature requests. module: discord Issues or PRs for the EssentialsDiscord module labels May 5, 2023
JRoy
JRoy previously approved these changes Aug 9, 2023
@JRoyJRoy changed the title Add roles selection option for DiscordAdd discord roles blacklist and aliases for chat formatAug 9, 2023
@JRoy
JRoy enabled auto-merge (squash) August 9, 2023 01:34
JRoy
JRoy approved these changes Aug 9, 2023
@JRoy
JRoy merged commit e3e52db into EssentialsX:2.xAug 9, 2023
Starmism pushed a commit to valence-smp/Essentials that referenced this pull request Jan 8, 2025
…5157)
Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
rewsdjad1 pushed a commit to rewsdjad1/EssentialsXPlus that referenced this pull request Aug 13, 2026
…5157)
Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: discordIssues or PRs for the EssentialsDiscord moduletype: enhancementFeatures and feature requests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@x86-39@JRoy@pop4959