Skip to content

Don't run AntiBuild checks on NPCs - #5365

Merged
JRoy merged 2 commits into
EssentialsX:2.xfrom
JRoy:fix/npc-anti-build
May 27, 2023
Merged

Don't run AntiBuild checks on NPCs#5365
JRoy merged 2 commits into
EssentialsX:2.xfrom
JRoy:fix/npc-anti-build

Conversation

@JRoy

@JRoyJRoy commented May 27, 2023

Copy link
Copy Markdown
Member

Citizens pathfinding can trigger these events(!) and then cause LuckPerms to attempt an offline lookup which now raises an exception at runtime. DaFeels.

Fixes#5361

Citizens pathfinding can trigger these events(!) and then cause
LuckPerms to attempt an offline lookup which now raises an
exception at runtime. DaFeels.
@JRoyJRoy added type: bugfix PRs that fix bugs in EssentialsX. module: antibuild Issues or PRs for the EssentialsAntiBuild module labels May 27, 2023
@JRoyJRoy added this to the 2.20.1 milestone May 27, 2023

@pop4959pop4959 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More NPC checks never hurt I guess

@JRoy
JRoy merged commit a4fb02f into EssentialsX:2.xMay 27, 2023
@JRoy
JRoy deleted the fix/npc-anti-build branch May 27, 2023 01:54
rewsdjad1 pushed a commit to rewsdjad1/EssentialsXPlus that referenced this pull request Aug 13, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: antibuildIssues or PRs for the EssentialsAntiBuild moduletype: bugfixPRs that fix bugs in EssentialsX.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PlayerInteractEvent Error

2 participants

@JRoy@pop4959