') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Don't do visibility checks for OfflinePlayers by JRoy · Pull Request #5375 · EssentialsX/Essentials · GitHub
Skip to content

Don't do visibility checks for OfflinePlayers - #5375

Merged
JRoy merged 2 commits into
EssentialsX:2.xfrom
JRoy:fix/visability-checks-ame
Jul 1, 2023
Merged

Don't do visibility checks for OfflinePlayers#5375
JRoy merged 2 commits into
EssentialsX:2.xfrom
JRoy:fix/visability-checks-ame

Conversation

@JRoy

@JRoyJRoy commented Jun 1, 2023•
edited
Loading

Copy link
Copy Markdown
Member

This will throw an AbstractMethodError and doesn't make much sense to check anyway

Fixes#5374

@JRoy
Don't do visibility checks for OfflinePlayers
22d59fb
This will throw an AbstractMethodError and doesn't
make much sense to check anyway
@JRoyJRoy added the module: main Issues or PRs for the main Essentials module label Jun 1, 2023
@JRoyJRoy added this to the 2.20.1 milestone Jun 1, 2023
@JRoyJRoy added the type: bugfix PRs that fix bugs in EssentialsX. label Jun 1, 2023
@imDaniX

imDaniX commented Jun 4, 2023

Copy link
Copy Markdown
Contributor

Doesn't Player extend OfflinePlayer, so it will always return true now?

@mdcfe

mdcfe commented Jun 4, 2023

Copy link
Copy Markdown
Member

Doesn't Player extend OfflinePlayer, so it will always return true now?

The OfflinePlayer class here is the stub inside EssentialsX, not the Bukkit OfflinePlayer

@JRoy
JRoy merged commit a1fa1e3 into EssentialsX:2.xJul 1, 2023
@JRoy
JRoy deleted the fix/visability-checks-ame branch July 1, 2023 20:41
rewsdjad1 pushed a commit to rewsdjad1/EssentialsXPlus that referenced this pull request Aug 13, 2026
@JRoy@mdcfe
Don't do visibility checks for OfflinePlayers (EssentialsX#5375)
d1a3e63
Co-authored-by: MD <1917406+mdcfe@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdcfemdcfemdcfe approved these changes
+1 more reviewer
@YanisBftYanisBftYanisBft approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

module: mainIssues or PRs for the main Essentials moduletype: bugfixPRs that fix bugs in EssentialsX.

Projects

None yet

Milestone

2.20.1

Development

Successfully merging this pull request may close these issues.

Exception when responding to an offline player via /reply

4 participants

@JRoy@imDaniX@mdcfe@YanisBft