Skip to content

Update to Minecraft 1.20.6 - #5783

Merged
JRoy merged 10 commits into
2.xfrom
mc/1.20.5
May 27, 2024
Merged

Update to Minecraft 1.20.6#5783
JRoy merged 10 commits into
2.xfrom
mc/1.20.5

Conversation

@JRoy

@JRoyJRoy commented Apr 30, 2024

Copy link
Copy Markdown
Member

this compiles and probably works but there is some things still left to do

  • test banner itemdb
  • fix potion itemdb (see todos)
  • update item aliases

@JRoyJRoy added the type: enhancement Features and feature requests. label Apr 30, 2024
@JRoyJRoy added this to the 2.21.0 milestone Apr 30, 2024
@JRoy
JRoy marked this pull request as ready for review May 8, 2024 22:35
CyberFlameGO

This comment was marked as spam.

luftwafflezz

This comment was marked as spam.

JRoyand others added 3 commits May 13, 2024 16:18
@JRoy
JRoyforce-pushed the mc/1.20.5 branch 2 times, most recently from 72d095e to bb9c63cCompareMay 13, 2024 20:57

@ImDarkLawImDarkLaw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, changes look good. I noticed, however, that the following exception is still being printed in console when using /give. Perhaps that'd be something to address (or wait for Paper to resolve) before merging?

[00:27:06 ERROR]: [org.bukkit.craftbukkit.util.CraftMagicNumbers] null
com.mojang.brigadier.exceptions.CommandSyntaxException: Unknown item 'minecraft:' at position 0: <--[HERE]

@luftwafflezz

luftwafflezz commented May 15, 2024

Copy link
Copy Markdown
Contributor
com.mojang.brigadier.exceptions.CommandSyntaxException: Unknown item 'minecraft:' at position 0: <--[HERE]

Correct me if im wrong, but im pretty sure that the minecraft: prefix for an item is only supported in the vanilla /give command. For example, /give @s minecraft:torch 1 would work in vanilla, but with essentials it would be /give torch 1.

@JRoy

JRoy commented May 15, 2024

Copy link
Copy Markdown
MemberAuthor
com.mojang.brigadier.exceptions.CommandSyntaxException: Unknown item 'minecraft:' at position 0: <--[HERE]

Correct me if im wrong, but im pretty sure that the minecraft: prefix for an item is only supported in the vanilla /give command. For example, /give @s minecraft:torch 1 would work in vanilla, but with essentials it would be /give torch 1.

the exception is unrelated to this and it is a (harmless) bukkit bug, nothing essentials can quite control.

@LOOHP

LOOHP commented May 19, 2024

Copy link
Copy Markdown
com.mojang.brigadier.exceptions.CommandSyntaxException: Unknown item 'minecraft:' at position 0: <--[HERE]

Correct me if im wrong, but im pretty sure that the minecraft: prefix for an item is only supported in the vanilla /give command. For example, /give @s minecraft:torch 1 would work in vanilla, but with essentials it would be /give torch 1.

the exception is unrelated to this and it is a (harmless) bukkit bug, nothing essentials can quite control.

I've encountered this with my plugin when I used Bukkit.getUnsafe().modifyItemStack. Apparently, we have to include the item type in the arguments to avoid this error in 1.20.6.

For example, this prints the CommandSyntaxException error:

Bukkit.getUnsafe().modifyItemStack(head, "[minecraft:profile={properties:[{name:\"textures\",value:\"" + base64 + "\"}]}]");

This does not:

Bukkit.getUnsafe().modifyItemStack(head, "minecraft:player_head[minecraft:profile={properties:[{name:\"textures\",value:\"" + base64 + "\"}]}]");

Previously, in 1.20.4, we did not need to include the item type:

Bukkit.getUnsafe().modifyItemStack(head, "{SkullOwner: {Properties: {textures: [{Value: \"" + base64 + "\"}]}}}");

Most likely this is already known by Essentials devs but I thought I'd leave it here if anyone else is looking up this problem.

@Budderman18

Copy link
Copy Markdown

im noticing some potions in kits do not work (all types instant damage pots, there might be more). They show up as "null" when trying to create it

@ImDarkLaw

Copy link
Copy Markdown
Contributor

im noticing some potions in kits do not work (all types instant damage pots, there might be more). They show up as "null" when trying to create it

The issue with potions in kits, including instant damage potions (potion of harming), has been addressed in the latest commits to the mc/1.20.5 branch. Ensure you have pulled the latest changes from this branch and rebuilt the plugin. This should resolve potions showing up as null.

@Budderman18

Copy link
Copy Markdown

im noticing some potions in kits do not work (all types instant damage pots, there might be more). They show up as "null" when trying to create it

The issue with potions in kits, including instant damage potions (potion of harming), has been addressed in the latest commits to the mc/1.20.5 branch. Ensure you have pulled the latest changes from this branch and rebuilt the plugin. This should resolve potions showing up as null.

i am on the latest version of that branch and it still occurs.

Server version: 1.20.6-R0.1-SNAPSHOT 1.20.6-89-d3ffa62 (MC: 1.20.6)
Brand version: Paper
EssentialsX version: 2.21.0-dev+91-6bbc4a6

@JRoy

JRoy commented May 23, 2024

Copy link
Copy Markdown
MemberAuthor

im noticing some potions in kits do not work (all types instant damage pots, there might be more). They show up as "null" when trying to create it

The issue with potions in kits, including instant damage potions (potion of harming), has been addressed in the latest commits to the mc/1.20.5 branch. Ensure you have pulled the latest changes from this branch and rebuilt the plugin. This should resolve potions showing up as null.

i am on the latest version of that branch and it still occurs.

Server version: 1.20.6-R0.1-SNAPSHOT 1.20.6-89-d3ffa62 (MC: 1.20.6)
Brand version: Paper
EssentialsX version: 2.21.0-dev+91-6bbc4a6

when the server is stopped, delete the items.json file in the plugins/Essentials folder. When you start it, the issue should be resolved.

This will happen automatically once merged

Comment threadEssentials/src/main/java/com/earth2me/essentials/MetaItemStack.java Outdated
Comment threadEssentials/src/main/resources/messages.properties Outdated
JRoy added 7 commits May 27, 2024 15:26
There has been a method for this since 1.13.
Why have we been using this for so long?
Since item NBT is now dead, this method for checking
if an item is spawn-able is defunct and produces a console
error every time the give command is ran.
@JRoy
JRoy requested a review from mdcfeMay 27, 2024 19:28
@JRoy
JRoy merged commit e7a4167 into 2.xMay 27, 2024
@JRoy
JRoy deleted the mc/1.20.5 branch May 27, 2024 19:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancementFeatures and feature requests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@JRoy@luftwafflezz@LOOHP@Budderman18@ImDarkLaw@mdcfe@CyberFlameGO@jpenilla