Skip to content

Fix startup issue with potion providers - #6055

Merged
JRoy merged 1 commit into
EssentialsX:2.xfrom
JRoy:fix/6054
Feb 19, 2025
Merged

Fix startup issue with potion providers#6055
JRoy merged 1 commit into
EssentialsX:2.xfrom
JRoy:fix/6054

Conversation

@JRoy

@JRoyJRoy commented Feb 19, 2025

Copy link
Copy Markdown
Member

The LegacyPotionMetaProvider was initializing a map with enums that don't exist on modern versions. Since this was a static variable, this map got initialized when the test method was called, leading to a NoSuchFieldError.

Also improved resilience of these provider-type issues again by catching a Throwable rather than an Exception in the ProviderFactory.

Fixes#6054

The LegacyPotionMetaProvider was initializing a map with enums that don't exist on modern versions. Since this was a static variable, this map got initialized when the test method was called, leading to a NoSuchFieldError.
Also improved resilience of these provider-type issues again by catching a Throwable rather than an Exception in the ProviderFactory.
@JRoyJRoy added type: bugfix PRs that fix bugs in EssentialsX. module: main Issues or PRs for the main Essentials module labels Feb 19, 2025
@JRoyJRoy added this to the 2.21.0 milestone Feb 19, 2025
@JRoy
JRoy merged commit 196a2a1 into EssentialsX:2.xFeb 19, 2025
@JRoy
JRoy deleted the fix/6054 branch February 19, 2025 20:58
Euphillya added a commit to Euphillya/Essentials-Folia that referenced this pull request Mar 1, 2025
EssentialsX@196a2a1 Fix startup issue with potion providers (EssentialsX#6055)
EssentialsX@8313d52 Add config for use of Paper chat events (EssentialsX#6050)
EssentialsX@3025ba5 Fix NPE when chat messages are canceled
EssentialsX@5a839c4 Fix modifying messages with Paper chat events
EssentialsX@e3e247d Add discord module support for Paper's chat events (EssentialsX#5908)
EssentialsX@263dab5 Fix spawn command sending message before teleportation (EssentialsX#6025)
EssentialsX@f5efa26 Fix per-world flight permissions
EssentialsX@1ff24cb Use an identity map for Paper chat listener (EssentialsX#6067)
EssentialsX@bad79b7 Fix /book command on 1.20+ (EssentialsX#6064)
EssentialsX@5458241 Fix expired mails showing as unread on join (EssentialsX#6063)
EssentialsX@fe27182 New Crowdin updates (EssentialsX#6037)
EssentialsX@ba5257c Fix translation error in EssentialsSign#getItemStack
EssentialsX@e49021f Fix item overflow issue with kits & trade signs
EssentialsX@b5748eb Update various dependencies (EssentialsX#6078)
rewsdjad1 pushed a commit to rewsdjad1/EssentialsXPlus that referenced this pull request Aug 13, 2026
The LegacyPotionMetaProvider was initializing a map with enums that
don't exist on modern versions. Since this was a static variable, this
map got initialized when the test method was called, leading to a
NoSuchFieldError.
Also improved resilience of these provider-type issues again by catching
a Throwable rather than an Exception in the ProviderFactory.
FixesEssentialsX#6054
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: mainIssues or PRs for the main Essentials moduletype: bugfixPRs that fix bugs in EssentialsX.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1.21.4: NoSuchFieldError: Class PotionType does not have member field X

2 participants

@JRoy@pop4959