Skip to content

Discord: Fix custom bot name requiring show-avatar - #6239

Merged
JRoy merged 1 commit into
EssentialsX:2.xfrom
JRoy:fix/5878
Jul 28, 2025
Merged

Discord: Fix custom bot name requiring show-avatar#6239
JRoy merged 1 commit into
EssentialsX:2.xfrom
JRoy:fix/5878

Conversation

@JRoy

@JRoyJRoy commented Jul 27, 2025

Copy link
Copy Markdown
Member

Fixes#5878. Caused by a regression from 384f63b, we were checking for for the legacy options when we should really be checking if mc-to-discord-name-format is anything other than the bot name.

@JRoyJRoy added this to the 2.21.2 milestone Jul 27, 2025
@JRoyJRoy added type: bugfix PRs that fix bugs in EssentialsX. module: discord Issues or PRs for the EssentialsDiscord module labels Jul 27, 2025
@JRoy
JRoy enabled auto-merge July 27, 2025 23:25
@JRoy
JRoy added this pull request to the merge queueJul 28, 2025
Merged via the queue into EssentialsX:2.x with commit f4cd1c9Jul 28, 2025
1 check passed
@JRoy
JRoy deleted the fix/5878 branch July 28, 2025 05:40
Euphillya added a commit to Euphillya/Essentials-Folia that referenced this pull request Jul 29, 2025
EssentialsX@9ef4fc3 Update to Minecraft 1.21.8 (EssentialsX#6224)
EssentialsX@0417624 Fix local chat spy formatting (EssentialsX#6226)
EssentialsX@ff7c952 Fix per-player locale for messages with arguments (EssentialsX#6227)
EssentialsX@d002c34 Add version data extraction (EssentialsX#6235)
EssentialsX@f4cd1c9 Discord: Fix custom bot name requiring show-avatar (EssentialsX#6239)
rewsdjad1 pushed a commit to rewsdjad1/EssentialsXPlus that referenced this pull request Aug 13, 2026
FixesEssentialsX#5878. Caused by a regression from
433a446, we were checking for for the
legacy options when we should really be checking if
`mc-to-discord-name-format` is anything other than the bot name.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: discordIssues or PRs for the EssentialsDiscord moduletype: bugfixPRs that fix bugs in EssentialsX.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

avatar: true is required for mc-to-discord-name-format to take any effect

2 participants

@JRoy@mdcfe