Skip to content

Fix updating join message when not needed - #6312

Merged
JRoy merged 2 commits into
EssentialsX:2.xfrom
JRoy:bug/6307
Oct 3, 2025
Merged

Fix updating join message when not needed#6312
JRoy merged 2 commits into
EssentialsX:2.xfrom
JRoy:bug/6307

Conversation

@JRoy

@JRoyJRoy commented Oct 3, 2025

Copy link
Copy Markdown
Member

Prevents calling setJoinMessage when the message is unchanged causing Bukkit to no longer send the translation key to the client (nuking vanilla translation)

Fixes#6307

Prevents calling setJoinMessage when the message is unchanged causing Bukkit to no longer send the translation key to the client (nuking vanilla translation)
@JRoyJRoy added type: bugfix PRs that fix bugs in EssentialsX. module: main Issues or PRs for the main Essentials module labels Oct 3, 2025
@JRoyJRoy added this to the 2.22.0 milestone Oct 3, 2025
@JRoy
JRoy enabled auto-merge October 3, 2025 11:12
@JRoy
JRoy added this pull request to the merge queueOct 3, 2025
Merged via the queue into EssentialsX:2.x with commit 8982aaeOct 3, 2025
1 check passed
@JRoy
JRoy deleted the bug/6307 branch October 3, 2025 11:21
Euphillya added a commit to Euphillya/Essentials-Folia that referenced this pull request Oct 6, 2025
EssentialsX@ca7f3b5 Add option to limit baltop entries (EssentialsX#6300)
EssentialsX@893bae0 Change baltop entry limit wording (EssentialsX#6306)
EssentialsX@65120e9 Update to Minecraft 1.21.9 (EssentialsX#6299)
EssentialsX@22b4975 Fixes stale cached locations after using /settpr (EssentialsX#6305)
EssentialsX@8982aae Fix updating join message when not needed (EssentialsX#6312)
EssentialsX@4dabeb5 Fix GeoIP dependencies (EssentialsX#6314)
EssentialsX@264b0ed Improve memory resilience with Configurate (EssentialsX#6266)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: mainIssues or PRs for the main Essentials moduletype: bugfixPRs that fix bugs in EssentialsX.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Essentials does not translate join/quit messages

2 participants

@JRoy@mdcfe