Skip to content

fix: reset nickname when player changes Minecraft account name - #6470

Merged
JRoy merged 11 commits into
EssentialsX:2.xfrom
hudsonandres:nickname
May 3, 2026
Merged

fix: reset nickname when player changes Minecraft account name#6470
JRoy merged 11 commits into
EssentialsX:2.xfrom
hudsonandres:nickname

Conversation

@hudsonandres

@hudsonandreshudsonandres commented Mar 18, 2026•
edited by JRoy
Loading

Copy link
Copy Markdown
Contributor

Closes#6469

@hudsonandres
fix: reset nickname when player changes Minecraft account name
0fd004b
- When a premium player changes their Minecraft username, any previously
set nickname (including RGB-formatted ones) is now automatically cleared
on their next login, equivalent to running /nick off.
@hudsonandres

hudsonandres commented Mar 18, 2026

Copy link
Copy Markdown
ContributorAuthor

How it works:

Every time a player joins, the code already compares lastAccountName (the name stored from their last login) with the current Minecraft account name.

If they differ, meaning the player changed their Minecraft username - and the player has a nickname set, setNickname(null) is called to remove it (equivalent to /nick off).

The subsequent user.setDisplayNick() call then updates their display name to the bare new account name.
This way, RGB-colored or any other nicknames tied to the old account name are automatically cleared when the player first joins after a name change.

@jquery-package

jquery-package commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

I think this behavior needs to be configurable

JRoy
JRoy requested changes Apr 4, 2026
View reviewed changes

@JRoyJRoy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a configuration option for this defaulting off.

@hudsonandres
add: make reset-nick-on-name-change disabled by default
f6590e6
The nickname reset functionality is now disabled by default (false).
Administrators can enable it by setting 'reset-nick-on-name-change: true' in config.yml.
@hudsonandres
hudsonandres requested a review from JRoyApril 20, 2026 00:31
@hudsonandres

hudsonandres commented Apr 20, 2026

Copy link
Copy Markdown
ContributorAuthor

please add a configuration option for this defaulting off.

The requested option has been added.

SrBedrock
SrBedrock reviewed Apr 20, 2026
View reviewed changes
Comment threadEssentials/src/main/java/com/earth2me/essentials/EssentialsPlayerListener.java Outdated
JRoy
JRoy reviewed May 3, 2026
View reviewed changes
Comment threadEssentials/src/main/java/com/earth2me/essentials/Settings.java Outdated
JRoy
JRoy reviewed May 3, 2026
View reviewed changes
Comment threadEssentials/src/main/java/com/earth2me/essentials/EssentialsPlayerListener.java
JRoy
JRoy reviewed May 3, 2026
View reviewed changes
Comment threadEssentials/src/main/java/com/earth2me/essentials/EssentialsPlayerListener.java Outdated
JRoy
JRoy reviewed May 3, 2026
View reviewed changes
Comment threadEssentials/src/main/java/com/earth2me/essentials/EssentialsPlayerListener.java Outdated
JRoy
JRoy previously approved these changes May 3, 2026
View reviewed changes

@JRoyJRoy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :)

JRoy
JRoy reviewed May 3, 2026
View reviewed changes
Comment threadEssentials/src/main/java/com/earth2me/essentials/IEssentials.java Outdated
@JRoy
JRoy enabled auto-merge May 3, 2026 05:42
JRoy
JRoy approved these changes May 3, 2026
View reviewed changes
@JRoy
JRoy added this pull request to the merge queueMay 3, 2026
Merged via the queue into EssentialsX:2.x with commit 24b7285May 3, 2026
1 check passed
Euphillya added a commit to Euphillya/Essentials-Folia that referenced this pull request May 6, 2026
@Euphillya
Update Upstream Essentials :
54f21b0
EssentialsX@5c45ee2 Add /jailedplayers command to list jailed players (EssentialsX#6517)
EssentialsX@24b7285 fix: reset nickname when player changes Minecraft account name (EssentialsX#6470)
fix: reset nickname when player changes Minecraft account name (EssentialsX#6470) Add lunge to /enchant (EssentialsX#6534)
EssentialsX@39bc0fe Send geoip join messages to console (EssentialsX#6523)
EssentialsX@5db483b Fix Discord Link RoleSyncManager thread leak (EssentialsX#6512)
EssentialsX@79d67e9 Fix essentials.home.bed permission being ignored (EssentialsX#6516)
EssentialsX@c38c925 Fix deposits rejected when account has negative balance (EssentialsX#6515)
@mdcfemdcfe added this to the 2.22.0 milestone May 23, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JRoyJRoyJRoy approved these changes
+1 more reviewer
@SrBedrockSrBedrockSrBedrock left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.22.0

Development

Successfully merging this pull request may close these issues.

The nickname does not change or reset if the original account name is changed.

5 participants

@hudsonandres@jquery-package@JRoy@SrBedrock@mdcfe