Skip to content

chore: update maps to latest version of ethereal engine - #12

Draft
aditya-mitra wants to merge 13 commits into
mainfrom
update-maps
Draft

chore: update maps to latest version of ethereal engine#12
aditya-mitra wants to merge 13 commits into
mainfrom
update-maps

Conversation

@aditya-mitra

@aditya-mitraaditya-mitra commented Jun 3, 2023

Copy link
Copy Markdown

closes#6

HexaField
HexaField suggested changes Jun 3, 2023
View reviewed changes
Comment threadeditor/MapNodeEditor.tsx Outdated
Comment threadengine/MapFunctions.ts Outdated
Comment threadengine/MapFunctions.ts Outdated
Comment threadengine/MapFunctions.ts Outdated
Comment threadengine/MapReceptor.ts Outdated
return s.merge({
center: action.centerPoint,
switch(action.type) {
case 'map.INITIALIZE': return state.merge({

@HexaFieldHexaFieldJun 3, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be refactored to use the defineActionQueue API

Comment threadengine/MapUpdateSystem.ts Outdated
const $previousMapCenterPoint: LongLat = Array(2)

export default async function MapUpdateSystem(world: World): Promise<System> {
export default async function MapUpdateSystem(): Promise<any> {

@HexaFieldHexaFieldJun 3, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

systems now use defineSystem which takes execute as an argument. any async logic should be done in a reactor on the system defintion

Comment threadengine/phases/CreateGeometryPhase.ts Outdated
Comment threadengine/phases/TransformFeaturePhase.ts Outdated
Comment threadworldInjection.ts Outdated
HexaField
HexaField reviewed Jun 3, 2023
View reviewed changes
Comment threadeditor/MapNodeEditor.tsx Outdated
HexaField
HexaField suggested changes Jun 20, 2023
View reviewed changes
Comment threadengine/MapUpdateSystem.ts Outdated
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@HexaFieldHexaFieldHexaField requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

verified-contributor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Maps - Update the current system for latest version of Ethereal Engine

3 participants

@aditya-mitra@HexaField@Legend101Zz