Skip to content

Improvements from review - #22

Merged
nedtaylor merged 38 commits into
mainfrom
improvements_from_review
Oct 23, 2024
Merged

Improvements from review#22
nedtaylor merged 38 commits into
mainfrom
improvements_from_review

Conversation

@nedtaylor

@nedtaylornedtaylor commented Oct 23, 2024

Copy link
Copy Markdown
Collaborator

Implement recommended changes from Steve Hepplestone's code review.

Main changes to implement:

  • mod_generator
  • improve comments
  • mod_evaluator
  • improve commenting
  • Separate 2-body viability evaluation into its own procedure
  • Look into whether 2-body list generation can be separated into own procedure (won't do for now, would slow down code massively)
  • mod_evolver
  • rename module
  • split module into three modules (base, host, and container)
  • mod_edit_geom
  • split into two modules, basis_merge and get_distance procedures
  • mod_elements
  • rename module
  • improve comments
  • mod_error_handling
  • rename module
  • improve comments
  • mod_atom_adder
  • rename module
  • split into two modules, placement procedures and viability procedures
  • improve comments
  • general
  • rename gvectors to distribs
  • replace suitability references with viability
  • convert from real12 to real32

@nedtaylornedtaylor added the documentation Improvements or additions to documentation label Oct 23, 2024
@nedtaylornedtaylor added this to the Version 1 milestone Oct 23, 2024
@nedtaylornedtaylor self-assigned this Oct 23, 2024
@nedtaylor
nedtaylor merged commit 415066a into mainOct 23, 2024
@nedtaylor
nedtaylor deleted the improvements_from_review branch October 23, 2024 16:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@nedtaylor