Skip to content

fix(core): resolve kebab env vars as snake case - #62

Open
AlexProgrammerDE wants to merge 2 commits into
Exlll:devfrom
6b6t:master
Open

fix(core): resolve kebab env vars as snake case#62
AlexProgrammerDE wants to merge 2 commits into
Exlll:devfrom
6b6t:master

Conversation

@AlexProgrammerDE

@AlexProgrammerDEAlexProgrammerDE commented May 19, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Normalize generated environment variable names by replacing dashes with underscores before lookup.
  • Add a regression test for lower-kebab configuration keys resolving from snake_case environment variables.

Why

Lower-kebab formatted config keys such as encryption-key previously generated environment variable names like ENCRYPTION-KEY, which cannot be used as normal environment variables on many systems. This keeps kebab-case config files while allowing ENCRYPTION_KEY style overrides.

Validation

  • JAVA_HOME=/tmp/codex-jdk21 PATH=/tmp/codex-jdk21/bin:$PATH ./gradlew :configlib-core:check

Disclosure

This PR was made with Codex GPT-5.5 medium fast.
And yes this is a real bug I have in my production plugins.

@AlexProgrammerDE
AlexProgrammerDE marked this pull request as ready for review May 19, 2026 15:33
CopilotAI review requested due to automatic review settings May 19, 2026 15:33
CopilotAI reviewed May 19, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR improves environment-variable preprocessing to support kebab-case config keys being overridden by snake_case environment variable names (e.g., encryption-key → ENCRYPTION_KEY).

Changes:

  • Refactors env-var name construction into a helper method in RootSerializer.
  • Normalizes generated env-var names by replacing - with _.
  • Adds a regression test covering LOWER_KEBAB_CASE config names with snake_case environment variables.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

FileDescription
configlib-core/src/main/java/de/exlll/configlib/RootSerializer.javaCentralizes env-var name creation and adds -→_ normalization for kebab-case paths.
configlib-core/src/test/java/de/exlll/configlib/RootSerializerTest.javaAdds a test and supporting records to validate kebab-case key overrides via snake_case env vars.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadconfiglib-core/src/test/java/de/exlll/configlib/RootSerializerTest.java Outdated
Comment threadconfiglib-core/src/main/java/de/exlll/configlib/RootSerializer.java
Comment on lines +101 to +109
private String createEnvironmentVariable(String prefix, String pathSegment) {
String envVar = prefix.isEmpty()
? pathSegment
: prefix + '_' + pathSegment;
envVar = envVar.replace('-', '_');
return envVarConfig.caseSensitive()
? envVar
: envVar.toUpperCase(Locale.ROOT);
}
@AlexProgrammerDE
Potential fix for pull request finding
ea35ab2
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@Exlll

Exlll commented May 22, 2026

Copy link
Copy Markdown
Owner

Hey, thanks for the contribution. Windows allows hyphen in env vars, e.g. MY-VAR. Simply replacing hyphens with underscore is a breaking change. Do you see a solution for this?

@AlexProgrammerDE

AlexProgrammerDE commented May 22, 2026

Copy link
Copy Markdown
ContributorAuthor

I think either allow specifying custom environments or allow specifying an env substitutor preprocessor for all names passed to it. I think opening up environments is smarter. Would also allow other environments like java system properties for example.

@Exlll

Exlll commented May 25, 2026

Copy link
Copy Markdown
Owner

So we should make the Environment interface public and allow using custom implementations of it by introducing a new setter in the ConfigurationProperties class, right?

@AlexProgrammerDE

AlexProgrammerDE commented May 25, 2026

Copy link
Copy Markdown
ContributorAuthor

Yeah I would find that preferable. Do you want me to change the PR?

@Exlll

Exlll commented May 25, 2026

Copy link
Copy Markdown
Owner

Sure, if you could do that and also add the necessary tests (that ideally also cover the bug that you encountered), that would be great!

@Exlll

Exlll commented May 25, 2026

Copy link
Copy Markdown
Owner

Also, before you start, you might want to rebase first because just merged an open PR into dev.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AlexProgrammerDE@Exlll
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(core): resolve kebab env vars as snake case by AlexProgrammerDE · Pull Request #62 · Exlll/ConfigLib · GitHub
Skip to content
fix(core): resolve kebab env vars as snake case - #62
Open
AlexProgrammerDE wants to merge 2 commits into
Exlll:devfrom 
6b6t:master
Open
fix(core): resolve kebab env vars as snake case#62
AlexProgrammerDE wants to merge 2 commits into
Exlll:devfrom 
6b6t:master
Conversation
@AlexProgrammerDE
@AlexProgrammerDEAlexProgrammerDE
commented
May 19, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
  • Normalize generated environment variable names by replacing dashes with underscores before lookup.
  • Add a regression test for lower-kebab configuration keys resolving from snake_case environment variables.
Why
Lower-kebab formatted config keys such as encryption-key previously generated environment variable names like ENCRYPTION-KEY, which cannot be used as normal environment variables on many systems. This keeps kebab-case config files while allowing ENCRYPTION_KEY style overrides.
Validation
  • JAVA_HOME=/tmp/codex-jdk21 PATH=/tmp/codex-jdk21/bin:$PATH ./gradlew :configlib-core:check
Disclosure
This PR was made with Codex GPT-5.5 medium fast.

And yes this is a real bug I have in my production plugins.
@AlexProgrammerDE
AlexProgrammerDE
marked this pull request as ready for review
May 19, 2026 15:33
CopilotAI
review requested due to automatic review settings
May 19, 2026 15:33
CopilotAI
reviewed
May 19, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR improves environment-variable preprocessing to support kebab-case config keys being overridden by snake_case environment variable names (e.g., encryption-key → ENCRYPTION_KEY).
Changes:
  • Refactors env-var name construction into a helper method in RootSerializer.
  • Normalizes generated env-var names by replacing - with _.
  • Adds a regression test covering LOWER_KEBAB_CASE config names with snake_case environment variables.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
FileDescription
configlib-core/src/main/java/de/exlll/configlib/RootSerializer.javaCentralizes env-var name creation and adds -→_ normalization for kebab-case paths.
configlib-core/src/test/java/de/exlll/configlib/RootSerializerTest.javaAdds a test and supporting records to validate kebab-case key overrides via snake_case env vars.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment threadconfiglib-core/src/test/java/de/exlll/configlib/RootSerializerTest.java
Outdated

Comment threadconfiglib-core/src/main/java/de/exlll/configlib/RootSerializer.java

Comment on lines

+101
 to 
+109

 private String createEnvironmentVariable(String prefix, String pathSegment) {
 String envVar = prefix.isEmpty()
 ? pathSegment
 : prefix + '_' + pathSegment;
 envVar = envVar.replace('-', '_');
 return envVarConfig.caseSensitive()
 ? envVar
 : envVar.toUpperCase(Locale.ROOT);
 }
@AlexProgrammerDE
Potential fix for pull request finding
ea35ab2
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@Exlll
Exlll
commented
May 22, 2026

Copy link


Copy Markdown

Owner
Hey, thanks for the contribution. Windows allows hyphen in env vars, e.g. MY-VAR. Simply replacing hyphens with underscore is a breaking change. Do you see a solution for this?
@AlexProgrammerDE
AlexProgrammerDE
commented
May 22, 2026

Copy link


Copy Markdown

ContributorAuthor
I think either allow specifying custom environments or allow specifying an env substitutor preprocessor for all names passed to it. I think opening up environments is smarter. Would also allow other environments like java system properties for example.
@Exlll
Exlll
commented
May 25, 2026

Copy link


Copy Markdown

Owner
So we should make the Environment interface public and allow using custom implementations of it by introducing a new setter in the ConfigurationProperties class, right?
@AlexProgrammerDE
AlexProgrammerDE
commented
May 25, 2026

Copy link


Copy Markdown

ContributorAuthor
Yeah I would find that preferable. Do you want me to change the PR?
@Exlll
Exlll
commented
May 25, 2026

Copy link


Copy Markdown

Owner
Sure, if you could do that and also add the necessary tests (that ideally also cover the bug that you encountered), that would be great!
@Exlll
Exlll
commented
May 25, 2026

Copy link


Copy Markdown

Owner
Also, before you start, you might want to rebase first because just merged an open PR into dev.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@AlexProgrammerDE@Exlll

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(core): resolve kebab env vars as snake case by AlexProgrammerDE · Pull Request #62 · Exlll/ConfigLib · GitHub
Skip to content
fix(core): resolve kebab env vars as snake case - #62
Open
AlexProgrammerDE wants to merge 2 commits into
Exlll:devfrom 
6b6t:master
Open
fix(core): resolve kebab env vars as snake case#62
AlexProgrammerDE wants to merge 2 commits into
Exlll:devfrom 
6b6t:master
Conversation
@AlexProgrammerDE
@AlexProgrammerDEAlexProgrammerDE
commented
May 19, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
  • Normalize generated environment variable names by replacing dashes with underscores before lookup.
  • Add a regression test for lower-kebab configuration keys resolving from snake_case environment variables.
Why
Lower-kebab formatted config keys such as encryption-key previously generated environment variable names like ENCRYPTION-KEY, which cannot be used as normal environment variables on many systems. This keeps kebab-case config files while allowing ENCRYPTION_KEY style overrides.
Validation
  • JAVA_HOME=/tmp/codex-jdk21 PATH=/tmp/codex-jdk21/bin:$PATH ./gradlew :configlib-core:check
Disclosure
This PR was made with Codex GPT-5.5 medium fast.

And yes this is a real bug I have in my production plugins.
@AlexProgrammerDE
AlexProgrammerDE
marked this pull request as ready for review
May 19, 2026 15:33
CopilotAI
review requested due to automatic review settings
May 19, 2026 15:33
CopilotAI
reviewed
May 19, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR improves environment-variable preprocessing to support kebab-case config keys being overridden by snake_case environment variable names (e.g., encryption-key → ENCRYPTION_KEY).
Changes:
  • Refactors env-var name construction into a helper method in RootSerializer.
  • Normalizes generated env-var names by replacing - with _.
  • Adds a regression test covering LOWER_KEBAB_CASE config names with snake_case environment variables.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
FileDescription
configlib-core/src/main/java/de/exlll/configlib/RootSerializer.javaCentralizes env-var name creation and adds -→_ normalization for kebab-case paths.
configlib-core/src/test/java/de/exlll/configlib/RootSerializerTest.javaAdds a test and supporting records to validate kebab-case key overrides via snake_case env vars.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment threadconfiglib-core/src/test/java/de/exlll/configlib/RootSerializerTest.java
Outdated

Comment threadconfiglib-core/src/main/java/de/exlll/configlib/RootSerializer.java

Comment on lines

+101
 to 
+109

 private String createEnvironmentVariable(String prefix, String pathSegment) {
 String envVar = prefix.isEmpty()
 ? pathSegment
 : prefix + '_' + pathSegment;
 envVar = envVar.replace('-', '_');
 return envVarConfig.caseSensitive()
 ? envVar
 : envVar.toUpperCase(Locale.ROOT);
 }
@AlexProgrammerDE
Potential fix for pull request finding
ea35ab2
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@Exlll
Exlll
commented
May 22, 2026

Copy link


Copy Markdown

Owner
Hey, thanks for the contribution. Windows allows hyphen in env vars, e.g. MY-VAR. Simply replacing hyphens with underscore is a breaking change. Do you see a solution for this?
@AlexProgrammerDE
AlexProgrammerDE
commented
May 22, 2026

Copy link


Copy Markdown

ContributorAuthor
I think either allow specifying custom environments or allow specifying an env substitutor preprocessor for all names passed to it. I think opening up environments is smarter. Would also allow other environments like java system properties for example.
@Exlll
Exlll
commented
May 25, 2026

Copy link


Copy Markdown

Owner
So we should make the Environment interface public and allow using custom implementations of it by introducing a new setter in the ConfigurationProperties class, right?
@AlexProgrammerDE
AlexProgrammerDE
commented
May 25, 2026

Copy link


Copy Markdown

ContributorAuthor
Yeah I would find that preferable. Do you want me to change the PR?
@Exlll
Exlll
commented
May 25, 2026

Copy link


Copy Markdown

Owner
Sure, if you could do that and also add the necessary tests (that ideally also cover the bug that you encountered), that would be great!
@Exlll
Exlll
commented
May 25, 2026

Copy link


Copy Markdown

Owner
Also, before you start, you might want to rebase first because just merged an open PR into dev.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@AlexProgrammerDE@Exlll

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(core): resolve kebab env vars as snake case by AlexProgrammerDE · Pull Request #62 · Exlll/ConfigLib · GitHub
Skip to content
fix(core): resolve kebab env vars as snake case - #62
Open
AlexProgrammerDE wants to merge 2 commits into
Exlll:devfrom 
6b6t:master
Open
fix(core): resolve kebab env vars as snake case#62
AlexProgrammerDE wants to merge 2 commits into
Exlll:devfrom 
6b6t:master
Conversation
@AlexProgrammerDE
@AlexProgrammerDEAlexProgrammerDE
commented
May 19, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
  • Normalize generated environment variable names by replacing dashes with underscores before lookup.
  • Add a regression test for lower-kebab configuration keys resolving from snake_case environment variables.
Why
Lower-kebab formatted config keys such as encryption-key previously generated environment variable names like ENCRYPTION-KEY, which cannot be used as normal environment variables on many systems. This keeps kebab-case config files while allowing ENCRYPTION_KEY style overrides.
Validation
  • JAVA_HOME=/tmp/codex-jdk21 PATH=/tmp/codex-jdk21/bin:$PATH ./gradlew :configlib-core:check
Disclosure
This PR was made with Codex GPT-5.5 medium fast.

And yes this is a real bug I have in my production plugins.
@AlexProgrammerDE
AlexProgrammerDE
marked this pull request as ready for review
May 19, 2026 15:33
CopilotAI
review requested due to automatic review settings
May 19, 2026 15:33
CopilotAI
reviewed
May 19, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR improves environment-variable preprocessing to support kebab-case config keys being overridden by snake_case environment variable names (e.g., encryption-key → ENCRYPTION_KEY).
Changes:
  • Refactors env-var name construction into a helper method in RootSerializer.
  • Normalizes generated env-var names by replacing - with _.
  • Adds a regression test covering LOWER_KEBAB_CASE config names with snake_case environment variables.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
FileDescription
configlib-core/src/main/java/de/exlll/configlib/RootSerializer.javaCentralizes env-var name creation and adds -→_ normalization for kebab-case paths.
configlib-core/src/test/java/de/exlll/configlib/RootSerializerTest.javaAdds a test and supporting records to validate kebab-case key overrides via snake_case env vars.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment threadconfiglib-core/src/test/java/de/exlll/configlib/RootSerializerTest.java
Outdated

Comment threadconfiglib-core/src/main/java/de/exlll/configlib/RootSerializer.java

Comment on lines

+101
 to 
+109

 private String createEnvironmentVariable(String prefix, String pathSegment) {
 String envVar = prefix.isEmpty()
 ? pathSegment
 : prefix + '_' + pathSegment;
 envVar = envVar.replace('-', '_');
 return envVarConfig.caseSensitive()
 ? envVar
 : envVar.toUpperCase(Locale.ROOT);
 }
@AlexProgrammerDE
Potential fix for pull request finding
ea35ab2
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@Exlll
Exlll
commented
May 22, 2026

Copy link


Copy Markdown

Owner
Hey, thanks for the contribution. Windows allows hyphen in env vars, e.g. MY-VAR. Simply replacing hyphens with underscore is a breaking change. Do you see a solution for this?
@AlexProgrammerDE
AlexProgrammerDE
commented
May 22, 2026

Copy link


Copy Markdown

ContributorAuthor
I think either allow specifying custom environments or allow specifying an env substitutor preprocessor for all names passed to it. I think opening up environments is smarter. Would also allow other environments like java system properties for example.
@Exlll
Exlll
commented
May 25, 2026

Copy link


Copy Markdown

Owner
So we should make the Environment interface public and allow using custom implementations of it by introducing a new setter in the ConfigurationProperties class, right?
@AlexProgrammerDE
AlexProgrammerDE
commented
May 25, 2026

Copy link


Copy Markdown

ContributorAuthor
Yeah I would find that preferable. Do you want me to change the PR?
@Exlll
Exlll
commented
May 25, 2026

Copy link


Copy Markdown

Owner
Sure, if you could do that and also add the necessary tests (that ideally also cover the bug that you encountered), that would be great!
@Exlll
Exlll
commented
May 25, 2026

Copy link


Copy Markdown

Owner
Also, before you start, you might want to rebase first because just merged an open PR into dev.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@AlexProgrammerDE@Exlll

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
fix(core): resolve kebab env vars as snake case by AlexProgrammerDE · Pull Request #62 · Exlll/ConfigLib · GitHub
Skip to content
fix(core): resolve kebab env vars as snake case - #62
Open
AlexProgrammerDE wants to merge 2 commits into
Exlll:devfrom 
6b6t:master
Open
fix(core): resolve kebab env vars as snake case#62
AlexProgrammerDE wants to merge 2 commits into
Exlll:devfrom 
6b6t:master
Conversation
@AlexProgrammerDE
@AlexProgrammerDEAlexProgrammerDE
commented
May 19, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
  • Normalize generated environment variable names by replacing dashes with underscores before lookup.
  • Add a regression test for lower-kebab configuration keys resolving from snake_case environment variables.
Why
Lower-kebab formatted config keys such as encryption-key previously generated environment variable names like ENCRYPTION-KEY, which cannot be used as normal environment variables on many systems. This keeps kebab-case config files while allowing ENCRYPTION_KEY style overrides.
Validation
  • JAVA_HOME=/tmp/codex-jdk21 PATH=/tmp/codex-jdk21/bin:$PATH ./gradlew :configlib-core:check
Disclosure
This PR was made with Codex GPT-5.5 medium fast.

And yes this is a real bug I have in my production plugins.
@AlexProgrammerDE
AlexProgrammerDE
marked this pull request as ready for review
May 19, 2026 15:33
CopilotAI
review requested due to automatic review settings
May 19, 2026 15:33
CopilotAI
reviewed
May 19, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR improves environment-variable preprocessing to support kebab-case config keys being overridden by snake_case environment variable names (e.g., encryption-key → ENCRYPTION_KEY).
Changes:
  • Refactors env-var name construction into a helper method in RootSerializer.
  • Normalizes generated env-var names by replacing - with _.
  • Adds a regression test covering LOWER_KEBAB_CASE config names with snake_case environment variables.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
FileDescription
configlib-core/src/main/java/de/exlll/configlib/RootSerializer.javaCentralizes env-var name creation and adds -→_ normalization for kebab-case paths.
configlib-core/src/test/java/de/exlll/configlib/RootSerializerTest.javaAdds a test and supporting records to validate kebab-case key overrides via snake_case env vars.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment threadconfiglib-core/src/test/java/de/exlll/configlib/RootSerializerTest.java
Outdated

Comment threadconfiglib-core/src/main/java/de/exlll/configlib/RootSerializer.java

Comment on lines

+101
 to 
+109

 private String createEnvironmentVariable(String prefix, String pathSegment) {
 String envVar = prefix.isEmpty()
 ? pathSegment
 : prefix + '_' + pathSegment;
 envVar = envVar.replace('-', '_');
 return envVarConfig.caseSensitive()
 ? envVar
 : envVar.toUpperCase(Locale.ROOT);
 }
@AlexProgrammerDE
Potential fix for pull request finding
ea35ab2
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@Exlll
Exlll
commented
May 22, 2026

Copy link


Copy Markdown

Owner
Hey, thanks for the contribution. Windows allows hyphen in env vars, e.g. MY-VAR. Simply replacing hyphens with underscore is a breaking change. Do you see a solution for this?
@AlexProgrammerDE
AlexProgrammerDE
commented
May 22, 2026

Copy link


Copy Markdown

ContributorAuthor
I think either allow specifying custom environments or allow specifying an env substitutor preprocessor for all names passed to it. I think opening up environments is smarter. Would also allow other environments like java system properties for example.
@Exlll
Exlll
commented
May 25, 2026

Copy link


Copy Markdown

Owner
So we should make the Environment interface public and allow using custom implementations of it by introducing a new setter in the ConfigurationProperties class, right?
@AlexProgrammerDE
AlexProgrammerDE
commented
May 25, 2026

Copy link


Copy Markdown

ContributorAuthor
Yeah I would find that preferable. Do you want me to change the PR?
@Exlll
Exlll
commented
May 25, 2026

Copy link


Copy Markdown

Owner
Sure, if you could do that and also add the necessary tests (that ideally also cover the bug that you encountered), that would be great!
@Exlll
Exlll
commented
May 25, 2026

Copy link


Copy Markdown

Owner
Also, before you start, you might want to rebase first because just merged an open PR into dev.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@AlexProgrammerDE@Exlll

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(core): resolve kebab env vars as snake case by AlexProgrammerDE · Pull Request #62 · Exlll/ConfigLib · GitHub
Skip to content
fix(core): resolve kebab env vars as snake case - #62
Open
AlexProgrammerDE wants to merge 2 commits into
Exlll:devfrom 
6b6t:master
Open
fix(core): resolve kebab env vars as snake case#62
AlexProgrammerDE wants to merge 2 commits into
Exlll:devfrom 
6b6t:master
Conversation
@AlexProgrammerDE
@AlexProgrammerDEAlexProgrammerDE
commented
May 19, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
  • Normalize generated environment variable names by replacing dashes with underscores before lookup.
  • Add a regression test for lower-kebab configuration keys resolving from snake_case environment variables.
Why
Lower-kebab formatted config keys such as encryption-key previously generated environment variable names like ENCRYPTION-KEY, which cannot be used as normal environment variables on many systems. This keeps kebab-case config files while allowing ENCRYPTION_KEY style overrides.
Validation
  • JAVA_HOME=/tmp/codex-jdk21 PATH=/tmp/codex-jdk21/bin:$PATH ./gradlew :configlib-core:check
Disclosure
This PR was made with Codex GPT-5.5 medium fast.

And yes this is a real bug I have in my production plugins.
@AlexProgrammerDE
AlexProgrammerDE
marked this pull request as ready for review
May 19, 2026 15:33
CopilotAI
review requested due to automatic review settings
May 19, 2026 15:33
CopilotAI
reviewed
May 19, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR improves environment-variable preprocessing to support kebab-case config keys being overridden by snake_case environment variable names (e.g., encryption-key → ENCRYPTION_KEY).
Changes:
  • Refactors env-var name construction into a helper method in RootSerializer.
  • Normalizes generated env-var names by replacing - with _.
  • Adds a regression test covering LOWER_KEBAB_CASE config names with snake_case environment variables.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
FileDescription
configlib-core/src/main/java/de/exlll/configlib/RootSerializer.javaCentralizes env-var name creation and adds -→_ normalization for kebab-case paths.
configlib-core/src/test/java/de/exlll/configlib/RootSerializerTest.javaAdds a test and supporting records to validate kebab-case key overrides via snake_case env vars.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment threadconfiglib-core/src/test/java/de/exlll/configlib/RootSerializerTest.java
Outdated

Comment threadconfiglib-core/src/main/java/de/exlll/configlib/RootSerializer.java

Comment on lines

+101
 to 
+109

 private String createEnvironmentVariable(String prefix, String pathSegment) {
 String envVar = prefix.isEmpty()
 ? pathSegment
 : prefix + '_' + pathSegment;
 envVar = envVar.replace('-', '_');
 return envVarConfig.caseSensitive()
 ? envVar
 : envVar.toUpperCase(Locale.ROOT);
 }
@AlexProgrammerDE
Potential fix for pull request finding
ea35ab2
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@Exlll
Exlll
commented
May 22, 2026

Copy link


Copy Markdown

Owner
Hey, thanks for the contribution. Windows allows hyphen in env vars, e.g. MY-VAR. Simply replacing hyphens with underscore is a breaking change. Do you see a solution for this?
@AlexProgrammerDE
AlexProgrammerDE
commented
May 22, 2026

Copy link


Copy Markdown

ContributorAuthor
I think either allow specifying custom environments or allow specifying an env substitutor preprocessor for all names passed to it. I think opening up environments is smarter. Would also allow other environments like java system properties for example.
@Exlll
Exlll
commented
May 25, 2026

Copy link


Copy Markdown

Owner
So we should make the Environment interface public and allow using custom implementations of it by introducing a new setter in the ConfigurationProperties class, right?
@AlexProgrammerDE
AlexProgrammerDE
commented
May 25, 2026

Copy link


Copy Markdown

ContributorAuthor
Yeah I would find that preferable. Do you want me to change the PR?
@Exlll
Exlll
commented
May 25, 2026

Copy link


Copy Markdown

Owner
Sure, if you could do that and also add the necessary tests (that ideally also cover the bug that you encountered), that would be great!
@Exlll
Exlll
commented
May 25, 2026

Copy link


Copy Markdown

Owner
Also, before you start, you might want to rebase first because just merged an open PR into dev.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@AlexProgrammerDE@Exlll

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(core): resolve kebab env vars as snake case by AlexProgrammerDE · Pull Request #62 · Exlll/ConfigLib · GitHub
Skip to content
fix(core): resolve kebab env vars as snake case - #62
Open
AlexProgrammerDE wants to merge 2 commits into
Exlll:devfrom 
6b6t:master
Open
fix(core): resolve kebab env vars as snake case#62
AlexProgrammerDE wants to merge 2 commits into
Exlll:devfrom 
6b6t:master
Conversation
@AlexProgrammerDE
@AlexProgrammerDEAlexProgrammerDE
commented
May 19, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
  • Normalize generated environment variable names by replacing dashes with underscores before lookup.
  • Add a regression test for lower-kebab configuration keys resolving from snake_case environment variables.
Why
Lower-kebab formatted config keys such as encryption-key previously generated environment variable names like ENCRYPTION-KEY, which cannot be used as normal environment variables on many systems. This keeps kebab-case config files while allowing ENCRYPTION_KEY style overrides.
Validation
  • JAVA_HOME=/tmp/codex-jdk21 PATH=/tmp/codex-jdk21/bin:$PATH ./gradlew :configlib-core:check
Disclosure
This PR was made with Codex GPT-5.5 medium fast.

And yes this is a real bug I have in my production plugins.
@AlexProgrammerDE
AlexProgrammerDE
marked this pull request as ready for review
May 19, 2026 15:33
CopilotAI
review requested due to automatic review settings
May 19, 2026 15:33
CopilotAI
reviewed
May 19, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR improves environment-variable preprocessing to support kebab-case config keys being overridden by snake_case environment variable names (e.g., encryption-key → ENCRYPTION_KEY).
Changes:
  • Refactors env-var name construction into a helper method in RootSerializer.
  • Normalizes generated env-var names by replacing - with _.
  • Adds a regression test covering LOWER_KEBAB_CASE config names with snake_case environment variables.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
FileDescription
configlib-core/src/main/java/de/exlll/configlib/RootSerializer.javaCentralizes env-var name creation and adds -→_ normalization for kebab-case paths.
configlib-core/src/test/java/de/exlll/configlib/RootSerializerTest.javaAdds a test and supporting records to validate kebab-case key overrides via snake_case env vars.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment threadconfiglib-core/src/test/java/de/exlll/configlib/RootSerializerTest.java
Outdated

Comment threadconfiglib-core/src/main/java/de/exlll/configlib/RootSerializer.java

Comment on lines

+101
 to 
+109

 private String createEnvironmentVariable(String prefix, String pathSegment) {
 String envVar = prefix.isEmpty()
 ? pathSegment
 : prefix + '_' + pathSegment;
 envVar = envVar.replace('-', '_');
 return envVarConfig.caseSensitive()
 ? envVar
 : envVar.toUpperCase(Locale.ROOT);
 }
@AlexProgrammerDE
Potential fix for pull request finding
ea35ab2
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@Exlll
Exlll
commented
May 22, 2026

Copy link


Copy Markdown

Owner
Hey, thanks for the contribution. Windows allows hyphen in env vars, e.g. MY-VAR. Simply replacing hyphens with underscore is a breaking change. Do you see a solution for this?
@AlexProgrammerDE
AlexProgrammerDE
commented
May 22, 2026

Copy link


Copy Markdown

ContributorAuthor
I think either allow specifying custom environments or allow specifying an env substitutor preprocessor for all names passed to it. I think opening up environments is smarter. Would also allow other environments like java system properties for example.
@Exlll
Exlll
commented
May 25, 2026

Copy link


Copy Markdown

Owner
So we should make the Environment interface public and allow using custom implementations of it by introducing a new setter in the ConfigurationProperties class, right?
@AlexProgrammerDE
AlexProgrammerDE
commented
May 25, 2026

Copy link


Copy Markdown

ContributorAuthor
Yeah I would find that preferable. Do you want me to change the PR?
@Exlll
Exlll
commented
May 25, 2026

Copy link


Copy Markdown

Owner
Sure, if you could do that and also add the necessary tests (that ideally also cover the bug that you encountered), that would be great!
@Exlll
Exlll
commented
May 25, 2026

Copy link


Copy Markdown

Owner
Also, before you start, you might want to rebase first because just merged an open PR into dev.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@AlexProgrammerDE@Exlll

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
fix(core): resolve kebab env vars as snake case by AlexProgrammerDE · Pull Request #62 · Exlll/ConfigLib · GitHub
Skip to content
fix(core): resolve kebab env vars as snake case - #62
Open
AlexProgrammerDE wants to merge 2 commits into
Exlll:devfrom 
6b6t:master
Open
fix(core): resolve kebab env vars as snake case#62
AlexProgrammerDE wants to merge 2 commits into
Exlll:devfrom 
6b6t:master
Conversation
@AlexProgrammerDE
@AlexProgrammerDEAlexProgrammerDE
commented
May 19, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
  • Normalize generated environment variable names by replacing dashes with underscores before lookup.
  • Add a regression test for lower-kebab configuration keys resolving from snake_case environment variables.
Why
Lower-kebab formatted config keys such as encryption-key previously generated environment variable names like ENCRYPTION-KEY, which cannot be used as normal environment variables on many systems. This keeps kebab-case config files while allowing ENCRYPTION_KEY style overrides.
Validation
  • JAVA_HOME=/tmp/codex-jdk21 PATH=/tmp/codex-jdk21/bin:$PATH ./gradlew :configlib-core:check
Disclosure
This PR was made with Codex GPT-5.5 medium fast.

And yes this is a real bug I have in my production plugins.
@AlexProgrammerDE
AlexProgrammerDE
marked this pull request as ready for review
May 19, 2026 15:33
CopilotAI
review requested due to automatic review settings
May 19, 2026 15:33
CopilotAI
reviewed
May 19, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR improves environment-variable preprocessing to support kebab-case config keys being overridden by snake_case environment variable names (e.g., encryption-key → ENCRYPTION_KEY).
Changes:
  • Refactors env-var name construction into a helper method in RootSerializer.
  • Normalizes generated env-var names by replacing - with _.
  • Adds a regression test covering LOWER_KEBAB_CASE config names with snake_case environment variables.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
FileDescription
configlib-core/src/main/java/de/exlll/configlib/RootSerializer.javaCentralizes env-var name creation and adds -→_ normalization for kebab-case paths.
configlib-core/src/test/java/de/exlll/configlib/RootSerializerTest.javaAdds a test and supporting records to validate kebab-case key overrides via snake_case env vars.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment threadconfiglib-core/src/test/java/de/exlll/configlib/RootSerializerTest.java
Outdated

Comment threadconfiglib-core/src/main/java/de/exlll/configlib/RootSerializer.java

Comment on lines

+101
 to 
+109

 private String createEnvironmentVariable(String prefix, String pathSegment) {
 String envVar = prefix.isEmpty()
 ? pathSegment
 : prefix + '_' + pathSegment;
 envVar = envVar.replace('-', '_');
 return envVarConfig.caseSensitive()
 ? envVar
 : envVar.toUpperCase(Locale.ROOT);
 }
@AlexProgrammerDE
Potential fix for pull request finding
ea35ab2
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@Exlll
Exlll
commented
May 22, 2026

Copy link


Copy Markdown

Owner
Hey, thanks for the contribution. Windows allows hyphen in env vars, e.g. MY-VAR. Simply replacing hyphens with underscore is a breaking change. Do you see a solution for this?
@AlexProgrammerDE
AlexProgrammerDE
commented
May 22, 2026

Copy link


Copy Markdown

ContributorAuthor
I think either allow specifying custom environments or allow specifying an env substitutor preprocessor for all names passed to it. I think opening up environments is smarter. Would also allow other environments like java system properties for example.
@Exlll
Exlll
commented
May 25, 2026

Copy link


Copy Markdown

Owner
So we should make the Environment interface public and allow using custom implementations of it by introducing a new setter in the ConfigurationProperties class, right?
@AlexProgrammerDE
AlexProgrammerDE
commented
May 25, 2026

Copy link


Copy Markdown

ContributorAuthor
Yeah I would find that preferable. Do you want me to change the PR?
@Exlll
Exlll
commented
May 25, 2026

Copy link


Copy Markdown

Owner
Sure, if you could do that and also add the necessary tests (that ideally also cover the bug that you encountered), that would be great!
@Exlll
Exlll
commented
May 25, 2026

Copy link


Copy Markdown

Owner
Also, before you start, you might want to rebase first because just merged an open PR into dev.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@AlexProgrammerDE@Exlll