Skip to content

Fix/version week - #533

Open
whes1015 wants to merge 47 commits into
mainfrom
fix/version-week
Open

Fix/version week#533
whes1015 wants to merge 47 commits into
mainfrom
fix/version-week

Conversation

@whes1015

Copy link
Copy Markdown
Member

這個 PR 做了什麼

相關 issue

  • closes #

怎麼驗

檢查清單

  • tool/check_commits.sh origin/main..HEAD 通過
    —— commit 訊息就是更新日誌,格式見 commit.md
  • 一個 commit 一件事(這條 gate 驗不了,靠自己和 review)
  • mise exec -- flutter analyzemise exec -- flutter test 通過
  • 新的使用者可見字串都走 AppLocalizations,沒有寫死
  • 有 UI 變更的話:用的是 AppSpacing / AppRadius / AppMotion
    深色模式看過,文字對比度可接受

@github-actions

github-actionsBot commented Aug 17, 2026

Copy link
Copy Markdown

🔍 OpenCodeReview found 13 issue(s) in this PR.

  • ✅ Successfully posted inline: 11 comment(s)
  • ❌ Failed to post inline: 2 comment(s)

⚠️ 1 warning(s) occurred during review.


maintainability · low

📄 lib/features/changelog/data/changelog_api.dart (L80-L83)

⚠️ GitHub could not post this as an inline comment: No server is currently available to service your request. Sorry about that. Please try resubmitting your request and contact us if the problem persists.

getAvatarBytes 目前沒有處理網路請求可能產生的異常(例如 404 或網路中斷)。建議確認呼叫端是否有完善的錯誤處理機制,或者在此處加入 try-catch 並回傳 null,以避免非核心的頭像讀取失敗導致整個功能崩潰。

💡 Suggested Change

Before:

 Future<Uint8List> getAvatarBytes(String login) async {
final payload = await _client.getBytesAbsolute(avatarUrlFor(login));
return payload.bytes;
}

After:

 Future<Uint8List?> getAvatarBytes(String login) async {
try {
final payload = await _client.getBytesAbsolute(avatarUrlFor(login));
return payload.bytes;
} catch (_) {
return null;
}
}

bug · medium

📄 lib/shared/map/map_timeline.dart (L116-L124)

⚠️ GitHub could not post this as an inline comment: Unprocessable Entity: "Line could not be resolved" - https://docs.github.com/rest/pulls/reviews#create-a-review-for-a-pull-request

_bigLabel 中,當 widget.framePeriod 不為 null 時,end 時間使用的是預設的 _time (HH:mm) 格式,而 start 時間使用的是 widget.timeFormat (如果有的話)。這會導致當使用者自定義了 timeFormat 時,顯示的時間範圍格式不一致(例如:"10:00:00 – 11:00")。建議在 _bigLabel 中也使用與 _times 相同的格式。此外,由於 _cacheLabels 只在 frames 改變時才重新計算,如果 widget.timeFormat 改變但 frames 未變,_times 的格式將不會更新。建議在 didUpdateWidget 中也檢查 timeFormat 是否改變。

💡 Suggested Change

Before:

 String get _bigLabel {
final start = _times[_liveIndex];
final period = widget.framePeriod;
if (period == null) return start;
final end = _time.format(
widget.frames[_liveIndex].time.toLocal().add(period),
);
return '$start – $end';
}

After:

 String get _bigLabel {
final start = _times[_liveIndex];
final period = widget.framePeriod;
if (period == null) return start;
final format = widget.timeFormat ?? _time;
final end = format.format(
widget.frames[_liveIndex].time.toLocal().add(period),
);
return '$start – $end';
}
@override
void didUpdateWidget(covariant MapTimeline oldWidget) {
super.didUpdateWidget(oldWidget);
final framesChanged = !identical(oldWidget.frames, widget.frames);
final formatChanged = oldWidget.timeFormat != widget.timeFormat;
if (framesChanged || formatChanged) _cacheLabels();
// ...
}

⚠️Warnings:

  • lib/features/changelog/domain/release_note.dart (comment_refiled): comment filed against lib/features/changelog/presentation/widgets/release_contributors.dart describes code in lib/features/changelog/domain/release_note.dart; re-filed

Comment on lines +643 to 676
child: Row(
mainAxisAlignment: MainAxisAlignment.center,
children: [
// Filled, not outlined: the one active affordance on a page
// whose every other row is an outlined icon.
Container(
width: 44,
height: 44,
width: 34,
height: 34,
decoration: BoxDecoration(
shape: BoxShape.circle,
color: gold.badge,
),
child: Icon(Icons.favorite, color: gold.onBadge, size: 24),
child: Icon(Icons.favorite, color: gold.onBadge, size: 19),
),
Text(
l10n.sponsorTitle,
textAlign: TextAlign.center,
style: theme.textTheme.titleMedium?.copyWith(
fontWeight: FontWeight.w700,
color: gold.ink,
const SizedBox(width: AppSpacing.sm),
Flexible(
child: Text(
l10n.sponsorTitle,
maxLines: 1,
overflow: TextOverflow.ellipsis,
style: theme.textTheme.titleMedium?.copyWith(
fontWeight: FontWeight.w700,
color: gold.ink,
),
),
),
const SizedBox(width: AppSpacing.xs),
Icon(
Icons.chevron_right,
size: 14,
color: gold.ink.withValues(alpha: 0.7),
),
],
),

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainability · medium
根據程式碼註解的設計意圖,「右側欄位應呈現為一個對齊的堆疊(the right column reads as one aligned stack)」,意指後方的箭頭(trailing arrow)應該在垂直方向上對齊。

然而,目前的實作使用了 MainAxisAlignment.center 搭配 Flexible,這會導致:

  1. 當文字較短時,整個 Row 的內容會集中在中間,箭頭的位置會隨文字長度而左右移動,無法形成右側對齊的「列」。
  2. Flexible 不會強制佔用剩餘空間,只有在文字過長需要截斷時才會縮減。

建議改為:

  1. MainAxisAlignment.center 改為 MainAxisAlignment.start (或移除,因為預設即為 start)。
  2. Flexible 改為 Expanded。這樣文字會填滿中間的剩餘空間,將箭頭強制推至 Row 的最右側,從而達成註解所述的「右側對齊堆疊」效果。

Suggestion:

Suggested change
child:Row(
mainAxisAlignment:MainAxisAlignment.center,
children: [
// Filled, not outlined: the one active affordance on a page
// whose every other row is an outlined icon.
Container(
width:44,
height:44,
width:34,
height:34,
decoration:BoxDecoration(
shape:BoxShape.circle,
color: gold.badge,
),
child:Icon(Icons.favorite, color: gold.onBadge, size:24),
child:Icon(Icons.favorite, color: gold.onBadge, size:19),
),
Text(
l10n.sponsorTitle,
textAlign:TextAlign.center,
style: theme.textTheme.titleMedium?.copyWith(
fontWeight:FontWeight.w700,
color: gold.ink,
constSizedBox(width:AppSpacing.sm),
Flexible(
child:Text(
l10n.sponsorTitle,
maxLines:1,
overflow:TextOverflow.ellipsis,
style: theme.textTheme.titleMedium?.copyWith(
fontWeight:FontWeight.w700,
color: gold.ink,
),
),
),
constSizedBox(width:AppSpacing.xs),
Icon(
Icons.chevron_right,
size:14,
color: gold.ink.withValues(alpha:0.7),
),
],
),
child:Row(
mainAxisAlignment:MainAxisAlignment.start,
children: [
// Filled, not outlined: the one active affordance on a page
// whose every other row is an outlined icon.
Container(
width:34,
height:34,
decoration:BoxDecoration(
shape:BoxShape.circle,
color: gold.badge,
),
child:Icon(Icons.favorite, color: gold.onBadge, size:19),
),
constSizedBox(width:AppSpacing.sm),
Expanded(
child:Text(
l10n.sponsorTitle,
maxLines:1,
overflow:TextOverflow.ellipsis,
style: theme.textTheme.titleMedium?.copyWith(
fontWeight:FontWeight.w700,
color: gold.ink,
),
),
),
constSizedBox(width:AppSpacing.xs),
Icon(
Icons.chevron_right,
size:14,
color: gold.ink.withValues(alpha:0.7),
),
],
),

Fix(zh-Hant): 修正週一上午建置的版本號會標成上一週
Fix(en-US): fix a Monday-morning build being named for the previous week
Optimization(zh-Hant): 贊助卡片改為橫式排版,與右欄其他卡片對齊更好看
Optimization(en-US): the sponsor card now row-aligns with the right column
New(zh-Hant): 更多頁上方卡片重新設計,版本以漸層數字顯示,pre-release 顯示上一版主版本號
New(en-US): the More hero cards go flat, and the version card leads with a gradient major.minor named after the last release
Fix(zh-Hant): 修正圖層時間軸在某些時區會顯示成 UTC 時間
Fix(en-US): map timelines now show frame times in the device's local time instead of UTC
Fix(zh-Hant): 修正「更多」頁上方三張卡片的圖示與文字起點對齊
Fix(en-US): align the icons and text of the three hero cards on the More page
New(zh-Hant): 「更多」頁版本卡改以版號 26.1 為主,測試版同時標示完整版號
New(en-US): the version card on the More page leads with 26.1 and shows the full snapshot name beneath it
New(zh-Hant): 更多頁英雄區加入伺服器狀態卡,並縮小版本卡
New(en-US): Add the server-status card to the More hero block and slim the version card
@whes1015
whes1015 requested a review from a team as a code ownerAugust 17, 2026 09:08
Comment on lines +596 to 648
static const double _versionHeight = 176;

/// Height of a small card (Discord, announcement, status) and, matching it,
/// the full-width support card below.
static const double _smallCardHeight = 56;

@override
Widget build(BuildContext context) {
return SizedBox(
height: _height,
child: Padding(
padding: const EdgeInsets.fromLTRB(
AppSpacing.lg,
0,
AppSpacing.lg,
AppSpacing.md,
),
child: Row(
crossAxisAlignment: CrossAxisAlignment.stretch,
children: [
const Expanded(flex: 1, child: _VersionCard()),
const SizedBox(width: AppSpacing.md),
Expanded(
flex: 1,
child: Column(
children: const [
Expanded(flex: 2, child: _SupportCallout()),
SizedBox(height: AppSpacing.xs),
Expanded(flex: 1, child: _DiscordCallout()),
SizedBox(height: AppSpacing.xs),
Expanded(flex: 1, child: _AnnouncementCard()),
],
return Padding(
padding: const EdgeInsets.fromLTRB(
AppSpacing.lg,
0,
AppSpacing.lg,
AppSpacing.md,
),
child: Column(
crossAxisAlignment: CrossAxisAlignment.stretch,
children: [
Row(
crossAxisAlignment: CrossAxisAlignment.start,
children: [
Expanded(
child: SizedBox(
height: _versionHeight,
child: const _VersionCard(),
),
),
),
],
),
const SizedBox(width: AppSpacing.md),
Expanded(
child: Column(
children: const [
SizedBox(
height: _smallCardHeight,
child: _DiscordCallout(),
),
SizedBox(height: AppSpacing.xs),
SizedBox(
height: _smallCardHeight,
child: _AnnouncementCard(),
),
SizedBox(height: AppSpacing.xs),
SizedBox(height: _smallCardHeight, child: _StatusCard()),
],
),
),
],
),
const SizedBox(height: AppSpacing.md),
SizedBox(height: _smallCardHeight, child: const _SupportCallout()),
],
),
);
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other · medium
UI 佈局的高度適應性風險。_HeroCards 使用了硬編碼的高度(_versionHeight = 176, _smallCardHeight = 56)。在不同螢幕尺寸或使用者設定較大字體時,這些固定高度可能導致內容(如文字或圖示)發生垂直溢出(Overflow)或顯示不全。

Comment on lines +958 to +975
static List<Color> _hashGradient(String seed, Brightness brightness) {
var h = 7;
for (final rune in seed.runes) {
h = (h * 31 + rune) & 0x7fffffff;
}
final base = h % 360;
const saturation = 0.62;
final light = brightness == Brightness.dark ? 0.70 : 0.46;
return [
HSLColor.fromAHSL(1, base.toDouble(), saturation, light).toColor(),
HSLColor.fromAHSL(
1,
(base + 137.508) % 360,
saturation,
light - 0.10,
).toColor(),
];
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainability · low
_hashGradient 函數中使用了多個「魔法數字」(例如:黃金角度 137.508、飽和度 0.62、亮度偏移 0.10 等)。建議將這些設計參數提取為具備明確名稱的私有常數,以提升程式碼的可讀性與維護性。

Comment on lines +120 to +122
final end = _time.format(
widget.frames[_liveIndex].time.toLocal().add(period),
);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainability · medium
widget.timeFormat 與預設的 _time 不同時,start 會使用 widget.timeFormat 格式化,而 end 會使用 _time 格式化,導致顯示的範圍標籤格式不一致。建議在計算 end 時也使用 widget.timeFormat ?? _time

Suggestion:

Suggested change
final end = _time.format(
widget.frames[_liveIndex].time.toLocal().add(period),
);
final format = widget.timeFormat ?? _time;
final end = format.format(
widget.frames[_liveIndex].time.toLocal().add(period),
);

New(zh-Hant): 版本卡片正式版也會顯示完整版本號
New(en-US): The hero version card now shows a version line for releases too
New(zh-Hant): 新版號 26.2.1 的版型只顯示 26.2
New(en-US): A three-part release (26.2.1) advertises as 26.2; the patch stays in the label
New(zh-Hant): 版本卡片徽章加上 build 日期
New(en-US): The More page badge shows the day the build was cut
New(zh-Hant): 版本徽章右側顯示 build 日期
New(en-US): The version badge now carries the day this build was cut
Comment on lines 74 to +76
static Future<void> ensureLoaded() async {
if (_label != null) return;
String platformVersion = '';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

performance · low
ensureLoaded 方法目前的冪等性檢查依賴於 _label != null。如果 _bestLabel 為空或 _bestCode 不大於 0(例如在某些開發環境下),_label 將保持為 null,導致每次呼叫 ensureLoaded 都會重新執行非同步的 PackageInfo.fromPlatform()。建議使用一個獨立的布林值(如 _isLoaded)來標記載入狀態,以避免重複的 IO 操作。

Suggestion:

Suggested change
staticFuture<void> ensureLoaded() async {
if (_label !=null) return;
String platformVersion ='';
staticbool _isLoaded =false;
staticFuture<void> ensureLoaded() async {
if (_isLoaded) return;
String platformVersion ='';
try {
final info =awaitPackageInfo.fromPlatform();
platformVersion = info.version;
} onObject {
// A version readout is never worth failing a launch over. The platform
// version line simply stays empty for that build.
}
_platformVersion = platformVersion;
if (_bestLabel.isNotEmpty && _bestCode >0) {
_label = _bestLabel;
_code = _bestCode;
}
_isLoaded =true;
}

Comment on lines +625 to +639
child: Column(
children: const [
SizedBox(
height: _smallCardHeight,
child: _DiscordCallout(),
),
SizedBox(height: AppSpacing.xs),
SizedBox(
height: _smallCardHeight,
child: _AnnouncementCard(),
),
SizedBox(height: AppSpacing.xs),
SizedBox(height: _smallCardHeight, child: _StatusCard()),
],
),

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bug · medium
_HeroCards 的佈局使用了固定的高度(如 _versionHeight_smallCardHeight)來包裹包含文字內容的組件(例如 _DiscordCallout_AnnouncementCard_StatusCard_VersionCard)。這在 Flutter 中存在嚴重的佈局溢出(Overflow)風險,特別是當使用者在系統設定中啟用了「大字體模式」(Font Scaling),或者在不同語言的本地化過程中,文字內容長度增加導致高度超過預設值時。建議考慮使用 IntrinsicHeight 來讓 Row 中的元素高度同步,或者改用 BoxConstraintsminHeight 而非固定 height,以允許組件根據內容自動增長。

Comment on lines +958 to +975
static List<Color> _hashGradient(String seed, Brightness brightness) {
var h = 7;
for (final rune in seed.runes) {
h = (h * 31 + rune) & 0x7fffffff;
}
final base = h % 360;
const saturation = 0.62;
final light = brightness == Brightness.dark ? 0.70 : 0.46;
return [
HSLColor.fromAHSL(1, base.toDouble(), saturation, light).toColor(),
HSLColor.fromAHSL(
1,
(base + 137.508) % 360,
saturation,
light - 0.10,
).toColor(),
];
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other · medium
_hashGradient 函數透過版本字串動態生成顏色,雖然考慮了主題亮度(lightness flips with the theme),但這並不能完全保證產生的顏色與背景色(colors.surfaceContainer)之間具備足夠的對比度以符合無障礙設計標準(WCAG)。在極端情況下,生成的顏色可能與背景色過於接近,導致文字難以辨識。建議在生成顏色後,加入對比度檢查機制,或是在亮度(lightness)範圍上設定更保守的邊界。

Comment on lines +2048 to +2049
@override
String get moreTagline => 'Platform Integrasi Informasi Bencana';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainability · low
印尼文翻譯與英文原文語意不一致。英文定義為 'Disaster Prevention Information Platform' (災害預防資訊平台),但目前的印尼文翻譯為 'Platform Integrasi Informasi Bencana' (災害資訊整合平台),其中 'Integrasi' 意為 '整合' 而非 '預防' (Pencegahan)。建議修正以符合原文語意。

Suggestion:

Suggested change
@override
Stringget moreTagline =>'Platform Integrasi Informasi Bencana';
@override
Stringget moreTagline =>'Platform Informasi Pencegahan Bencana';

Comment on lines +218 to +222
final utc = DateTime.utc(2026, 7, 13, 14, 30); // 22:30 in UTC+8
final frames = [MapFrame(id: '0', time: utc)];
await tester.pumpWidget(
_wrap(frames: frames, selectedIndex: 0, onSelected: (_) {}),
);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test · medium
該測試案例高度依賴於執行環境的時區。若在 CI 環境(通常時區設定為 UTC)中執行,utc.toLocal() 的結果會與 utc 完全相同。這意味著即使程式碼錯誤地直接顯示了 UTC 時間,測試依然會通過,從而無法達到攔截 Bug 的目的。建議選擇一個在轉換為本地時間後會明顯改變小時或日期的時間點(例如接近 UTC 當天結尾的時間),以增加測試在不同環境下的魯棒性。

Suggestion:

Suggested change
final utc =DateTime.utc(2026, 7, 13, 14, 30); // 22:30 in UTC+8
final frames = [MapFrame(id:'0', time: utc)];
await tester.pumpWidget(
_wrap(frames: frames, selectedIndex:0, onSelected: (_) {}),
);
// 建議選擇一個轉換後容易產生差異的時間點,例如 UTC 23:30
final utc =DateTime.utc(2026, 7, 13, 23, 30);
final frames = [MapFrame(id:'0', time: utc)];
await tester.pumpWidget(
_wrap(frames: frames, selectedIndex:0, onSelected: (_) {}),
);

New(zh-Hant): 首頁地區列下方浮一條金色支持橫條,點擊前往贊助頁
New(en-US): Home floats a gold support pill under the region bar, opening the sponsor page
New(zh-Hant): 繁體贊助相關文案改用「支援」
New(en-US): Traditional-Chinese support copy now reads 支援, not 支持
New(zh-Hant): README 新增 Android 測試版與 iOS TestFlight 連結
New(en-US): README now links the Android testing track and the iOS TestFlight beta
Fix(zh-Hant): 修正公測使用者可能被當成正式版使用者,收到比手上還舊的更新提示
Fix(en-US): fix a beta tester being treated as a stable user and offered an older build
Comment on lines +2048 to +2049
@override
String get moreTagline => 'Platform Integrasi Informasi Bencana';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainability · low
印尼文翻譯建議確認語意一致性。目前的翻譯為 "災害資訊整合平台" (Platform Integrasi Informasi Bencana),而英文版本為 "Disaster Prevention Information Platform",中文版本為 "防災資訊整合平台",兩者皆強調了「預防/防災」(Prevention) 的含義。建議確認是否應加入預防含義(例如使用 "Pencegahan Bencana"),以保持各語言間語意的一致性。

Suggestion:

Suggested change
@override
Stringget moreTagline =>'Platform Integrasi Informasi Bencana';
@override
Stringget moreTagline =>'Platform Integrasi Informasi Pencegahan Bencana';

Comment on lines +4886 to +4887
@override
String get moreTagline => '防灾信息整合平台';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bug · medium
AppLocalizationsZhHans 繼承自 AppLocalizationsZh,由於父類使用了繁體中文用語(如 '支援')及繁體字體,且 AppLocalizationsZhHans 未重寫相關屬性,會導致簡體中文版本出現繁體中文內容,造成語言不一致。建議在 AppLocalizationsZhHans 中重寫 sponsorTitle, sponsorIntro 與 sponsorCalloutBody 並使用簡體中文。

Fix(zh-Hant): 修正在「更多」點開 App 日誌後畫面狂刷並卡死
Fix(en-US): fix the app freezing after opening the log screen from More
Optimization(zh-Hant): App 日誌改用內建畫面,多了搜尋、等級篩選與分享
Optimization(en-US): the log screen gains search, level filtering and sharing
Fix(zh-Hant): 修正日誌頁把同一個錯誤不斷印到主控台,回放的紀錄也不再遺失等級
Fix(en-US): stop the log screen reprinting one fault forever, and keep replayed levels
Fix(zh-Hant): 修正開啟日誌頁會把整份紀錄重印到主控台,並重複寫回資料庫
Fix(en-US): opening the log no longer reprints the whole table or writes it back
Fix(zh-Hant): 修正日誌頁的清除只清畫面,重開又整份回來
Fix(en-US): clearing the log no longer leaves everything to come back on reopen
Fix(zh-Hant): 修正日誌頁上方等級篩選器把回放的紀錄全算成 undefined
Fix(en-US): the level filter counts replayed lines under their level again
Fix(zh-Hant): 修正開啟日誌頁會把本次啟動的紀錄擠掉,順序也錯亂
Fix(en-US): opening the log no longer pushes out the running session's lines
Fix(zh-Hant): 修正啟動早期的紀錄從來沒被存下來,當機時最該看的那幾行都不見
Fix(en-US): fix the launch's own log lines never being stored, the ones a crash needs
Optimization(zh-Hant): 日誌的等級標籤改成大寫,一眼看得出哪一行不是 INFO
Optimization(en-US): log lines are tagged INFO / WARN / ERROR, readable at a glance
Optimization(zh-Hant): 主控台的日誌改成一則一行,不再有框線與跑掉的顏色碼
Optimization(en-US): console logs are one plain line each, without borders or stray colour codes
Optimization(zh-Hant): 主控台的等級標籤可以上色,用 --dart-define=DPIP_LOG_COLOR=true 開啟
Optimization(en-US): the console level tag can be coloured with --dart-define=DPIP_LOG_COLOR=true
Fix(zh-Hant): 修正 iOS 上開啟主控台顏色只會多出跳脫字元,看不到顏色
Fix(en-US): enabling console colour on iOS added escape characters instead of colour
Optimization(zh-Hant): 新增 tool/colorize_logs.sh,在終端機端替日誌上色
Optimization(en-US): add tool/colorize_logs.sh, which colours the log in the terminal
Optimization(zh-Hant): 新增 tool/run.sh,一個指令跑起來就有上色的日誌
Optimization(en-US): add tool/run.sh so one command runs the app with a coloured log
Fix(zh-Hant): 修正結束執行時出現 Broken pipe 的未處理例外
Fix(en-US): fix the unhandled Broken pipe exception when a run is stopped
New(zh-Hant): 修復伺服器狀態頁依賴的網路層支援
New(en-US): restore the ApiClient hooks the status page relies on
New(zh-Hant): 除錯版偵測到非腳本啟動將直接拒絕執行並提示正確指令,新增 Windows 啟動腳本
New(en-US): the debug build refuses non-script launches and there is now a Windows run script
New(zh-Hant): 取得 App 下方新增 測試版 與 合作夥伴 區塊
New(en-US): beta channels and partner tiles now sit under Get the app
New(zh-Hant): 伺服器狀態查詢在離線時會改用上次快取結果
New(en-US): status POSTs cache under their URL and serve offline
New(zh-Hant): 更新日誌的貢獻者改為頭像加名稱的名牌,可點開 GitHub 個人頁
New(en-US): changelog contributors are avatar + name badges that open GitHub
New(zh-Hant): 地震報告圖快取到本機,重複查看不再每次重新下載
New(en-US): the report image now round-trips the ETag cache
New(zh-Hant): 無背景定位支援的平台不再回報麵包屑傾倒錯誤
New(en-US): breadcrumb draining no longer trips on missing plugins
`bool.fromEnvironment` reads only the exact string `true` and answers `false`
to everything else, including the `1` the script passed — so the guard fired on
the very launch that had obeyed it. That is the worst way for a guard to fail:
it punishes the correct behaviour and teaches people to ignore it.
The scripts send `true` now, and the marker is read with
`String.fromEnvironment != ''` so any value counts — the next person to edit
that line will not remember this either.
The colouriser also missed the prefix on a blank line, which Flutter writes as
`flutter:` with no trailing space, so a multi-line message kept it.
Fix(zh-Hant): 更新日誌改為標示真正寫這項變更的人,並附上可點擊的 commit 連結
Fix(en-US): each entry credits who wrote it and links the commit it came from
GitHub squashes a pull request into one commit and sets its author to whoever
pressed the button, demoting everyone who wrote it to a `Co-authored-by:`
trailer. `41a3c1e8 Fix eew (#534)` is authored by the maintainer who merged it
and was written, every commit of it, by somebody else — so 26w34b credited the
wrong person, which is worse than crediting nobody.
A summary carrying `(#N)` now takes its authors from that pull request's own
commits, which is the only place they survive a squash intact; trailers are
merged in for a merge without a number, and the commit's own author is the
fallback. Every entry also links its commit, which for a squash is also the
link to the request.
The gate had made this worse by banning `Co-authored-by:` outright. It was
aimed at a tool crediting itself, and it destroyed the one record of human
attribution a squash leaves behind. It now judges the trailer by who it names.
New(zh-Hant): 除錯資訊頁新增「傾印除錯資訊及日誌」,上傳後複製連結
New(en-US): the debug page can upload the diagnostics and log, and copies the link back
The two halves answer different questions and a report needs both: the
diagnostics say what this build and this device are, the log says what they
just did. Pasting 4000 characters into a chat buries the conversation it is
part of, so they go to a paste and only the link comes back.
The diagnostics are never trimmed — a partial one reads as a complete one and
gets answered as if it were — so the log takes whatever is left of the 4000,
filled from the newest backwards and written oldest first. A line goes in whole
or not at all, because half a line is a lie about what was logged.
The log is in the same shape the terminal uses, so a line pasted from one and a
line pasted from the other are the same line.
Change(zh-Hant): 「傾印除錯資訊及日誌」移到更多 → 除錯資訊下方,並翻譯成十種語言
Change(en-US): the debug dump moved to More, under Debug info, and is now translated
It was a row at the bottom of the Developer page, which is the page a person
reaches only after being told where it is. The dump exists for the people who
have not been told, so it now sits in the menu they are already in, one row
under the page it dumps.
Two screens asking for the diagnostics meant the collection could no longer
live inside one of them, and the layer rules would not let More reach into
Settings for it — so it moved to core/diagnostics, which is where every source
it reads already lives. The Developer page renders from the same report it
uploads, and the redaction list that keeps the push token and the device
identifier out of a paste is now one list instead of two. Two would have
drifted, and the copy that drifts is the one that leaks.
The row is user-facing, so unlike the Developer page it is translated.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@whes1015@lowrt