This repository was archived by the owner on Jun 15, 2021. It is now read-only.
Refactor IcebergObjectInspector and implement custom object inspectors - #12
Merged
Merged
Conversation
guilload
force-pushed
the
guilload--implement-object-inspectors
branch
from
June 20, 2020 03:39
0b4d6ef to
8bbcf7b
Compare
|
Thanks for the PR @guilload, we're working on a review and testing this out in a branch with the Hiveberg project :D |
guilload
force-pushed
the
guilload--implement-object-inspectors
branch
from
June 25, 2020 21:19
2de7589 to
3b18a5a
Compare
massdosage
approved these changes
Jun 26, 2020
rdsr
reviewed
Jun 29, 2020
| return null; | ||
| default: | ||
| throw new NoSuchTableException("Table does not exist at location: " + tableLocation); | ||
| throw new RuntimeException("Catalog " + catalogName + " not supported."); |
There was a problem hiding this comment.
Sure, we can address that in https://github.com/apache/iceberg/pull/1103/files#diff-64ac74e3513bf6536c0a39f377c48ce5R62 (I'll make the change now, also spotted that the tests for this class could be fleshed out and tidied up a bit)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As previously discussed, here is my PR implementing custom object inspectors for the
IcebergSerDe. As a consequence, the class is greatly simplified. I also slightly refactored theTableResolverto write some tests without having to set the table name.I was able to read a table written with Spark with this SerDe so I have some confidence in the implementation. However, I maybe have missed some subtleties when converting Iceberg objects to Hive objects, mostly for the decimal and timestamp types.
🥖