Skip to content

Revert "upgrade react-native-live-markdown to 0.1.76" - #42843

Merged
puneetlath merged 1 commit into
Expensify:mainfrom
ishpaul777:revert-42454-update-rn-live-markdown-0176
May 30, 2024
Merged

Revert "upgrade react-native-live-markdown to 0.1.76"#42843
puneetlath merged 1 commit into
Expensify:mainfrom
ishpaul777:revert-42454-update-rn-live-markdown-0176

Conversation

@ishpaul777

@ishpaul777ishpaul777 commented May 30, 2024

Copy link
Copy Markdown
Contributor

Reverts #42454

@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

github-actionsBot commented May 30, 2024

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖iOS 🍎
❌ FAILED ❌❌ FAILED ❌
The QR code can't be generated, because the android build failedThe QR code can't be generated, because the iOS build failed
Desktop 💻Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/42843/NewExpensify.dmghttps://42843.pr-testing.expensify.com
DesktopWeb

👀 View the workflow run that generated this build 👀

@ishpaul777
ishpaul777 marked this pull request as ready for review May 30, 2024 19:10
@ishpaul777
ishpaul777 requested a review from a team as a code ownerMay 30, 2024 19:10
@melvin-bot
melvin-botBot requested review from cristipaval and removed request for a teamMay 30, 2024 19:10
@melvin-bot

melvin-botBot commented May 30, 2024

Copy link
Copy Markdown

@cristipaval Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@ishpaul777

ishpaul777 commented May 30, 2024

Copy link
Copy Markdown
ContributorAuthor

Revert solves #42766@puneetlath

WhatsApp.Video.2024-05-31.at.12.51.18.AM.mp4

@puneetlath
puneetlath merged commit 4df3c76 into Expensify:mainMay 30, 2024
@melvin-bot

melvin-botBot commented May 30, 2024

Copy link
Copy Markdown

@puneetlath looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify pushed a commit that referenced this pull request May 30, 2024
@puneetlath@OSBotify
Merge pull request#42843from ishpaul777/revert-42454-update-rn-live…
db6a0d7
…-markdown-0176
Revert "upgrade react-native-live-markdown to 0.1.76"
(cherry picked from commit 4df3c76)
@puneetlath

puneetlath commented May 30, 2024

Copy link
Copy Markdown
Contributor

Straight revert to a deploy blocker, so merged without checklist.

@ishpaul777ishpaul777 mentioned this pull request May 30, 2024
Merged
50 tasks
@github-actionsgithub-actionsBot mentioned this pull request May 30, 2024
Closed
@OSBotify

OSBotify commented May 30, 2024

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@kbeccivkbecciv mentioned this pull request May 30, 2024
Closed
6 tasks
@OSBotify

OSBotify commented May 30, 2024

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 1.4.77-9 🚀

platformresult
🤖 android 🤖success ✅
🖥 desktop 🖥success ✅
🍎 iOS 🍎success ✅
🕸 web 🕸success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify

OSBotify commented May 30, 2024

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀

platformresult
🤖 android 🤖failure ❌
🖥 desktop 🖥success ✅
🍎 iOS 🍎success ✅
🕸 web 🕸success ✅

@OSBotify

OSBotify commented May 30, 2024

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀

platformresult
🤖 android 🤖success ✅
🖥 desktop 🖥success ✅
🍎 iOS 🍎success ✅
🕸 web 🕸success ✅

@VickyStashVickyStash mentioned this pull request May 31, 2024
Merged
53 tasks
@bernhardojbernhardoj mentioned this pull request Jun 3, 2024
Closed
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@puneetlathpuneetlathpuneetlath approved these changes
@cristipavalcristipavalAwaiting requested review from cristipaval

Assignees

No one assigned

Labels

Ready To Build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ishpaul777@puneetlath@OSBotify