Skip to content

Revert "Emojis larger in other contexts than just single character messages" - #46463

Merged
roryabraham merged 1 commit into
mainfrom
revert-40692-feat/enlarge-emojis-font-size
Jul 30, 2024
Merged

Revert "Emojis larger in other contexts than just single character messages"#46463
roryabraham merged 1 commit into
mainfrom
revert-40692-feat/enlarge-emojis-font-size

Conversation

@marcochavezf

@marcochavezfmarcochavezf commented Jul 29, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

@marcochavezf
marcochavezf requested review from a team as code ownersJuly 29, 2024 23:53
@melvin-bot

melvin-botBot commented Jul 29, 2024

Copy link
Copy Markdown

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

@melvin-bot
melvin-botBot requested review from luacmartins and removed request for a teamJuly 29, 2024 23:53
@melvin-bot

melvin-botBot commented Jul 29, 2024

Copy link
Copy Markdown

@luacmartins Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@marcochavezfmarcochavezf mentioned this pull request Jul 29, 2024
Closed
6 tasks
@shawnborton

shawnborton commented Jul 30, 2024

Copy link
Copy Markdown
Contributor

Works for me too, do you have the associated bug report or deploy blocker handy? Just curious what went wrong with this one.

@mkhutornyi

mkhutornyi commented Jul 30, 2024

Copy link
Copy Markdown
Contributor

Works for me too, do you have the associated bug report or deploy blocker handy? Just curious what went wrong with this one.

https://expensify.slack.com/archives/C01GTK53T8Q/p1722321575027469?thread_ts=1722282538.734549&cid=C01GTK53T8Q

@iwizniaiwiznia mentioned this pull request Jul 30, 2024
Closed
6 tasks
@roryabraham

roryabraham commented Jul 30, 2024

Copy link
Copy Markdown
Contributor

skipping checklists for straight revert

@roryabraham
roryabraham merged commit 3257e2f into mainJul 30, 2024
@roryabraham
roryabraham deleted the revert-40692-feat/enlarge-emojis-font-size branch July 30, 2024 15:18
@melvin-bot

melvin-botBot commented Jul 30, 2024

Copy link
Copy Markdown

@roryabraham looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify pushed a commit that referenced this pull request Jul 30, 2024
@roryabraham@OSBotify
Merge pull request#46463from Expensify/revert-40692-feat/enlarge-em…
005cbad
…ojis-font-size
Revert "Emojis larger in other contexts than just single character messages"
(cherry picked from commit 3257e2f)
@VickyStashVickyStash mentioned this pull request Jul 30, 2024
Closed
@github-actionsgithub-actionsBot mentioned this pull request Jul 30, 2024
Closed
84 tasks
@OSBotify

OSBotify commented Jul 30, 2024

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

github-actionsBot commented Jul 30, 2024

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/46463/index.htmlhttps://ad-hoc-expensify-cash.s3.amazonaws.com/ios/46463/index.html
AndroidiOS
Desktop 💻Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/46463/NewExpensify.dmghttps://46463.pr-testing.expensify.com
DesktopWeb

👀 View the workflow run that generated this build 👀

@OSBotify

OSBotify commented Jul 30, 2024

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.0.14-3 🚀

platformresult
🤖 android 🤖success ✅
🖥 desktop 🖥success ✅
🍎 iOS 🍎success ✅
🕸 web 🕸success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@francoislfrancoisl mentioned this pull request Jul 30, 2024
Closed
6 tasks
@OSBotify

OSBotify commented Jul 31, 2024

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/roryabraham in version: 9.0.14-6 🚀

platformresult
🤖 android 🤖success ✅
🖥 desktop 🖥success ✅
🍎 iOS 🍎success ✅
🕸 web 🕸success ✅

@VickyStashVickyStash mentioned this pull request Aug 7, 2024
Closed
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@luacmartinsluacmartinsluacmartins approved these changes
@dubielzyk-expensifydubielzyk-expensifydubielzyk-expensify approved these changes

Assignees

No one assigned

Labels

Ready To Build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@marcochavezf@shawnborton@mkhutornyi@roryabraham@OSBotify@luacmartins@dubielzyk-expensify