[iOS] add caretHeight and caretYoffset to TextInput component #37147 by OlimpiaZurek · Pull Request #58 · Expensify/react-native

OlimpiaZurek · 2023-05-23T08:49:46Z

Upstream PR Link

Summary

This PR adds support for the caretHeight and caretPosition properties in iOS multi-line TextInput. Based on these values, we can calculate the caret position and height and adjust them in the appl so that the cursor does not overlap the previous line of text.

Changelog

[IOS] [ADDED] - caretHeight and caretPosition for multiline TextInput component

Test Plan

Default caret:

default_caret.mov

Caret with caretHeight and caretYOffsetadjustment:

adjusting_caret.mov

burczu · 2023-05-23T09:28:06Z

shouldn't be toTextInput.caretHeight = fromTextInput.caretHeight here?

good catch! Fixed :-)

Santhosh-Sellavel

Adding myself as a reviewer!

Santhosh-Sellavel · 2023-05-29T22:21:40Z

Looking good so far, I'll test it out tomorrow.

Sorry missing track of these, can anyone mention me here so I can pin the notifications to keep track of it.

alex-mechler · 2023-05-30T15:20:04Z

can anyone mention me here so I can pin the notifications to keep track of it.

@Santhosh-Sellavel here's your ping

Santhosh-Sellavel · 2023-05-30T19:23:57Z

Looks great!

Simulator.Screen.Recording.-.iPhone.14.-.2023-05-31.at.00.52.53.mp4

Santhosh-Sellavel

What's wrong here with the checklist?

Otherwise, LGTM tests well @alex-mechler!

alex-mechler · 2023-05-30T20:57:24Z

Hmm, I have not seen that before. Looks like its normally skipped. Will ask around

alex-mechler · 2023-05-30T21:01:36Z

 * @platform ios
 */
 smartInsertDelete?: ?boolean,
+ /**


NAB: Missing a blank line before this comment

alex-mechler · 2023-05-30T21:01:49Z

 #import <React/RCTBackedTextInputDelegateAdapter.h>
 #import <React/RCTTextAttributes.h>

+//the UITextSelectionRect subclass needs to be created because the original version is not writable


NAB:
Suggested change
//the UITextSelectionRect subclass needs to be created because the original version is not writable
//the UITextSelectionRect subclass needs to be created because the original version is not writable

alex-mechler · 2023-05-30T21:38:13Z

Tested well, we can ignore the danger check here.

@OlimpiaZurek Can you update the base to be Expensify-0.71.2-alpha.4 to make this easier to deploy?

AndrewGable · 2023-06-05T17:22:18Z

Please target ExpensifyRC1-0.72.0-alpha.0 as this is the version we plan to release. Thanks!

Santhosh-Sellavel · 2023-06-05T17:22:34Z

@OlimpiaZurek bump!

Santhosh-Sellavel · 2023-06-07T19:00:36Z

@OlimpiaZurek bump!

Santhosh-Sellavel · 2023-06-07T19:01:07Z

@alex-mechler Can you give a bump on any internal channels for callstack!

alex-mechler · 2023-06-07T22:57:45Z

Actually, we might not need to, based on. https://expensify.slack.com/archives/C01GTK53T8Q/p1686159512184629. We are moving towards deprecating our fork of RN

AndrewGable · 2023-06-08T17:05:09Z

FYI I have bumped the upstream PR with Meta

Santhosh-Sellavel · 2023-07-23T20:48:08Z

@AndrewGable Can you bump again?

AndrewGable · 2023-07-24T17:34:31Z

@OlimpiaZurek - Can you fix the upstream PR's conflicts and then I can reach out again? Thanks.

AndrewGable · 2023-07-24T17:35:17Z

Or @koko57 since you might have access to the fork? Thanks

koko57 · 2023-07-24T18:41:03Z

Or @koko57 since you might have access to the fork? Thanks

Yes, I will take care of this tomorrow 😊

koko57 · 2023-07-25T12:07:55Z

@AndrewGable all conflicts are resolved in the upstream PR, the target branch is changed here for ExpensifyRC1-0.72.0-alpha.0 and all conflicts here are resolved as well

AndrewGable · 2023-07-25T13:28:34Z

Thank you, bumped the upstream PR for a review via Discord!

Santhosh-Sellavel · 2023-08-11T17:51:55Z

@AndrewGable Still no review. Can you bump them again, thanks!

feat: add caretHeight and caretYoffset to TextInput component
6513a91

burczu reviewed May 23, 2023
View reviewed changes

minor changes after code review
b85913b

OlimpiaZurek force-pushed the feature/fix-caret-position branch from 0f17587 to b85913bCompare May 23, 2023 09:36

OlimpiaZurek marked this pull request as ready for review May 24, 2023 11:46

OlimpiaZurek mentioned this pull request May 24, 2023
[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [HOLD for payment 2024-06-06] [HOLD #37147 RN PR][$2000] iOS - Chat - Cursor in the second and following lines touches the symbols of the previous line Expensify/App#15640
Closed
6 tasks

alex-mechler self-requested a review May 25, 2023 16:10

Santhosh-Sellavel reviewed May 25, 2023
View reviewed changes

Santhosh-Sellavel reviewed May 30, 2023
View reviewed changes

alex-mechler reviewed May 30, 2023
View reviewed changes

fedirjh mentioned this pull request Jun 1, 2023
[HOLD facebook/react-native#37465] Fix TextInput vertical alignment issue when using lineHeight prop on iOS (Paper - old arch) #57
Closed

OlimpiaZurek changed the base branch from Expensify-0.71.2-alpha.3 to ExpensifyRC1-0.72.0-alpha.0July 25, 2023 11:25

koko57 added 2 commits July 25, 2023 13:49

fix: resolve conflicts
c66520f

fix: minor fixes
a8ea210

	//the UITextSelectionRect subclass needs to be created because the original version is not writable
	//the UITextSelectionRect subclass needs to be created because the original version is not writable

Uh oh!

Conversation

OlimpiaZurek commented May 23, 2023

Upstream PR Link

Summary

Changelog

Test Plan

Uh oh!

burczuMay 23, 2023

Choose a reason for hiding this comment

Uh oh!

OlimpiaZurekMay 23, 2023

Choose a reason for hiding this comment

Uh oh!

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

Uh oh!

Santhosh-Sellavel commented May 29, 2023

Uh oh!

alex-mechler commented May 30, 2023

Uh oh!

Santhosh-Sellavel commented May 30, 2023

Uh oh!

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

Uh oh!

alex-mechler commented May 30, 2023

Uh oh!

alex-mechlerMay 30, 2023

Choose a reason for hiding this comment

Uh oh!

alex-mechlerMay 30, 2023

Choose a reason for hiding this comment

Uh oh!

alex-mechler commented May 30, 2023

Uh oh!

AndrewGable commented Jun 5, 2023

Uh oh!

Santhosh-Sellavel commented Jun 5, 2023

Uh oh!

Santhosh-Sellavel commented Jun 7, 2023

Uh oh!

Santhosh-Sellavel commented Jun 7, 2023

Uh oh!

alex-mechler commented Jun 7, 2023

Uh oh!

AndrewGable commented Jun 8, 2023

Uh oh!

Santhosh-Sellavel commented Jul 23, 2023

Uh oh!

AndrewGable commented Jul 24, 2023

Uh oh!

AndrewGable commented Jul 24, 2023

Uh oh!

koko57 commented Jul 24, 2023

Uh oh!

koko57 commented Jul 25, 2023

Uh oh!

AndrewGable commented Jul 25, 2023

Uh oh!

Santhosh-Sellavel commented Aug 11, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants