Uh oh!
There was an error while loading. Please reload this page.
fix: validation error messages match DynamoDB format - #16
Merged
Conversation
- Add validation_error()/validation_errors() formatter functions - Table name: length errors include value and field path - KeySchema: >2 elements includes serialized array value - TransactGetItems/TransactWriteItems: empty/too-many use correct format - BatchGetItem: per-table >100 keys uses correct field path - BatchWriteItem: >25 items includes map value representation
jcshepherd
approved these changes
May 14, 2026
LeeroyHannigan added a commit
that referenced
this pull request
Aug 18, 2026
CodeQL (actions/cache-poisoning/poisonable-step) flags writing the default branch's actions cache from a job that checks out a dispatch-resolved SHA. The gate proves that SHA is an ancestor of origin/main, so the checkout is reviewed history, but the cache write is still the one genuine poisoning vector the rule describes, and it buys little on a rare release build that the LTO link dominates. Removed. The remaining alert on the gate job has no cache usage at all and mirrors the two open alerts on release-image.yml (#16, #17): the rule matches any checkout-and-execute of a resolved SHA under workflow_dispatch.
LeeroyHannigan added a commit
that referenced
this pull request
Aug 19, 2026
CodeQL (actions/cache-poisoning/poisonable-step) flags writing the default branch's actions cache from a job that checks out a dispatch-resolved SHA. The gate proves that SHA is an ancestor of origin/main, so the checkout is reviewed history, but the cache write is still the one genuine poisoning vector the rule describes, and it buys little on a rare release build that the LTO link dominates. Removed. The remaining alert on the gate job has no cache usage at all and mirrors the two open alerts on release-image.yml (#16, #17): the rule matches any checkout-and-execute of a resolved SHA under workflow_dispatch.
rlunar pushed a commit
to rlunar/extenddb
that referenced
this pull request
Aug 20, 2026
CodeQL (actions/cache-poisoning/poisonable-step) flags writing the default branch's actions cache from a job that checks out a dispatch-resolved SHA. The gate proves that SHA is an ancestor of origin/main, so the checkout is reviewed history, but the cache write is still the one genuine poisoning vector the rule describes, and it buys little on a rare release build that the LTO link dominates. Removed. The remaining alert on the gate job has no cache usage at all and mirrors the two open alerts on release-image.yml (ExtendDB#16, ExtendDB#17): the rule matches any checkout-and-execute of a resolved SHA under workflow_dispatch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation error messages now match DynamoDB's exact format. Conformance suite improves from 467/576 (81.1%) to 479/576 (83.2%).
Changes
Formatter functions: Added
validation_error(value, field, constraint)andvalidation_errors(errors)incrates/core/src/error/messages.rsthat produce DynamoDB's exact format:"1 validation error detected: Value '{value}' at '{field}' failed to satisfy constraint: {constraint}".Table name validation: Split too-short/too-long into separate checks that include the actual value and field path in the message.
KeySchema validation: >2 elements now serializes the array in
KeySchemaElement(attributeName=..., keyType=...)format matching DynamoDB's Java toString output.TransactGetItems/TransactWriteItems: Empty list returns
"Value '[]'"with"greater than or equal to 1"constraint. Exceeding 100 items includes the serialized list value.BatchGetItem: Per-table >100 keys check added with correct field path
"RequestItems.{table}.member.Keys".BatchWriteItem: >25 items includes the map value representation matching DynamoDB's format.
Testing
cargo test --workspaceall passFiles changed (7)
crates/core/src/error/messages.rs—validation_error(),validation_errors()formatterscrates/core/src/error/mod.rs— export new functionscrates/core/src/validation/mod.rs— table name + key schema messages,format_key_schema_valuehelpercrates/engine/src/batch_get_item.rs— per-table key count check with correct messagecrates/engine/src/batch_write_item.rs— >25 items message with map valuecrates/engine/src/transact_get_items.rs— empty/too-many messagescrates/engine/src/transact_write_items.rs— empty/too-many messages