Uh oh!
There was an error while loading. Please reload this page.
chore(npm): bump launcher manifest to 0.1.8 with the workspace version - #299
Merged
Conversation
The npm-publish gate compares main's packaging/npm/package.json against the dispatched tag and Cargo.toml at the tag. #298 bumped the workspace and cut v0.1.8 but left the launcher manifest at 0.1.7, so the gate refused the dispatch (correctly). optionalDependencies pins move in lockstep; the publish step rewrites them, the checked-in values exist so the manifest never misleads a reader.
LeeroyHannigan
requested review from
amrith, c33howard, jcshepherd, pdf-amzn, robinnsc and yesyayen
as code ownersAugust 21, 2026 19:00
robinnsc
approved these changes
Aug 21, 2026
robinnsc
left a comment
Collaborator
There was a problem hiding this comment.
Exactly right, and my miss to own: #298 swept Cargo + both notices files but not the launcher manifest that #258 had just added — the bump checklist grew a file and I didn't notice. The npm-publish gate refusing at dispatch is the machinery working, but it's still the release-blocked-after-merge shape, so I'm sending a follow-up PR-time check (Cargo.toml ↔ packaging/npm/package.json version equality, path-filtered) so the next bump can't merge incomplete — same treatment the notices got after #272. Approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
One file:
packaging/npm/package.jsonmoves 0.1.7 -> 0.1.8 (versionplus the fiveoptionalDependenciespins, which move in lockstep).Why
The npm-publish gate refused the v0.1.8 dispatch:
That refusal is correct: #298 bumped the workspace and cut v0.1.8, but the launcher manifest was not bumped with it. The publish step rewrites versions at publish time either way; the checked-in value exists so the manifest never misleads a reader, which is exactly the drift the gate exists to catch.
After this merges, re-dispatch
npm-publishwithtag=v0.1.8.