Uh oh!
There was an error while loading. Please reload this page.
ci(actions): bounded settle window on post-copy assertions - #300
Merged
Conversation
ECR Public exhibits read-after-write lag: the v0.1.8 dev propagation's signature copy visibly succeeded in its own log, the immediate post-copy probe reported the tag missing, and the artifact was present seconds later (also observed manually during the v0.1.6 promotion). Post-WRITE assertions in both composite actions now retry for up to ~30s before failing closed; state DECISIONS (exists/absent, verify-before-tag) remain strict single probes — retrying those would reintroduce the fail-open class.
robinnsc
requested review from
LeeroyHannigan, amrith, c33howard, jcshepherd, pdf-amzn and yesyayen
as code ownersAugust 21, 2026 19:14
The first commit only carried copy-artifact — this is the action the failing dev propagation actually runs. Same bounded post-write settle (sig copy assertion + final verification loop); decision probes unchanged.
LeeroyHannigan
approved these changes
Aug 21, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Post-write assertions in
promote-registryandcopy-artifactnow retry for up to ~30s (6 × 5s) before failing closed. State decisions — exists/absent classification, verify-before-tag — remain strict single probes; retrying those would reintroduce the fail-open class from the #283 review.Why
Live failure on the v0.1.8 dev propagation (run 32514590435): the ECR signature copy's own log shows the manifest written, the immediate post-copy probe reported it missing, and the artifact was verifiably present minutes later (
crane digestconfirms it now) — ECR Public read-after-write lag, also observed manually during the v0.1.6 promotion. Because the action correctly signs-first, it died before copying the version tags, leaving ECR with a signature and no0.1.8/latest.Urgency: the postgres v0.1.8 propagate job (pending behind its publish approval) asserts the same way against ECR and would likely hit the identical failure.
Testing done
yaml.safe_loadpasses on both actions.Checklist
ADR / RFC: n/a — CI tooling only.
Breaking changes
None.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache License 2.0 and I agree to the Developer Certificate of Origin (DCO). See CONTRIBUTING.md for details.