feat: add _iter_all_traces helper and rewrite manipulation notebook - #18
Conversation
def _iter_all_traces(fig: go.Figure) -> Iterator: """Iterate over all traces in a figure, including animation frames. Yields traces from fig.data first, then from each frame in fig.frames. Useful for applying styling to all traces including those in animations. """ yield from fig.data for frame in fig.frames or []: yield from frame.data Refactored update_traces to use it (simpler now - removed the separate fig.update_traces() call): for trace in _iter_all_traces(fig): if selector is None: trace.update(**kwargs) else: if all(getattr(trace, k, None) == v for k, v in selector.items()): trace.update(**kwargs) The helper can now be reused internally wherever trace iteration including animation frames is needed.
📝 WalkthroughWalkthroughThe pull request refactors a documentation notebook to demonstrate xarray-plotly with a 4D dataset example while introducing a centralized helper function for iterating over traces across animation frames, replacing duplicated iteration logic. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Uh oh!
There was an error while loading. Please reload this page.
Summary
_iter_all_traces(fig)helper to iterate over all traces including animation framesupdate_traces()and_style_traces_as_bars()to use the new helpermanipulation.ipynbto usexpx()with a 4D DataArray demonstrating:facet_col/facet_rowupdate_tracessolution🤖 Generated with Claude Code
Summary by CodeRabbit
Documentation
Refactor
✏️ Tip: You can customize this high-level summary in your review settings.