Performance improvements for transformations - #69
Merged
Merged
Conversation
If we determine that two expressions are equal, we can DAGify by replacing the operands of one with the operands of the other. This significantly speeds up traversals for complex forms that have many equal sub-terms.
This will help reuse of transformed traversals when the same mapping function is applied multiple times. This occurs, for example, in the dispatching for derivatives in apply_derivatives.
dham
approved these changes
Oct 14, 2021
wence-
added a commit
to firedrakeproject/firedrake
that referenced
this pull request
Oct 14, 2021
Contributor
Author
|
Firedrake test suit is happy. @michalhabera, @IgorBaratta Since this makes some fairly core changes to the visitor mapping, can you check that fenicsx is happy? |
Member
Dolfinx and ffcx seem happy. All tests are green on CI, using this branch. |
Contributor
Author
Thanks. I'm reasonably happy to merge, but you may wish to look over the changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does two things:
map_expr_dagsto reuse the result cache across calls. This makes a big difference in applying restrictions and derivatives, which have a dispatch rule that callsmap_expr_dagthat previously would not cache across calls into subtrees.I am pretty sure that they are correct, but will run the Firedrake test suite to check for regressions.
Representative timing data for the below script
Before:
After eager DAGifying:
Reusing caches in apply restrictions
With all changes: