chore: record the project's own licence in the lockfile - #5
Merged
Merged
Conversation
package.json and LICENSE both say MIT; the lockfile still carried npm's ISC default from before the licence was chosen. npm reconciles the two on its own, so every npm install rewrote package-lock.json and left the working tree dirty for no reason - the same false signal the audit suite was just cured of. Regenerated with npm install --package-lock-only. One line, npm's own output, no dependency resolution changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
package.jsonandLICENSEboth say MIT.package-lock.jsonstill carried npm'sISCdefault from before the licence was chosen, so npm reconciled the two on every run and
rewrote the lockfile — leaving the working tree dirty for no reason.
That is the same false signal the audit suite was just cured of in #2 and #4: a tracked
file that changes by itself when you run an ordinary command teaches you to ignore a dirty
tree, which is exactly what the evidence chain relies on you not doing.
The change
One line, produced by
npm install --package-lock-onlyrather than edited by hand:"": { "name": "filepass", "version": "0.1.0", - "license": "ISC", + "license": "MIT",Only the root package entry changes. No dependency, version, integrity hash or resolved
URL is touched, and the ~180
licensefields belonging to dependencies are untouched.Evidence
tsc --noEmitvite buildnpm audit --audit-level=highgit diff --checknpm ciagainst the corrected lockfilenpm installon the committed tree, thengit status --porcelainThe last row is the point of the PR: before, that command left
package-lock.jsonmodified.Merge gate
Full product and audit suites pass, and
npm installon the committed tree leavesgit status --porcelainempty.No product, parser, verification or test logic is touched. No tag, release or deploy
proposed.
🤖 Generated with Claude Code