Skip to content

Support zsh in call_host.sh - #42

Merged
kpedro88 merged 8 commits into
FNALLPC:masterfrom
clelange:zsh_call_host
Jan 6, 2026
Merged

Support zsh in call_host.sh#42
kpedro88 merged 8 commits into
FNALLPC:masterfrom
clelange:zsh_call_host

Conversation

@clelange

Copy link
Copy Markdown
Contributor

I'm using zsh for most of my work, which is currently not supported by the call_host.sh script. I've made it work by identifying the bash-specific parts and changing those to functions. I've also introduced a function to identify if zsh is used and another one to prevent duplicating the bind paths when accidentally sourcing the call_host.sh script more than once.

@kpedro88

Copy link
Copy Markdown
Contributor

@clelange thanks for this contribution! tagging @NJManganelli here because he had also expressed interest in zsh support.

I won't have time to review this in depth until next week, but I wanted to acknowledge receipt.

@kpedro88

Copy link
Copy Markdown
Contributor

In the meantime, you can try to placate shellcheck...

@NJManganelli

Copy link
Copy Markdown

I had hacked together a minimal translation and had no time to clean it up, but even at a glance this is better and more functional. I can hopefully test it as a replacement for my hacked version later

@clelange

Copy link
Copy Markdown
ContributorAuthor

In the meantime, you can try to placate shellcheck...

This should be OK now.

Comment threadcall_host.sh Outdated
Comment threadcall_host.sh
Comment threadcall_host.sh Outdated
Comment threadcall_host.sh Outdated
Comment threadcall_host.sh Outdated
Comment threadcall_host.sh Outdated
Comment threadcall_host.sh Outdated
Comment threadcall_host.sh Outdated
Comment threadcall_host.sh
@clelange

Copy link
Copy Markdown
ContributorAuthor

Thanks for the careful review. I'm not sure I'll be able to address everything this week, but if not, I'll pick this up in the second half of next week.

@kpedro88

Copy link
Copy Markdown
Contributor

@clelange just checking on this

@clelange

Copy link
Copy Markdown
ContributorAuthor

Hey, yes, it's on my list but I haven't managed to get back to it yet.

@clelange

Copy link
Copy Markdown
ContributorAuthor

I hope I have managed to address all suggestions @kpedro88

@kpedro88

Copy link
Copy Markdown
Contributor

@clelange everything looks good except the one remaining eval that still seems unnecessary to me

@clelange

Copy link
Copy Markdown
ContributorAuthor

You're right, I've fixed that and gave it another pass, which led to another grep-related fix of a bug that I had introduced.

@kpedro88
kpedro88 merged commit 38a9e06 into FNALLPC:masterJan 6, 2026
2 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@clelange@kpedro88@NJManganelli