Uh oh!
There was an error while loading. Please reload this page.
feat(raptor-register): a raptor action to replace facetsctl-register - #15
Open
anujhydrabadi wants to merge 2 commits into
Open
feat(raptor-register): a raptor action to replace facetsctl-register#15anujhydrabadi wants to merge 2 commits into
anujhydrabadi wants to merge 2 commits into
Conversation
facetsctl-register is a Docker action on facetscloud/facetsctl:latest that runs facetsctl v2 — the legacy write path, which registers a build with no routing rule attached. It also reads secrets.* from inside the action, which is not a context an action can read, so its credentials arrive empty: it is deprecated here rather than fixed. raptor-register is a composite action, because raptor publishes no image. It takes the target explicitly — git_ref to let the project's routing rules place the build, or environment / release_stream to name the target outright — and fails when zero or more than one is set, rather than picking for the caller. Two things it does not inherit: - Credentials are inputs, not an implicit read of secrets.*. The caller passes them, and they are scoped to the single step that invokes raptor, so the token is not exported into the rest of the caller's job. - `registration_type`, `registry` and `description` are gone. The first is implied by which target input you pass; the second is wherever you pushed, which `image` already names; the third is not carried on a build registration. The README maps every old input to its replacement, and says where to read an artifact name from — it is the CI integration, not the resource, and the two differ often enough to be worth stating. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
A build registered without its registry lands under "provided". A resource that
asks for its image as spec.release.build {name, artifactory} then finds nothing,
because the module resolves that shape as all_artifactories[registry][name], and
it deploys the literal string "NOT_FOUND". The pod sits in InvalidImageName, and
nothing failed earlier to warn anyone. control-plane hit exactly this in
facetsdemo.
The action now takes a `registry` input and passes it to `set artifact-uri`, which
needs raptor v0.1.98 or later (raptor#373). The input is optional, because a
resource that uses the artifact-expression shape does not need it.
The migration table also stops telling readers to drop facetsctl's `registry`
input. That was wrong: the flag is load-bearing for one of the two shapes.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
facetsctl-registeris a Docker action ondocker://facetscloud/facetsctl:latestrunning facetsctl v2 — the legacy write path, which registers a build with no routing rule attached. It is also broken as written: it readssecrets.*from inside the action, which is not a context an action can read, so its credentials arrive empty. It is deprecated here rather than fixed.raptor-registeris a composite action — raptor publishes no image, so there is nothing to run a Docker action on.The target is explicit
git_reflets the project's routing rules place the build;environmentandrelease_streamname the target outright. Exactly one is required — zero or two is an error, not something the action picks for the caller.Two things it does not inherit
secrets.*, and they are scoped to the single step that invokes raptor — so the token is not exported into the rest of the caller's job. (Same pattern asmodule-ci-action.)registration_type,registryanddescriptionare gone. The first is implied by which target input you pass; the second is wherever you pushed, whichimagealready names; the third is not carried on a build registration.The README maps every old input to its replacement, and says where to read an artifact name from — it is the CI integration, not the resource, and the two differ often enough to be worth stating (
raptor get resources -p <project> -o wide, the ARTIFACT column).Part of the facetsctl retirement.
🤖 Generated with Claude Code