Skip to content

Align C# Copilot LSP convention with upstream dotnet skills config - #74

Merged
bgrainger merged 1 commit into
masterfrom
copilot/update-conventions-copilot-lsp-csharp
Jul 13, 2026
Merged

Align C# Copilot LSP convention with upstream dotnet skills config#74
bgrainger merged 1 commit into
masterfrom
copilot/update-conventions-copilot-lsp-csharp

Conversation

CopilotAI commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

The C# Copilot LSP convention had drifted from the upstream dotnet/skills configuration, so the published server definition no longer matched the current C# language server setup.

  • Summary

    • Sync the convention with the upstream csharp LSP server definition from https://github.com/dotnet/skills/blob/main/plugins/dotnet/lsp.json.
    • Keep the convention’s behavior aligned with the current dotnet plugin expectations for C# editing.
  • What changed

    • Updated conventions/copilot-lsp-csharp/convention.yml to mirror the upstream server configuration, including the current argument ordering, cwd, and warmupTimeoutMs.
    • Updated the C# file-extension mappings to use the upstream Razor-aware behavior for .razor and .cshtml.
    • Refreshed conventions/copilot-lsp-csharp/README.md so the documented behavior matches the published configuration.

@bgrainger

Copy link
Copy Markdown
Member

I don't know if cwd and warmupTimeoutMs are supported (with this YAML syntax) or not.

@ejball

Copy link
Copy Markdown
Member

Ready to merge?

@bgrainger

Copy link
Copy Markdown
Member

Yes, ready to merge. (I have not tested, in case there are concerns about those YAML keys. If you think it's 100% safe, merge away!)

@ejball

Copy link
Copy Markdown
Member

If you think it's 100% safe, merge away!

🤷‍♂️ I don't use Copilot CLI.

@bgrainger
bgrainger merged commit fad379c into masterJul 13, 2026
5 checks passed
@bgrainger
bgrainger deleted the copilot/update-conventions-copilot-lsp-csharp branch July 13, 2026 21:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@bgrainger@ejball