Skip to content

Re-brand the mermaid execution plan (--plan) - #382

Merged
dennisdoomen merged 1 commit into
Fallout-build:mainfrom
ITaluone:maint/rebrand-mermaid-plan
Jun 19, 2026
Merged

Re-brand the mermaid execution plan (--plan)#382
dennisdoomen merged 1 commit into
Fallout-build:mainfrom
ITaluone:maint/rebrand-mermaid-plan

Conversation

@ITaluone

@ITaluoneITaluone commented Jun 12, 2026

Copy link
Copy Markdown
Contributor
Screenshots
image
image

Closes: #380

I confirm that the pull-request:

  • Follows the contribution guidelines
  • Is based on my own work
  • Is in compliance with my employer

Merge preference: (x) squash (default) ( ) rebase

@ITaluone
ITaluone requested a review from a team as a code ownerJune 12, 2026 06:51
@ITaluone
ITaluoneforce-pushed the maint/rebrand-mermaid-plan branch from cff244f to 4dc9ffeCompareJune 12, 2026 06:55
@ChrisonSimtian

Copy link
Copy Markdown
Collaborator

good catch, I was about to tackle that one tonight too :D

Comment threadsrc/Fallout.Build.Shared/Constants.cs

@ChrisonSimtianChrisonSimtian left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for sorting this out!
If you're keen, I'd like to get that into 10.x as well, wanna cherry pick and merge that into support/v10?

@ChrisonSimtianChrisonSimtian added bug Something isn't working target/vCurrent Targets the current version labels Jun 12, 2026
@dennisdoomen

Copy link
Copy Markdown
Collaborator

If you're keen, I'd like to get that into 10.x as well, wanna cherry pick and merge that into support/v10?

Wait, main = v10, right? It is the version (mostly) backwards compatible with Nuke.

@ITaluone
ITaluoneforce-pushed the maint/rebrand-mermaid-plan branch from 4dc9ffe to c5441a3CompareJune 15, 2026 12:12
@ChrisonSimtian

Copy link
Copy Markdown
Collaborator

If you're keen, I'd like to get that into 10.x as well, wanna cherry pick and merge that into support/v10?

Wait, main = v10, right? It is the version (mostly) backwards compatible with Nuke.

yes it is :-)

@ITaluone do you want to merge this? Or do you want me to? Happy to take this onboard and build a release at some point. Im also working on IDE extensions, so would be cool to have this in main before those land :-)

@ChrisonSimtianChrisonSimtian added Can Merge These PRs are just waiting to be merged, nothing more to do and maintainer has approved and removed target/vCurrent Targets the current version labels Jun 18, 2026
@ITaluone

Copy link
Copy Markdown
ContributorAuthor

@ITaluone do you want to merge this?

I don't get it? I cannot merge 🤷‍♂️

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugSomething isn't workingCan MergeThese PRs are just waiting to be merged, nothing more to do and maintainer has approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Execution-plan HTML (--plan) still shows NUKE branding and links to the dead nuke.build site

3 participants

@ITaluone@ChrisonSimtian@dennisdoomen