Uh oh!
There was an error while loading. Please reload this page.
Introduce IFalloutCommand dispatch with DI for Fallout.Cli (#392, PR 0) - #448
Merged
ChrisonSimtian merged 4 commits intoJul 2, 2026
Conversation
ChrisonSimtian
marked this pull request as ready for review
June 30, 2026 09:03
This was referenced Jun 30, 2026
ChrisonSimtian
commented
Jun 30, 2026
CollaboratorAuthor
Follow-up PRs to be raised (part of #392) This is PR 0 of a sequential cross-fork series. The remaining commands are staged on the fork and will be raised here one at a time, each rebased onto
Supersedes the original upstream stack #394–#404 (now closed; re-raised from the fork). |
dennisdoomen
approved these changes
Jun 30, 2026
dennisdoomen
left a comment
Collaborator
There was a problem hiding this comment.
As everything is internal, it's easy to change if we find the new abstraction isn't enough.
Some suggestions on the coding conventions/naming.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
IT-VBFK
approved these changes
Jun 30, 2026
Uh oh!
There was an error while loading. Please reload this page.
ChrisonSimtian added a commit
that referenced
this pull request
Jul 1, 2026
Address review feedback on #448: - IFalloutCommand.Execute -> Task<int> ExecuteAsync; RunCommand awaits Process.WaitForExitAsync; DelegateCommand adapts the still-sync legacy handlers via Task.FromResult; CommandDispatcher.DispatchAsync and Main become async. No behavior change and no public-API break (Fallout.Cli is the tool Exe, not a consumed library). - Drop the `_` field prefix on the new types (bare field names, this. only for ctor assignment collisions). - Always brace if/for bodies in the new code. - Rename dispatcher tests to snake_case sentence names (AV1600). Fallout.Cli.Tests: 30 pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ChrisonSimtian added a commit
that referenced
this pull request
Jul 1, 2026
Address review feedback on #448: - IFalloutCommand.Execute -> Task<int> ExecuteAsync; RunCommand awaits Process.WaitForExitAsync; DelegateCommand adapts the still-sync legacy handlers via Task.FromResult; CommandDispatcher.DispatchAsync and Main become async. No behavior change and no public-API break (Fallout.Cli is the tool Exe, not a consumed library). - Drop the `_` field prefix on the new types (bare field names, this. only for ctor assignment collisions). - Always brace if/for bodies in the new code. - Rename dispatcher tests to snake_case sentence names (AV1600). Fallout.Cli.Tests: 30 pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ChrisonSimtian added a commit
that referenced
this pull request
Jul 1, 2026
Address review feedback on #448: - IFalloutCommand.Execute -> Task<int> ExecuteAsync; RunCommand awaits Process.WaitForExitAsync; DelegateCommand adapts the still-sync legacy handlers via Task.FromResult; CommandDispatcher.DispatchAsync and Main become async. No behavior change and no public-API break (Fallout.Cli is the tool Exe, not a consumed library). - Drop the `_` field prefix on the new types (bare field names, this. only for ctor assignment collisions). - Always brace if/for bodies in the new code. Test method names keep the MethodUnderTest_Scenario_Result style of the sibling *Specs files; a repo-wide test-naming convention is left to a dedicated cleanup. Fallout.Cli.Specs: 30 pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ChrisonSimtianforce-pushed
the
cli-command-dispatch-foundation
branch
from
July 1, 2026 02:55
44b711c to
99d3428CompareReplace the reflection-over-Program command dispatch (the partial god-class described in Fallout-build#392) with a typed command abstraction resolved through Microsoft.Extensions.DependencyInjection. This is the foundation PR: it lands the abstraction, the dispatcher, the prompt service, and the first real command conversion, with the remaining handlers converted one per follow-up PR. - Add public IFalloutCommand (Name + Execute) and a CommandDispatcher that resolves by name, dash- and case-insensitively, preserving every spelling the old reflection accepted (:add-package == :addpackage, :PopDirectory, ...). - Move the Spectre prompt/render helpers off Program into an injectable IConsolePrompts / SpectreConsolePrompts (namespace Fallout.Cli.Prompts to avoid colliding with System.Console). Program keeps thin static delegators so the not-yet-extracted handlers compile; the last conversion deletes them. - Convert Run into a real RunCommand type; delete Program.Run.cs. - Adapt the 13 still-legacy handlers via a transitional DelegateCommand so the registry and dispatch are uniform from day one. Each future PR deletes one registration line plus its Program.X.cs partial. - Delete the reflection dispatch and its "add assertions about return type and parameters" TODO; typed commands make signature-mismatch dispatch impossible. - Add CommandDispatcherTests (first-ever dispatch coverage): name matching, dash/case insensitivity, exit-code passthrough, unknown-command listing, empty token, and all default-routing branches. - Add .vscode launch/build tasks for debugging the global tool from source. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Bump the cross-command helpers (GetConfiguration(buildScript, evaluate), AddOrReplacePackage, WriteBuildScripts, WriteConfigurationFile, GetTemplate, PrintInfo, CurrentBuildScriptName, BUILD_PROJECT_FILE) from private to internal so the per-command IFalloutCommand types extracted in the Fallout-build#392 follow-up PRs can call them during the transition. These move into dedicated services in the final collapse PR; this is the minimal enabler that lets each command be converted in an independent, conflict-free PR. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
we currently dont plan to expose any of those, so we can make these internal. If we need to expose those inside of fallout, we can do so with `<InternalsVisibleTo/>` or at some point make a conscious decision to publish those interfaces for wider, public use Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Address review feedback on Fallout-build#448: - IFalloutCommand.Execute -> Task<int> ExecuteAsync; RunCommand awaits Process.WaitForExitAsync; DelegateCommand adapts the still-sync legacy handlers via Task.FromResult; CommandDispatcher.DispatchAsync and Main become async. No behavior change and no public-API break (Fallout.Cli is the tool Exe, not a consumed library). - Drop the `_` field prefix on the new types (bare field names, this. only for ctor assignment collisions). - Always brace if/for bodies in the new code. Test method names keep the MethodUnderTest_Scenario_Result style of the sibling *Specs files; a repo-wide test-naming convention is left to a dedicated cleanup. Fallout.Cli.Specs: 30 pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ChrisonSimtianforce-pushed
the
cli-command-dispatch-foundation
branch
from
July 1, 2026 21:18
99d3428 to
a1e9c8fCompareUh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the reflection-over-
ProgramCLI dispatch with one-command-per-type behind a typedIFalloutCommand, resolved via Microsoft.Extensions.DependencyInjection. PR 0 of an incremental series — lands the abstraction, dispatcher, and first conversion; a transitional adapter keeps the other 13 handlers working so nothing regresses.What changed
IFalloutCommand+CommandDispatcherreplaceProgram.Handle; resolution stays dash/case-insensitive (every spelling the old reflection accepted).IConsolePrompts/SpectreConsolePrompts— Spectre prompt helpers lifted offPrograminto an injectable service.RunCommand— first real conversion.DelegateCommandadapts the 13 still-legacy handlers so dispatch is uniform; each follow-up PR deletes one.CommandDispatcherTestsadd first dispatch coverage.Why it's not breaking
Fallout.Cliis the tool Exe, not a consumed library; the:commandsurface and shell-function names are preserved exactly. Hencetarget/2026/main, nobreaking-changelabel.Verification
dotnet build src/Fallout.Cliclean ·Fallout.Cli.Tests30 pass ·fallout :bogusprints the full command manifest.Follow-ups (#392): setup · update · add-package · cake-convert/clean · complete · get-configuration · secrets · trigger · navigation → then collapse
Programto a thin entry point. Raised sequentially off this branch as it lands.Part of #392.
Re-raised from the fork (
ChrisonSimtian:cli-command-dispatch-foundation) to move the branch off the main repo. Supersedes #394; same history and diff. Bottom of the cli-cmd stack — follow-ups open one at a time as each merges.🤖 Generated with Claude Code