Skip to content

Add ClickOnce settings definition for MSBuild - #466

Merged
ITaluone merged 2 commits into
Fallout-build:mainfrom
ITaluone:feat/clickonce-settings-msbuild
Jul 7, 2026
Merged

Add ClickOnce settings definition for MSBuild#466
ITaluone merged 2 commits into
Fallout-build:mainfrom
ITaluone:feat/clickonce-settings-msbuild

Conversation

@ITaluone

Copy link
Copy Markdown
Contributor

Quick win, + need it for myself: nuke-build/nuke#1546

@ITaluone
ITaluone requested a review from a team as a code ownerJuly 3, 2026 09:00
Comment threadsrc/Fallout.Common/Tools/MSBuild/MSBuild.json
@ChrisonSimtianChrisonSimtian added the Can Merge These PRs are just waiting to be merged, nothing more to do and maintainer has approved label Jul 4, 2026
dennisdoomen
dennisdoomen previously requested changes Jul 4, 2026
Comment threadsrc/Fallout.Common/Tools/MSBuild/MSBuild.json
Comment threadsrc/Fallout.Common/Tools/MSBuild/MSBuild.json
@ITaluone
ITaluoneforce-pushed the feat/clickonce-settings-msbuild branch from 69a3543 to 1075685CompareJuly 5, 2026 13:21
Comment threadsrc/Fallout.Common/Tools/MSBuild/MSBuild.json Outdated
@ITaluone
ITaluoneforce-pushed the feat/clickonce-settings-msbuild branch from 1075685 to 0a2b9ebCompareJuly 6, 2026 05:27
@ChrisonSimtianChrisonSimtian removed the Can Merge These PRs are just waiting to be merged, nothing more to do and maintainer has approved label Jul 7, 2026
@ChrisonSimtian
ChrisonSimtian self-requested a review July 7, 2026 09:44
@ChrisonSimtian
ChrisonSimtian dismissed dennisdoomen’s stale reviewJuly 7, 2026 09:46

Changes have been made now, dismissing the change request

@ChrisonSimtianChrisonSimtian left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ITaluone good to go :-) Thanks for adding the help bits as well

@ChrisonSimtianChrisonSimtian added the Can Merge These PRs are just waiting to be merged, nothing more to do and maintainer has approved label Jul 7, 2026
@ITaluone

Copy link
Copy Markdown
ContributorAuthor

Should this wait for @dennisdoomen ?

@ITaluone
ITaluoneforce-pushed the feat/clickonce-settings-msbuild branch from 0a2b9eb to 846bb4fCompareJuly 7, 2026 09:51
@ITaluone
ITaluone enabled auto-merge (rebase) July 7, 2026 10:16
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Can MergeThese PRs are just waiting to be merged, nothing more to do and maintainer has approvedenhancementNew feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ITaluone@dennisdoomen@ChrisonSimtian