Uh oh!
There was an error while loading. Please reload this page.
Relax DotNetTasks diagnostic ID log level patterns to reduce false negatives - #467
Merged
dennisdoomen merged 1 commit intoJul 4, 2026
Conversation
ITaluone
approved these changes
Jul 3, 2026
ITaluone
left a comment
Contributor
There was a problem hiding this comment.
Thanks for your contribution.
Just a small question to consider.
Uh oh!
There was an error while loading. Please reload this page.
ChrisonSimtian
approved these changes
Jul 4, 2026
dennisdoomen
approved these changes
Jul 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Current Diagnostic ID LogLevelPattern only allows up to 5 letters in the prefix, for example SYSLIB and and VSTHRD diagnostic ids aren't being picked up.
Diagnostic ID guidelines only suggest a
<PREFIX><number>format and a 15 character limit.What was done
DotNetTasks.cs LogLevelPattern was changed from
\w{2,5}\d{1,5}to\w{2,}\d+for both error and warning.This removes the upper limit of 5 characters for the prefix and the number.
Relevant Issue nuke-build/nuke#1559