Skip to content

Add tool wrapper definition for Stryker - #503

Merged
dennisdoomen merged 2 commits into
Fallout-build:mainfrom
IT-VBFK:feat/tools/stryker
Jul 20, 2026
Merged

Add tool wrapper definition for Stryker#503
dennisdoomen merged 2 commits into
Fallout-build:mainfrom
IT-VBFK:feat/tools/stryker

Conversation

@IT-VBFK

@IT-VBFKIT-VBFK commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

@IT-VBFK
IT-VBFK requested a review from a team as a code ownerJuly 17, 2026 17:27
@IT-VBFK
IT-VBFKforce-pushed the feat/tools/stryker branch from 01a4ea9 to b47b125CompareJuly 17, 2026 17:44
@ITaluoneITaluone added enhancement New feature or request target/vCurrent Targets the current version labels Jul 17, 2026

@dennisdoomendennisdoomen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛏🤖 Nitpick: BreakAt is typed uint, but ThresholdHigh/ThresholdLow are typed short, even though all three represent the same 0-100 mutation-score concept and map to the same int? type upstream in Stryker (ThresholdBreakInput, ThresholdHighInput, ThresholdLowInput). Suggest using one consistent numeric type across all three.

❓🤖 Question: the wrapper omits several newer Stryker CLI options that exist in current stryker-net master (CommandLineConfigReader.cs): with-baseline, test-runner, diag, azure-fileshare-sas, s3-bucket-name, s3-endpoint, s3-region. Was this a deliberate scope match with the upstream NUKE PR (nuke-build/nuke#1259), or should these be added now?

@IT-VBFK

Copy link
Copy Markdown
ContributorAuthor

Thanks for review

I "just" took the definitions form the original PR

Will add them (or let them add 🤖)

@IT-VBFK
IT-VBFKforce-pushed the feat/tools/stryker branch 2 times, most recently from 0e9348f to 8a5fafaCompareJuly 18, 2026 20:50
@IT-VBFK
IT-VBFKforce-pushed the feat/tools/stryker branch from 8a5fafa to eabcf8dCompareJuly 18, 2026 21:03
@IT-VBFK

IT-VBFK commented Jul 18, 2026

Copy link
Copy Markdown
ContributorAuthor

⛏🤖 Nitpick: BreakAt is typed uint, but ThresholdHigh/ThresholdLow are typed short, even though all three represent the same 0-100 mutation-score concept and map to the same int? type upstream in Stryker (ThresholdBreakInput, ThresholdHighInput, ThresholdLowInput). Suggest using one consistent numeric type across all three.

Used uint since other numbers also use uint

❓🤖 Question: the wrapper omits several newer Stryker CLI options that exist in current stryker-net master (CommandLineConfigReader.cs): with-baseline, test-runner, diag, azure-fileshare-sas, s3-bucket-name, s3-endpoint, s3-region. Was this a deliberate scope match with the upstream NUKE PR (nuke-build/nuke#1259), or should these be added now?

Added them now since there were easy :)

@IT-VBFK
IT-VBFKforce-pushed the feat/tools/stryker branch from eabcf8d to 22c3072CompareJuly 19, 2026 10:11

@ChrisonSimtianChrisonSimtian left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but lets slow down a bit on adding new tools to the mix :-)
I'd longterm like to break those out into their own little spaces so that people can expand Fallout as they need, without making the core too heavy ;-)

@ChrisonSimtianChrisonSimtian added the Can Merge These PRs are just waiting to be merged, nothing more to do and maintainer has approved label Jul 19, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Can MergeThese PRs are just waiting to be merged, nothing more to do and maintainer has approvedenhancementNew feature or requesttarget/vCurrentTargets the current version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@IT-VBFK@dennisdoomen@ChrisonSimtian@ITaluone