fix(extract): derive compile identity from hwids[0] when build.vid/pid absent

[zackees]

PlatformIO platform builders fall back to build.hwids[0] for USB_VID/USB_PID when a board manifest has no explicit build.vid/build.pid — atmelsam is the canonical case. The extractor only honored explicit keys, so every hwids-only manifest published primary_compile_identity: null.

Consequence downstream: FastLED/fbuild#1061 made fbuild source USB_VID/USB_PID exclusively from this registry, so all SAMD board builds in fbuild CI now fail with 'USB_VID' was not declared in this scope in ArduinoCore-samd USBCore.cpp (adafruit_feather_m0, zeroUSB, adafruit_qt_py_m0, adafruit_feather_m4, adafruit_grandcentral_m4 — all null in the published usb-profiles.json, verified against the live artifact; their hwids[0] values match PlatformIO's canonical manifests exactly).

This mirrors the hwids[0] fallback in _extract_platformio and tags that identity with the compile purpose so validate_profiles accepts it as primary. Explicit build.vid/build.pid still win; manifests with no USB identity still publish null; secondary hwids stay runtime-only. Follows the per-board precedent of #53/#54 but fixes the whole class.

Tests: new tests/test_extract_boards.py (hwids-only → primary; explicit keys win; no-identity stays null; full build_profiles + validate_profiles round-trip). All 17 USB/extractor tests pass; the 4 failing live-site search tests fail identically on main without this change.

After merge, the site workflow needs a workflow_dispatch (main is not a trigger branch) to republish usb-profiles.json, which heals the fbuild SAMD workflows with zero further fbuild changes.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes
  • Improved PlatformIO board detection when manifests provide USB hardware IDs without explicit build identifiers.
  • Boards can now receive a valid compile identity from available VID:PID information, improving downstream profile generation and validation.
  • Explicit build identifiers continue to take precedence, while boards without USB identity data remain unchanged.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: bfeb025d-7895-4d91-8071-60bd48eec3fa

📥 Commits

Reviewing files that changed from the base of the PR and between 7895665 and 3909e6b.

📒 Files selected for processing (2)

• builders/extract_boards.py
• tests/test_extract_boards.py

---

📝 Walkthrough

Walkthrough

PlatformIO board extraction now derives a compile identity from the first HWID VID:PID pair when explicit build identifiers are absent. Regression tests cover downstream profile preservation, explicit identifier precedence, and manifests without USB identities.

Changes

PlatformIO identity extraction

Layer / File(s)	Summary
HWID compile identity fallback builders/extract_boards.py	When build.vid and build.pid are absent, the first VID:PID pair from build.hwids is marked with the compile purpose.
Identity extraction regression coverage tests/test_extract_boards.py	Tests verify HWID-derived identities, explicit VID/PID precedence, downstream profile preservation, and null identities for manifests without USB fields.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related issues

• FastLED/boards issue 47 — The change implements HWID-based compile identity derivation for PlatformIO board profiles.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: deriving a compile identity from the first HWID when build.vid/pid are missing.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/hwids-compile-identity

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}