Uh oh!
There was an error while loading. Please reload this page.
ci: let setup-soldr float soldr binary - #1003
Conversation
📝 WalkthroughWalkthroughCI workflows across the repository are updated to use the floating ChangesUnpin setup-soldr across workflows
Estimated code review effort: 2 (Simple) | ~10 minutes probe_rs.rs NormalizedPath refactor
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
version: 0.8.0input from every setup-soldr workflow step so setup-soldr controls the soldr binary version.zackees/setup-soldr@v0.9.66tozackees/setup-soldr@v0;v0currently points at setup-soldrmain, whose action default is soldr0.8.0without a repo-local binary pin.soldr 0.8.0assertion to a smoke check thatsoldr --versionreturns a soldr version string.ban_std_pathbufgate that was blocking this PR on currentmain.Closes#997
Validation
gh api repos/zackees/setup-soldr/git/refs/tags/v0 --jq '.object.sha'matchesgh api repos/zackees/setup-soldr/commits/main --jq '.sha'(18b1e0f546c53837320e472325ea695bab96f091).rg -n -F 'zackees/setup-soldr@v0.9.66' .github cireturned no matches.rg -n -F 'version: "0.8.0"' .github cireturned no matches.rg -n -F 'test "$version" = "soldr' .github cireturned no matches.rg -n 'PathBuf' crates/fbuild-deploy/src/probe_rs.rsreturned no matches.git diff --checkuv run --no-project python ci/render_workflows.py --checksoldr cargo fmt --checkSummary by CodeRabbit