Uh oh!
There was an error while loading. Please reload this page.
refactor(deploy): consume FastLED/boards USB profiles - #1060
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughDeploy-port selection and LPC-Link2, Probe-RS, and Teensy discovery now use FastLED/boards USB profile metadata instead of fixed VID/PID heuristics. Board identifiers flow into deployment matching, DFU selectors are explicit, and related tests and audit documentation were updated. ChangesUSB profile matching migration
Possibly related issues
Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Closes the remaining deploy-consumer rows in #1047 and #1049.\n\n- automatic deploy-port selection uses board membership and typed runtime profiles instead of embedded vendor lists\n- missing profiles fail closed instead of choosing an unrelated COM port\n- RP2040/RP2350 generation selection uses runtime profile family metadata\n- Teensy CDC, NXP probe discovery, and LPC-Link2 factory-firmware detection use typed purpose/role/platform/family/generation metadata\n- dfu-util argv construction requires a caller-supplied registry selector\n- exact identities remain test-only fixtures\n\nDepends on FastLED/boards#52 for the split LPC-Link2 semantics.\n\nValidation:\n- fbuild-daemon deploy_port: 8 passed\n- fbuild-deploy: 169 passed, 8 hardware tests ignored\n- strict clippy for daemon/deploy passed\n- rustfmt and diff check passed\n- independent pre-push review: clean
Summary by CodeRabbit
Bug Fixes
Documentation