Skip to content

fix(ci): gate Pico reset matcher on Windows - #1305

Merged
zackees merged 1 commit into
mainfrom
fix/rp-reset-matcher-cfg
Aug 20, 2026
Merged

fix(ci): gate Pico reset matcher on Windows#1305
zackees merged 1 commit into
mainfrom
fix/rp-reset-matcher-cfg

Conversation

@zackees

Copy link
Copy Markdown
Member

Follow-up to #1304.\n\nThe Pico reset compatible-ID matcher is used only by the Windows implementation, but the merged code compiled it unconditionally. Linux and macOS -D warnings jobs therefore failed on dead code before reaching their board builds.\n\n- Compile the helper for Windows production builds and all test builds.\n- Preserve the cross-platform protocol unit test.\n\nValidation:\n- managed Linux container: soldr cargo check -p fbuild-serial --lib passed\n- managed Linux container: soldr cargo check -p fbuild-serial --tests passed\n- Windows focused matcher unit test passed\n- rustfmt and diff checks passed\n- incremental pre-push review clean

@zackees
zackees merged commit 9e2efae into mainAug 20, 2026
13 of 14 checks passed
@coderabbitai

Copy link
Copy Markdown

Warning

Review limit reached

@zackees, you've reached your PR review limit, so we couldn't start this review.

Next review available in:3 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: e4cfd6ba-914d-4278-97ef-ce815d9b2f61

📥 Commits

Reviewing files that changed from the base of the PR and between b100f0b and 2aa3ec1.

📒 Files selected for processing (1)
  • crates/fbuild-serial/src/ports.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zackees
zackees deleted the fix/rp-reset-matcher-cfg branch August 20, 2026 01:44
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant

@zackees