Uh oh!
There was an error while loading. Please reload this page.
fix(ci): gate Pico reset matcher on Windows - #1305
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Warning Review limit reached
Next review available in:3 minutes Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Follow-up to #1304.\n\nThe Pico reset compatible-ID matcher is used only by the Windows implementation, but the merged code compiled it unconditionally. Linux and macOS -D warnings jobs therefore failed on dead code before reaching their board builds.\n\n- Compile the helper for Windows production builds and all test builds.\n- Preserve the cross-platform protocol unit test.\n\nValidation:\n- managed Linux container: soldr cargo check -p fbuild-serial --lib passed\n- managed Linux container: soldr cargo check -p fbuild-serial --tests passed\n- Windows focused matcher unit test passed\n- rustfmt and diff checks passed\n- incremental pre-push review clean