Skip to content

fix(paths): avoid Windows-excluded daemon ports - #1323

Merged
zackees merged 1 commit into
mainfrom
feat/1322-windows-daemon-port
Aug 20, 2026
Merged

fix(paths): avoid Windows-excluded daemon ports#1323
zackees merged 1 commit into
mainfrom
feat/1322-windows-daemon-port

Conversation

@zackees

@zackeeszackees commented Aug 20, 2026

Copy link
Copy Markdown
Member

Summary

  • derive Windows daemon endpoints below the OS dynamic/exclusion window
  • preserve deterministic version/cache-identity isolation and explicit port overrides
  • document the platform-specific endpoint ranges in primary guidance

Validation

  • RED: Windows-focused path test derived port 57651 and failed the below-49152 contract
  • GREEN: focused test and bash test -p fbuild-paths (39 passed, 1 ignored helper)
  • rebuilt fbuild-cli + fbuild-daemon; no-override startup selected port 22265, clean sketch exited 0, status was healthy, and stop exited 0
  • bash test -p fbuild-cli (299 unit tests plus integration smoke)
  • bash test -p fbuild-daemon
  • soldr cargo fmt --all --check
  • soldr cargo clippy -p fbuild-paths --all-targets -- -D warnings
  • clud-review: clean (1 reviewer)

Fixes#1322

Summary by CodeRabbit

  • Bug Fixes

    • Improved daemon port selection on Windows by using the supported 10000–49151 range.
    • Preserved the existing 49152–65535 range on other platforms.
    • Retained support for explicit port overrides and deterministic endpoint selection.
  • Documentation

    • Clarified daemon port resolution priority and platform-specific defaults.

@zackees
zackees merged commit c2cf1bc into mainAug 20, 2026
91 of 96 checks passed
@coderabbitai

coderabbitaiBot commented Aug 20, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 35fd8c58-970f-4a2f-8116-83761e475deb

📥 Commits

Reviewing files that changed from the base of the PR and between ff9c4f7 and f2c8906.

📒 Files selected for processing (4)
  • CLAUDE.md
  • crates/CLAUDE.md
  • crates/fbuild-paths/README.md
  • crates/fbuild-paths/src/lib.rs

📝 Walkthrough

Walkthrough

The change maps deterministic daemon ports to 10000–49151 on Windows and retains 49152–65535 elsewhere. It updates port-selection documentation and adds platform-specific regression tests.

Changes

Daemon port selection

Layer / File(s)Summary
Platform-specific port derivation and validation
crates/fbuild-paths/src/lib.rs, CLAUDE.md, crates/CLAUDE.md, crates/fbuild-paths/README.md
Windows-derived daemon ports use 10000–49151. Other platforms retain 49152–65535. Tests validate the platform-specific bounds, and documentation describes the updated resolution behavior.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • FastLED/fbuild#1020: Introduced the endpoint-derived daemon port logic modified by this change.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/1322-windows-daemon-port

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

fix(paths): avoid Windows-excluded dynamic ports for daemon endpoints

1 participant

@zackees