Skip to content

chore(deps): bump zccache>=1.11.10 -> >=1.11.14 (closes #415) - #416

Merged
zackees merged 1 commit into
mainfrom
chore/bump-zccache-1.11.14
Jun 5, 2026
Merged

chore(deps): bump zccache>=1.11.10 -> >=1.11.14 (closes #415)#416
zackees merged 1 commit into
mainfrom
chore/bump-zccache-1.11.14

Conversation

@zackees

@zackeeszackees commented Jun 5, 2026

Copy link
Copy Markdown
Member

Summary

Bump pyproject pin zccache>=1.11.10>=1.11.14. Closes#415.

zccache 1.11.14 ships the meson configure --no-walk flag (zackees/zccache#660, closeszackees/zccache#659). FastLED measured the end-to-end impact in FastLED/FastLED#2761: cold-with-cache reconfigure dropped from ~5.6s (walked hit, 1.11.13) to 0.62s (no-walk hit, 1.11.14) — the ~5s difference was the wrapper walking .venv/ (~100k Python files) on every invocation.

Bumping the floor here keeps fbuild and FastLED on a consistent wrapper feature set so they can share the same install of zccache without one project silently running an older wrapper than the other.

Scope

  • pyproject.toml: zccache>=1.11.10>=1.11.14
  • uv.lock: regenerated via uv lock --refresh-package zccache --upgrade-package zccache

The zccache-artifact = "1.9" Rust crate dep in Cargo.toml is a different package (KvStore on top of zccache's content-addressed store, independent versioning) and is not affected by this PR.

Test plan

  • CI passes
  • No transitive resolution failures in uv lock

Related

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated project dependencies to ensure compatibility and stability.

zccache 1.11.14 ships the `meson configure --no-walk` flag
(zackees/zccache#660, closeszackees/zccache#659), eliminating the
recursive `--source-dir` walk that dominated the configure-cache
hit path on trees with large scratch dirs.
FastLED measured this end-to-end (FastLED/FastLED#2761): cold-with-
cache reconfigure went from ~5.6s (1.11.13, walked hit) to 0.62s
(1.11.14, no-walk hit). Bringing fbuild's published floor in line
keeps both projects on a consistent wrapper feature set.
The intermediate 1.11.11 / 1.11.12 / 1.11.13 picks (depfile-on-
cache-hit fix, the wrapper itself, `--input-file`) are also worth
floor-pinning at once rather than staircasing.
Tracker: zackees/zccache#662
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@coderabbitai

coderabbitaiBot commented Jun 5, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 90a88474-617e-4acb-9e8d-f403fb4fb58c

📥 Commits

Reviewing files that changed from the base of the PR and between 013df1e and 264ca0e.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • pyproject.toml

📝 Walkthrough

Walkthrough

This PR bumps the minimum required version of zccache in the project dependencies from >=1.11.10 to >=1.11.14 in pyproject.toml. The version constraint change aligns fbuild with the version floor needed to access the --no-walk flag introduced in zccache 1.11.14.

Changes

zccache Dependency Update

Layer / File(s)Summary
Minimum version constraint update
pyproject.toml
Dependency constraint for zccache in [project].dependencies raised from >=1.11.10 to >=1.11.14 to enable meson-configure --no-walk flag support.

Possibly related PRs

  • FastLED/fbuild#48: Both PRs modify pyproject.toml to bump the zccache minimum version in [project].dependencies.
  • FastLED/fbuild#253: Both PRs update pyproject.toml's [project].dependencies constraint for zccache with minimum version bumps.
  • FastLED/fbuild#125: Both PRs modify the pyproject.toml dependency constraint for zccache minimum version.

Poem

🐰 A version bump, so small yet grand,
zccache 1.11.14 now takes the stand!
With --no-walk the builds do fly,
From 5.6 seconds to 0.62—oh my! ✨

🎯 1 (Trivial) | ⏱️ ~2 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/bump-zccache-1.11.14

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@zackees
zackees merged commit 8716a05 into mainJun 5, 2026
84 of 85 checks passed
@coderabbitai

Copy link
Copy Markdown

Caution

Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted.

Error details
{"name":"HttpError","status":500,"request":{"method":"PATCH","url":"https://api.github.com/repos/FastLED/fbuild/issues/comments/4627283210","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/0.0.0-development octokit-core.js/7.0.6 Node.js/24","authorization":"token [REDACTED]","content-type":"application/json; charset=utf-8"},"body":{"body":"<!-- This is an auto-generated comment: summarize by coderabbit.ai -->\n<!-- review_stack_entry_start -->\n\n[![Review Change Stack](https://storage.googleapis.com/coderabbit_public_assets/review-stack-in-coderabbit-ui.svg)](https://app.coderabbit.ai/change-stack/FastLED/fbuild/pull/416?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack)\n\n<!-- review_stack_entry_end -->\n<!-- This is an auto-generated comment: review in progress by coderabbit.ai -->\n\n> [!NOTE]\n> Currently processing new changes in this PR. This may take a few minutes, please wait...\n> \n> <details>\n> <summary>⚙️ Run configuration</summary>\n> \n> **Configuration used**: Path: .coderabbit.yaml\n> \n> **Review profile**: CHILL\n> \n> **Plan**: Pro\n> \n> **Run ID**: `90a88474-617e-4acb-9e8d-f403fb4fb58c`\n> \n> </details>\n> \n> <details>\n> <summary>📥 Commits</summary>\n> \n> Reviewing files that changed from the base of the PR and between 013df1e3aa5bb37fac855c288a17011494069c08 and 264ca0e539e28d6d899bc220e7bfd3c729c594c7.\n> \n> </details>\n> \n> <details>\n> <summary>⛔ Files ignored due to path filters (1)</summary>\n> \n> * `uv.lock` is excluded by `!**/*.lock`\n> \n> </details>\n> \n> <details>\n> <summary>📒 Files selected for processing (1)</summary>\n> \n> * `pyproject.toml`\n> \n> </details>\n> \n> ```ascii\n> __________________\n> < I see dead code. >\n> ------------------\n> \\\n> \\ \\\n> \\ /\\\n> ( )\n> .( o ).\n> ```\n\n<!-- end of auto-generated comment: review in progress by coderabbit.ai -->\n\n<!-- finishing_touch_checkbox_start -->\n\n<details>\n<summary>✨ Finishing Touches</summary>\n\n<details>\n<summary>🧪 Generate unit tests (beta)</summary>\n\n- [ ] <!-- {\"checkboxId\": \"f47ac10b-58cc-4372-a567-0e02b2c3d479\", \"radioGroupId\": \"utg-output-choice-group-unknown_comment_id\"} --> Create PR with unit tests\n- [ ] <!-- {\"checkboxId\": \"6ba7b810-9dad-11d1-80b4-00c04fd430c8\", \"radioGroupId\": \"utg-output-choice-group-unknown_comment_id\"} --> Commit unit tests in branch `chore/bump-zccache-1.11.14`\n\n</details>\n\n</details>\n\n<!-- finishing_touch_checkbox_end -->\n<!-- tips_start -->\n\n---\n\nThanks for using [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=FastLED/fbuild&utm_content=416)! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.\n\n<details>\n<summary>❤️ Share</summary>\n\n- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)\n- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai)\n- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai)\n- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)\n\n</details>\n\n\n<sub>Comment `@coderabbitai help` to get the list of available commands and usage tips.</sub>\n\n<!-- tips_end -->"},"request":{"retryCount":3,"signal":{},"retries":3,"retryAfter":16}}}

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

chore(deps): bump zccache>=1.11.10 -> >=1.11.14 perf(meson): expand discovery skip-list (.venv, .cached, .cargo, .pio, .fbuild, etc.)

1 participant

@zackees