Uh oh!
There was an error while loading. Please reload this page.
feat(bloat): rename fbuild symbols to fbuild bloat - #443
Conversation
Aligns with `cargo bloat` and Google's `bloaty` — the de-facto vocabulary for per-symbol size analysis. The legacy `fbuild symbols` keeps working via clap alias for back-compat through 2.3.x; a deprecation warning lands in 2.4.0 and the alias is removed in 3.0. Also hides the `--nm` / `--cppfilt` / `--map` overrides from `--help` now that #428 populates `build_info.json` with toolchain paths — these flags are intentionally still accepted, but the public surface for the common case is just: fbuild bloat <project-or-elf> [--build-info <path>] [--json <path>] [--output-dir <dir>] [--top N] Closes#438. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
39df8d9
into
feat/issue-428-buildinfo-toolchain-pathsUh oh!
There was an error while loading. Please reload this page.
Summary
Closes#438 (Phase 2 of #434). Stacked on top of #436 — please merge that first.
Commands::Symbols→Commands::Bloat. Adds clapalias = "symbols"so the legacy spelling still parses to the same handler.symbols_cmd.rs→bloat_cmd.rs,run_symbols→run_bloat.--nm,--cppfilt,--mapwith#[arg(hide = true)]. They keep working as overrides for advanced use, but the public surface is now just<input>,--build-info,--json,--output-dir,--top.docs/symbols.md→docs/bloat.md; updatesdocs/CLAUDE.mdindex entry.bloat_command_parses(canonical spelling) andsymbols_alias_still_parses_as_bloat(back-compat).The
symbol_analysisflag onfbuild buildis not renamed in this PR — that's Phase 5 (#441) which turns it into--bloat.Test plan
soldr cargo check -p fbuild-cli --all-targets✅soldr cargo clippy -p fbuild-cli --all-targets -- -D warnings✅soldr cargo test -p fbuild-cli --bin fbuild— 27 passed (was 25 + 2 new alias tests)🤖 Generated with Claude Code