Uh oh!
There was an error while loading. Please reload this page.
chore(deps): bump managed zccache 1.12.4 -> 1.12.7 - #596
Merged
Conversation
Picks up zackees/zccache#763 (version-namespaced cache root, closeszackees/zccache#762 / #761 / #760 / #759) plus intervening 1.12.5 / 1.12.6 compile-path + observability fixes. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe pinned zccache version in Changeszccache version bump
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Uh oh!
There was an error while loading. Please reload this page.
zackees added a commit
that referenced
this pull request
Jun 15, 2026
Ships the managed zccache bump to 1.12.7 (#596), picking up zackees/zccache#763's version-namespaced cache root. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
zackees added a commit
that referenced
this pull request
Jun 16, 2026
…onitor in_waiting/reset_input_buffer (#606) * feat(serial): #605 Phase 0 — Deployer::post_deploy_recovery + SerialMonitor in_waiting/reset_input_buffer Phase 0 of the deprecation-of-client-pyserial work from #605. Lays the trait + protocol seam that Phase 1 will rewire FastLED-side clients onto. Phase 1 (9-site FastLED autoresearch sweep + tool_guard ban_client_pyserial + FbuildSerialAdapter) tracked separately. What this PR does: * Add `post_deploy_recovery` as a default method on the existing `Deployer` trait (`crates/fbuild-deploy/src/lib.rs`). The default impl is the 3-second 100ms fast-poll lifted verbatim from the daemon's deploy handler — behavior is unchanged for every existing deployer. Override seam left for the planned LPC + CMSIS-DAP wedge-recovery (TODO comment near the impl). * Wire `crates/fbuild-daemon/src/handlers/operations/deploy.rs` to call `deployer.post_deploy_recovery(port)` instead of the inline fast-poll. Closure now returns `Option<Box<dyn Deployer>>` so the verify-skip early-return paths can pass `None` (no recovery needed when no flash actually happened). * Add `SerialMonitor.in_waiting` getter + `reset_input_buffer()` method to the PyO3 binding. They speak two new WebSocket messages to the daemon (`GetInWaiting` → `InWaiting { count }`, and `ClearBuffer`) handled inline in the existing `/ws/serial-monitor` loop. `in_waiting` returns the per-client broadcast queue depth; `reset_input_buffer` drains that queue. Maps to pyserial's `Serial.in_waiting` / `Serial.reset_input_buffer()` (modulo bytes-vs-lines). * Add architectural-commitment row to `CLAUDE.md` declaring `Deployer::post_deploy_recovery` as the seam and `SerialMonitor` as the only blessed client serial path. * Tests: trait dispatch test (override is called through Box<dyn>), default-impl bounded-runtime test, message-roundtrip tests for `ClearBuffer` / `GetInWaiting` / `InWaiting`. Out of scope (Phase 1, tracked): * `_pyserial_dtr_reset` site sweep in FastLED `ci/autoresearch/` * `ban_client_pyserial` rule in FastLED `tool_guard.py` * `FbuildSerialAdapter` in FastLED `ci/util/serial_interface.py` * Windows `CM_Reenumerate_DevNode` LPC-specific override * `probe_open()` method (issue author marked optional) Closes#605 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(ci): #605 trim deploy.rs under LOC gate + rustfmt fixes Round-1 CI fixes for PR #606: * `deploy.rs` was 1017 LOC (over the 1000-line gate). Trimmed verbose comments in the post-deploy recovery dispatch block — the architectural rationale already lives on the trait method itself in fbuild-deploy. Down to 996 LOC. * `cargo fmt` was failing on the new code in `fbuild-deploy/src/lib.rs` (post_deploy_recovery test) and `fbuild-python/src/serial_monitor.rs` (in_waiting let bindings). Re-formatted. Lint subprocess spawns check is pre-existing across all recent merged PRs (#595, #596, #597, #599, #602) — not introduced by this PR. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up zackees/zccache#763 (version-namespaced cache root, closeszackees/zccache#762) plus 1.12.5/1.12.6 fixes.
Summary by CodeRabbit