Skip to content

[codex] ci: restore native Windows release builds - #765

Merged
zackees merged 1 commit into
mainfrom
codex/release-real-windows
Jun 22, 2026
Merged

[codex] ci: restore native Windows release builds#765
zackees merged 1 commit into
mainfrom
codex/release-real-windows

Conversation

@zackees

@zackeeszackees commented Jun 22, 2026

Copy link
Copy Markdown
Member

Summary

Restores Windows release/build jobs to real Windows runners instead of Linux-hosted cargo-xwin cross compilation.

Changes

  • Points the Windows target in build.yml at windows-latest.
  • Points the Windows target in release-auto.yml at windows-latest.
  • Keeps the shared native-build template compatible with Linux-hosted Windows cross builds, but only installs/invokes cargo-xwin when the runner is Linux.
  • Native Windows runners now fall through to the normal soldr cargo build path for CLI, daemon, and Python extension artifacts.

Validation

  • git diff --check -- .github/workflows/release-auto.yml .github/workflows/build.yml .github/workflows/template_native_build.yml

Summary by CodeRabbit

  • Chores
    • Updated Windows build environments to run on appropriate Windows runners instead of Linux-based systems for improved build reliability.
    • Refined cross-compilation workflow conditions to ensure build tools are correctly configured based on the runner environment.

@coderabbitai

coderabbitaiBot commented Jun 22, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d0d04a25-bc5d-465a-835e-e2e4da06d0d9

📥 Commits

Reviewing files that changed from the base of the PR and between 0b00c51 and 3ff5362.

📒 Files selected for processing (3)
  • .github/workflows/build.yml
  • .github/workflows/release-auto.yml
  • .github/workflows/template_native_build.yml

📝 Walkthrough

Walkthrough

The Windows MSVC build target is migrated from Linux cross-compilation to native Windows runners. build.yml and release-auto.yml update the matrix runner from ubuntu-24.04 to windows-latest, and template_native_build.yml adds runner.os == 'Linux' guards to all cargo-xwin, xwin, PyO3 lib fetch, and MSVC build branch steps.

Changes

Windows Native Build Migration

Layer / File(s)Summary
Runner matrix update for Windows MSVC target
.github/workflows/build.yml, .github/workflows/release-auto.yml
The runner value for the x86_64-pc-windows-msvc matrix entry is changed from ubuntu-24.04 to windows-latest in both workflow files.
cargo-xwin and cross-compile step gating in build template
.github/workflows/template_native_build.yml
The Install cargo-xwin, Fetch Windows Python lib for PyO3 cross-compile, Build release binaries (MSVC branch), and Build Python extension (MSVC branch) steps each add runner.os == 'Linux' to their if conditions, restricting cross-compile tooling to Linux runners only.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • FastLED/fbuild#760: Introduced the cargo-xwin and python3.lib fetch steps in template_native_build.yml for Linux-based cross-compilation of pc-windows-msvc — the steps this PR now guards with runner.os == 'Linux'.

Poem

🐰 Hop, hop — no more Linux disguise,
The Windows build now runs under Windows skies!
cargo-xwin stays home when the runner's its own,
No cross-compiling needed when native has grown.
🪟 windows-latest at last, what a wonderful day!

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/release-real-windows

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zackees
zackees marked this pull request as ready for review June 22, 2026 21:04
@zackees
zackees merged commit ed291f6 into mainJun 22, 2026
85 of 91 checks passed
@zackees
zackees deleted the codex/release-real-windows branch June 22, 2026 21:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant

@zackees