Uh oh!
There was an error while loading. Please reload this page.
fix(release): restore macOS + arm64-windows lanes on soldr 0.7.98 + setup-soldr v0.9.64 - #941
Merged
Merged
Conversation
…etup-soldr v0.9.64 The macOS drop and the aarch64-pc-windows-msvc drop were both fallout from a soldr-version incompatibility window that is now closed: * The "setup-soldr version --json incompatibility" that blocked bumping soldr past v0.7.66 was a misdiagnosis — soldr v0.7.85 and v0.7.87 were broken releases that shipped silent binaries. The JSON shape never changed. setup-soldr@v0.9.64 hardens against silent binaries with an actionable error. * soldr v0.7.98 carries the Apple SDK URL fix (soldr#992 fallout), ships soldr-clang-shim in release archives (unblocks ring on aarch64-pc-windows-msvc), forwards cargo:rustc-env vars through the wrapper, and provisions managed cmake/ninja. All 7 soldr cross lanes verified green upstream. Changes: * pin soldr 0.7.98 + setup-soldr v0.9.64 across all workflows, ci/docker-mac-cross, and docs/RELEASING.md * restore aarch64-apple-darwin + x86_64-apple-darwin release matrix entries and the darwin ARTIFACT_MAP row in ci/publish.py * restore the aarch64-pc-windows-msvc lane * derive the expected-wheel counts dynamically (PLATFORMS SOT / built-wheel count) — the stale hardcoded 4 failed every release in the 2.3.22-2.3.24 window even when PyPI publish succeeded * bump 2.3.24 -> 2.4.0 (pyproject.toml + Cargo.toml + Cargo.lock) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (18)
👮 Files not reviewed due to content moderation or server errors (18)
📝 Walkthrough
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Uh oh!
There was an error while loading. Please reload this page.
zackees added a commit
that referenced
this pull request
Jul 2, 2026
…ntion rustdoc treated it as an intra-doc link and -D warnings failed the Documentation workflow (also since #941). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
zackees added a commit
that referenced
this pull request
Jul 2, 2026
#948) * fix(config): derive Default for BoardConfig (unbreaks workspace check) PR #941 added probe_rs tests constructing BoardConfig with ..Default::default(), but the struct never derived Default, so 'soldr cargo check/test --all-targets' has failed workspace-wide on main since (Check ubuntu/macos + Documentation red on every PR). All fields are String/Option types; the derive is purely additive. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * docs(deploy): drop bracket link syntax on framework-arduino-lpc8xx mention rustdoc treated it as an intra-doc link and -D warnings failed the Documentation workflow (also since #941). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores the release lanes dropped during the soldr-version incompatibility window, which is now closed.
The misdiagnosis
The "setup-soldr
version --jsonincompatibility" that pinned fbuild to soldr 0.7.59 and forced the macOS drop was never a JSON-shape change — soldr v0.7.85/v0.7.87 were broken releases that shipped completely silent binaries (zero bytes on stdout for every subcommand), which setup-soldr surfaced asUnexpected end of JSON input. Verified by running the actual published binaries of v0.7.59/0.7.66/0.7.85/0.7.87/0.7.89-0.7.96: the JSON is byte-identical across the working ones. setup-soldr@v0.9.64 (just released) hardens against silent binaries with an actionable error naming the broken releases.What soldr v0.7.98 brings (all 7 soldr cross lanes verified green upstream)
soldr-clang-shimshipped in release archives → ring 0.17.x cross toaarch64-pc-windows-msvcworks (the v0.7.65 archive was missing it)cargo:rustc-envvars (fix(cross): linux-arm-musl lane — wrapper env allowlist dropped crgx's cargo:rustc-env CRGX_TARGET zackees/soldr#1284) — fbuild's own builds benefitpip install soldrglibc<2.39 placeholder trap is gone)Changes
ci/docker-mac-cross/Dockerfile(incl. dead APPLE_SDK_URL default → soldr-toolchain assets URL),docs/RELEASING.mdaarch64-apple-darwin,x86_64-apple-darwin,aarch64-pc-windows-msvc(6 lanes total)ci/publish.py::ARTIFACT_MAP: darwin-arm64 wheel restored (Intel mac + ARM-Windows artifacts ship as GH-release archives)4failed every release run in the 2.3.22–2.3.24 window even when the PyPI publish itself succeededMerging this to main triggers the Autonomous Release for 2.4.0 with the full 6-lane matrix.
🤖 Generated with Claude Code