Skip to content

Fixed concept ancestry bug and added tests to make sure this is detected - #52

Merged
javier-gracia-tabuenca-tuni merged 3 commits into
developmentfrom
51-concept-ancestry-sql-fix
Sep 16, 2025
Merged

Fixed concept ancestry bug and added tests to make sure this is detected#52
javier-gracia-tabuenca-tuni merged 3 commits into
developmentfrom
51-concept-ancestry-sql-fix

Conversation

@shanmukhasampath

Copy link
Copy Markdown
Collaborator

This is for issue #51

Added tests and they are working.

@shanmukhasampathshanmukhasampath self-assigned this Sep 12, 2025
@shanmukhasampathshanmukhasampath linked an issue Sep 12, 2025 that may be closed by this pull request
4 tasks
@javier-gracia-tabuenca-tuni

Copy link
Copy Markdown
Member

adding the whole ICD9 usagi seems too much for testing one line only
this affects the speed of the other unit tests and total size
can you just add only the needed line to the ICD10 usagi file
or
is it even necesary the ICD9 if in the ICD10 the ancesto to the own usagi file is also contemplated ??

@shanmukhasampath

shanmukhasampath commented Sep 15, 2025

Copy link
Copy Markdown
CollaboratorAuthor

adding the whole ICD9 usagi seems too much for testing one line only this affects the speed of the other unit tests and total size can you just add only the needed line to the ICD10 usagi file or is it even necesary the ICD9 if in the ICD10 the ancesto to the own usagi file is also contemplated ??

Hi @javier-gracia-tabuenca-tuni, it is not necessary I can change it to ICD10 Usagi file. Initially, I wanted to check whether the NA and empty string match happens in other vocabularies as well. There are instances in ICD10 where this is the case, I can fix this

@shanmukhasampath

Copy link
Copy Markdown
CollaboratorAuthor

Hi @javier-gracia-tabuenca-tuni, I have fixed all the files and it showed no problems in my Rstudio but somehow it fails in the check. Will you please let me know what it is that I am missing on my side.

@shanmukhasampathshanmukhasampath added the bug Something isn't working label Sep 15, 2025
@javier-gracia-tabuenca-tuni

Copy link
Copy Markdown
Member

DQD package has been updated with new tests,
it tests if some tables are empty, which they are in this test database, as we dont use all tables here
it fails in github bcs it takes the latest version whereas in your laptop you may have a previus version
I will fix this

@javier-gracia-tabuenca-tuni
javier-gracia-tabuenca-tuni merged commit aeea65b into developmentSep 16, 2025
1 check passed
@shanmukhasampath

Copy link
Copy Markdown
CollaboratorAuthor

Hi @javier-gracia-tabuenca-tuni,
thanks for the message.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugSomething isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

concept ancestry sql fix

2 participants

@shanmukhasampath@javier-gracia-tabuenca-tuni