Correction of the return values of the DatabaseInfo methods for determining the insert, read and delete operations by DevM900 · Pull Request #1183 · FirebirdSQL/NETProvider

DevM900 · 2024-07-04T07:26:45Z

These changes make it possible to analyze the performance of queries.

…ort Firebird Server 2.0.

…per table since the last connection to the database

…per table since the last connection to the database. fixesFirebirdSQL#1157

…into DatabaseInfo

…s etc

cincuranet · 2024-08-26T18:08:45Z

+ IDictionary<short, ulong> readSeqCount = dbInfo.GetReadSeqCount();
+ IDictionary<short, ulong> readIdxCount = dbInfo.GetReadIdxCount();
+
+ var fbCommand = new FbCommand("SELECT MAX(INT_FIELD) FROM TEST", Connection);


await using

Does not look like it's here.

cincuranet · 2024-08-26T18:08:57Z

+ IDictionary<short, ulong> readSeqCount = dbInfo.GetReadSeqCount();
+ IDictionary<short, ulong> readIdxCount = dbInfo.GetReadIdxCount();
+
+ var fbCommand = new FbCommand("INSERT INTO TEST (INT_FIELD) VALUES (900)", Connection);


await using

Does not look like it's here.

cincuranet · 2024-08-26T18:09:03Z

+ IDictionary<string, short> tableNameList = GetTableNameList();
+ short tableIdTest = tableNameList["TEST"];
+
+ var fbCommand = new FbCommand("INSERT INTO TEST (INT_FIELD) VALUES (900)", Connection);


await using

Does not look like it's here.

cincuranet · 2024-08-26T18:15:40Z

+ if (counter > 0)
+ result.Add(keyValuePair.Key, counter);
+ }
+ else


Add }/{ for consistency sake.

Does not look like it's here.

fdcastel · 2024-10-25T19:37:43Z

@cincuranet it appears that all requested changes have been addressed by @DevM900 (but weren't marked as "resolved").

Could you please review and proceed with the merge?

cincuranet · 2024-11-04T12:57:38Z

Not really. Some are still not addressed and going through it again I found some more.

cincuranet · 2024-11-05T12:44:38Z

+ IDictionary<short, ulong> readSeqCount = dbInfo.GetReadSeqCount();
+ IDictionary<short, ulong> readIdxCount = dbInfo.GetReadIdxCount();
+
+ var fbCommand = new FbCommand("SELECT MAX(INT_FIELD) FROM TEST", Connection);


Does not look like it's here.

cincuranet · 2024-11-05T12:45:01Z

+ IDictionary<short, ulong> readSeqCount = dbInfo.GetReadSeqCount();
+ IDictionary<short, ulong> readIdxCount = dbInfo.GetReadIdxCount();
+
+ var fbCommand = new FbCommand("INSERT INTO TEST (INT_FIELD) VALUES (900)", Connection);


Does not look like it's here.

cincuranet · 2024-11-05T12:45:45Z

+ IDictionary<string, short> tableNameList = GetTableNameList();
+ short tableIdTest = tableNameList["TEST"];
+
+ var fbCommand = new FbCommand("INSERT INTO TEST (INT_FIELD) VALUES (900)", Connection);


Does not look like it's here.

cincuranet · 2024-11-05T12:45:57Z

+
+	private IDictionary<string, short> GetTableNameList()
+	{
+ IDictionary<string, short> result = new Dictionary<string, short>();


Does not look like it's here.

cincuranet · 2024-11-06T09:46:58Z

 	}

-	IDictionary<short, ulong> GetAffectedTables(IDictionary<short, ulong> statisticInfoBefore, IDictionary<short, ulong> statisticInfoAfter)
+async Task<IDictionary<short, ulong>> GetAffectedTables(IDictionary<short, ulong> statisticInfoBefore, IDictionary<short, ulong> statisticInfoAfter)


DevM900 added 8 commits June 27, 2024 14:15

Creation of backup and restore statistics can be switched off to supp…
b492cce
…ort Firebird Server 2.0.

Determination of the correct number of reads, inserts, deletes, etc. …
c39be07
…per table since the last connection to the database

Determination of the correct number of reads, inserts, deletes, etc. …
1fd2464
…per table since the last connection to the database. fixesFirebirdSQL#1157

Added comments.
9112e28

Merge branch 'DatabaseInfo' ofhttps://github.com/DevM900/NETProvider…
c00d785
…into DatabaseInfo

Type of the key of the result collection changed from "uint" to "short".
124e5f3

Type of the key of the result collection changed from "uint" to "short".
c43a1bf

Added tests for determination of the number of reads, inserts, delete…
72ed318
…s etc

cincuranet requested changes Aug 26, 2024
View reviewed changes

cincuranet added blocked/waiting and removed blocked/waiting labels Aug 26, 2024

DevM900 added 6 commits September 13, 2024 07:13

using await
aa0d9f7

changed to var
2acda4a

prefix on argument removed,
7edc7ee

extra spaces removed
367af06

'private' modifier removed
600fb37

prefix 'a' on arguments removed
3f1e72c

DevM900 requested a review from cincuranet September 13, 2024 09:10

Merge remote-tracking branch 'upstream/master' into DatabaseInfo
a9311a0

cincuranet requested changes Nov 4, 2024
View reviewed changes

DevM900 added 6 commits November 4, 2024 14:47

Typo statistic -> statistics
cef7087

removed not needed "using"
e720df4

changed to "var"
bf09d5a

Using async/await in "GetTableNameList"
fa0f53c

added “using” to ensure that resources are released
9470f22

moved "trim" to SQL
187ab1c

DevM900 closed this Nov 5, 2024

DevM900 reopened this Nov 5, 2024

cincuranet requested changes Nov 5, 2024
View reviewed changes

added missing async/await
fe4c525

cincuranet reviewed Nov 6, 2024
View reviewed changes

Uh oh!

Uh oh!

Conversation

DevM900 commented Jul 4, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

fdcastel commented Oct 25, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cincuranet commented Nov 4, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants