Skip to content

fix(serializing): correct two's-complement unwrap in quaternion decompression #1067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FirstGearGames merged 1 commit into from
Aug 21, 2026
+9 −15
Merged

fix(serializing): correct two's-complement unwrap in quaternion decompression #1067

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions Assets/FishNet/Runtime/Serializing/Helping/Quaternion32Compression.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,11 +118,9 @@ private static uint ScaleToUint(float v)

private static float ScaleToFloat(uint v)
{
float unscaled = v * Maximum / IntScale;

if (unscaled > Maximum)
unscaled -= Maximum * 2;
return unscaled;
// Values above IntScale are two's-complement negatives produced by ScaleToUint's mask.
int signed = v > IntScale ? (int)v - (IntMask + 1) : (int)v;
return signed * Maximum / IntScale;
}

/// <summary>
Expand Down
16 changes: 6 additions & 10 deletions Assets/FishNet/Runtime/Serializing/Helping/Quaternion64Compression.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,20 +111,16 @@ private static ulong ScaleToUint_L(float v)

private static float ScaleToFloat_H(ulong v)
{
float unscaled = v * Maximum / IntScale_H;

if (unscaled > Maximum)
unscaled -= Maximum * 2;
return unscaled;
// Values above IntScale are two's-complement negatives produced by ScaleToUint's mask.
long signed = v > IntScale_H ? (long)v - (IntMask_H + 1) : (long)v;
return signed * Maximum / IntScale_H;
}

private static float ScaleToFloat_L(ulong v)
{
float unscaled = v * Maximum / IntScale_L;

if (unscaled > Maximum)
unscaled -= Maximum * 2;
return unscaled;
// Values above IntScale are two's-complement negatives produced by ScaleToUint's mask.
long signed = v > IntScale_L ? (long)v - (IntMask_L + 1) : (long)v;
return signed * Maximum / IntScale_L;
}

public static Quaternion Decompress(ulong compressed)
Expand Down