Skip to content

feat: Set If-Modified-Since header for environment document requests - #159

Merged
rolodato merged 4 commits into
mainfrom
feat/environment-document-304
Apr 30, 2025
Merged

rolodato merged 4 commits into
mainfrom
feat/environment-document-304

Conversation

@rolodato

Copy link
Copy Markdown
Contributor

Adds support for Flagsmith/flagsmith#5283

Example log output:

❯ rye run edge-proxy-serve
2025-04-29 19:26:49 [info     ] Loaded configuration from config.json
2025-04-29 19:26:49 [info     ] Loaded configuration from config.json
2025-04-29T22:26:49.666581Z [info     ] Started server process [50212] [uvicorn.error]
2025-04-29T22:26:49.666789Z [info     ] Waiting for application startup. [uvicorn.error]
2025-04-29T22:26:49.701255Z [info     ] HTTP Request: GET http://localhost:8000/api/v1/environment-document/ "HTTP/1.1 200 OK" [httpx]
2025-04-29T22:26:49.701813Z [info     ] Application startup complete.  [uvicorn.error]
2025-04-29T22:26:49.702157Z [info     ] Uvicorn running on http://0.0.0.0:8000 (Press CTRL+C to quit) [uvicorn.error]
2025-04-29T22:26:49.702853Z [info     ] HTTP Request: GET http://localhost:8000/api/v1/environment-document/ "HTTP/1.1 304 Not Modified" [httpx]
2025-04-29T22:26:52.707151Z [info     ] HTTP Request: GET http://localhost:8000/api/v1/environment-document/ "HTTP/1.1 304 Not Modified" [httpx]
2025-04-29T22:26:55.710535Z [info     ] HTTP Request: GET http://localhost:8000/api/v1/environment-document/ "HTTP/1.1 304 Not Modified" [httpx]

@rolodato rolodato changed the title feat: Set If-Modified-Since header for environment documents feat: Set If-Modified-Since header for environment document requests Apr 30, 2025
@matthewelwell
matthewelwell self-requested a review April 30, 2025 12:48
Comment thread src/edge_proxy/environments.py
Comment thread src/edge_proxy/environments.py
Comment thread tests/fixtures/response_data.py
@rolodato
rolodato requested a review from matthewelwell April 30, 2025 15:45
Comment thread src/edge_proxy/environments.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants